Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] waterfall chart - support wildcard search #191132

Conversation

dominiqueclarke
Copy link
Contributor

@dominiqueclarke dominiqueclarke commented Aug 22, 2024

Summary

Resolves #172033

Release note

Enables wildcard search for the Synthetics waterfall chart.

Testing

  1. Create a browser monitor
  2. Navigate to the waterfall chart
  3. Add a wildcard search in the text box. For example *.js.
  4. You shouldn't see an error, and it should match all requests with .js in the name

@dominiqueclarke
Copy link
Contributor Author

/ci

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@dominiqueclarke
Copy link
Contributor Author

/ci

@dominiqueclarke
Copy link
Contributor Author

/ci

@dominiqueclarke dominiqueclarke added bug Fixes for quality problems that affect the customer experience v8.16.0 v8.15.1 release_note:fix Team:obs-ux-management Observability Management User Experience Team labels Aug 23, 2024
@dominiqueclarke dominiqueclarke marked this pull request as ready for review August 23, 2024 01:29
@dominiqueclarke dominiqueclarke requested a review from a team as a code owner August 23, 2024 01:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Aug 23, 2024
…ub.com:dominiqueclarke/kibana into fix/synthetics-waterfall-chart-wildcard-search
@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 23, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: 8221a7c
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-191132-8221a7c7f7a8

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 937.6KB 937.6KB +85.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dominiqueclarke dominiqueclarke merged commit eca2cdc into elastic:main Aug 23, 2024
23 checks passed
@dominiqueclarke dominiqueclarke deleted the fix/synthetics-waterfall-chart-wildcard-search branch August 23, 2024 17:01
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 23, 2024
## Summary

Resolves elastic#172033

### Release note
Enables wildcard search for the Synthetics waterfall chart.

### Testing

1. Create a browser monitor
2. Navigate to the waterfall chart
3. Add a wildcard search in the text box. For example `*.js`.
4. You shouldn't see an error, and it should match all requests with
`.js` in the name

(cherry picked from commit eca2cdc)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 23, 2024
… (#191215)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Synthetics] waterfall chart - support wildcard search
(#191132)](#191132)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dominique
Clarke","email":"dominique.clarke@elastic.co"},"sourceCommit":{"committedDate":"2024-08-23T17:01:31Z","message":"[Synthetics]
waterfall chart - support wildcard search (#191132)\n\n##
Summary\r\n\r\nResolves
https://github.com/elastic/kibana/issues/172033\r\n\r\n### Release
note\r\nEnables wildcard search for the Synthetics waterfall
chart.\r\n\r\n### Testing\r\n\r\n1. Create a browser monitor\r\n2.
Navigate to the waterfall chart\r\n3. Add a wildcard search in the text
box. For example `*.js`. \r\n4. You shouldn't see an error, and it
should match all requests with\r\n`.js` in the
name","sha":"eca2cdc40dc0d41f7c33648b8c622f48d1413170","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0","v8.15.1"],"title":"[Synthetics]
waterfall chart - support wildcard
search","number":191132,"url":"https://github.com/elastic/kibana/pull/191132","mergeCommit":{"message":"[Synthetics]
waterfall chart - support wildcard search (#191132)\n\n##
Summary\r\n\r\nResolves
https://github.com/elastic/kibana/issues/172033\r\n\r\n### Release
note\r\nEnables wildcard search for the Synthetics waterfall
chart.\r\n\r\n### Testing\r\n\r\n1. Create a browser monitor\r\n2.
Navigate to the waterfall chart\r\n3. Add a wildcard search in the text
box. For example `*.js`. \r\n4. You shouldn't see an error, and it
should match all requests with\r\n`.js` in the
name","sha":"eca2cdc40dc0d41f7c33648b8c622f48d1413170"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/191132","number":191132,"mergeCommit":{"message":"[Synthetics]
waterfall chart - support wildcard search (#191132)\n\n##
Summary\r\n\r\nResolves
https://github.com/elastic/kibana/issues/172033\r\n\r\n### Release
note\r\nEnables wildcard search for the Synthetics waterfall
chart.\r\n\r\n### Testing\r\n\r\n1. Create a browser monitor\r\n2.
Navigate to the waterfall chart\r\n3. Add a wildcard search in the text
box. For example `*.js`. \r\n4. You shouldn't see an error, and it
should match all requests with\r\n`.js` in the
name","sha":"eca2cdc40dc0d41f7c33648b8c622f48d1413170"}},{"branch":"8.15","label":"v8.15.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience ci:project-deploy-observability Create an Observability project release_note:fix Team:obs-ux-management Observability Management User Experience Team v8.15.1 v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Synthetics] Network Request search bar throws error for wildcard matches
6 participants