Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Application Service] Improve after-setup error message #191170

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

afharo
Copy link
Member

@afharo afharo commented Aug 23, 2024

Summary

In 8.15, it looks like there's an app trying to register after the setup is complete.

image

However, the existing error doesn't show which app it is. This PR adds the app ID to the error message so we know where to start with.

Might be related to #90536, but it's not confirmed.

Checklist

For maintainers

@afharo afharo added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Aug 23, 2024
@afharo afharo self-assigned this Aug 23, 2024
@afharo afharo requested a review from a team as a code owner August 23, 2024 08:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@afharo afharo enabled auto-merge (squash) August 23, 2024 08:47
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 420.0KB 420.0KB +34.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @afharo

@afharo afharo merged commit 745ecfd into elastic:main Aug 23, 2024
21 checks passed
@afharo afharo deleted the app-service/improve-error-message branch August 23, 2024 17:33
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 23, 2024
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 23, 2024
…) (#191220)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Application Service] Improve after-setup error message
(#191170)](#191170)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alejandro Fernández
Haro","email":"alejandro.haro@elastic.co"},"sourceCommit":{"committedDate":"2024-08-23T17:33:48Z","message":"[Application
Service] Improve after-setup error message
(#191170)","sha":"745ecfdd30db71514b23c30bb7b87d93dade8b03","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","technical
debt","release_note:skip","backport:prev-minor","v8.16.0"],"title":"[Application
Service] Improve after-setup error
message","number":191170,"url":"https://github.com/elastic/kibana/pull/191170","mergeCommit":{"message":"[Application
Service] Improve after-setup error message
(#191170)","sha":"745ecfdd30db71514b23c30bb7b87d93dade8b03"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/191170","number":191170,"mergeCommit":{"message":"[Application
Service] Improve after-setup error message
(#191170)","sha":"745ecfdd30db71514b23c30bb7b87d93dade8b03"}}]}]
BACKPORT-->

Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture v8.15.1 v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants