Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] Only log requests to Inspector on request complete #191232

Merged
merged 9 commits into from
Aug 29, 2024
Merged

[ES|QL] Only log requests to Inspector on request complete #191232

merged 9 commits into from
Aug 29, 2024

Conversation

lukasolson
Copy link
Member

@lukasolson lukasolson commented Aug 23, 2024 •
edited
Loading

Summary

Requires #191520.
Resolves #188266.

Prior to this PR, when polling on an async ES|QL request, we would log the response to every polling request. This PR only logs when the request is complete.

Before:

image

After:

image

Checklist

@lukasolson
Copy link
Member Author

/ci

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6823

[✅] test/functional/apps/discover/esql/config.ts: 25/25 tests passed.

see run history

@lukasolson lukasolson marked this pull request as ready for review August 28, 2024 17:16
@lukasolson lukasolson requested review from a team as code owners August 28, 2024 17:16
@lukasolson lukasolson self-assigned this Aug 28, 2024
@lukasolson lukasolson added release_note:fix Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:ESQL ES|QL related features in Kibana v8.16.0 labels Aug 28, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

nreese
nreese approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana-presentation changes LGTM
code review only

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
inspector 28.2KB 28.3KB +45.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 418.8KB 418.9KB +35.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lukasolson

davismcphee
davismcphee approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good, and it works well 👍 Thanks for fixing this!

@stratoula
Copy link
Contributor

Awesome Lukas 🙇

@lukasolson lukasolson merged commit c71c0df into elastic:main Aug 29, 2024
22 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davismcphee davismcphee davismcphee approved these changes

@dej611 dej611 dej611 approved these changes

@nreese nreese nreese approved these changes

Assignees

@lukasolson lukasolson

Labels
backport:skip This commit does not require backporting release_note:fix Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:ESQL ES|QL related features in Kibana v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ES|QL mode shows extra entries in Inspector
8 participants
@lukasolson @kibanamachine @elasticmachine @kibana-ci @stratoula @nreese @dej611 @davismcphee