Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MX] Mute alert options with read only permission #191283

Conversation

guskovaue
Copy link
Contributor

@guskovaue guskovaue commented Aug 26, 2024

Issue: #191060

Checklist

@guskovaue guskovaue added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.16.0 labels Aug 26, 2024
@guskovaue guskovaue self-assigned this Aug 26, 2024
@guskovaue
Copy link
Contributor Author

/ci

@guskovaue guskovaue marked this pull request as ready for review August 28, 2024 15:52
@guskovaue guskovaue requested a review from a team as a code owner August 28, 2024 15:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@guskovaue guskovaue requested a review from a team as a code owner August 29, 2024 12:44
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Aug 29, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@guskovaue guskovaue added release_note:fix and removed release_note:skip Skip the PR/issue when compiling release notes labels Aug 29, 2024
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.6MB 1.6MB +105.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @guskovaue

@guskovaue guskovaue merged commit 2d81ab6 into elastic:main Aug 29, 2024
27 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 29, 2024
Issue: elastic#191060

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios.

(cherry picked from commit 2d81ab6)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 2, 2024
…191740)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[MX] Mute alert options with read only permission
(#191283)](#191283)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Julia","email":"iuliia.guskova@elastic.co"},"sourceCommit":{"committedDate":"2024-08-29T14:35:52Z","message":"[MX]
Mute alert options with read only permission (#191283)\n\nIssue:
https://github.com/elastic/kibana/issues/191060\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios.","sha":"2d81ab694e079c4cc1d9ebc3b8586f4bfe7bb20a","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:ResponseOps","ci:project-deploy-observability","Team:obs-ux-management","v8.15.0","v8.16.0"],"title":"[MX]
Mute alert options with read only
permission","number":191283,"url":"https://github.com/elastic/kibana/pull/191283","mergeCommit":{"message":"[MX]
Mute alert options with read only permission (#191283)\n\nIssue:
https://github.com/elastic/kibana/issues/191060\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios.","sha":"2d81ab694e079c4cc1d9ebc3b8586f4bfe7bb20a"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/191283","number":191283,"mergeCommit":{"message":"[MX]
Mute alert options with read only permission (#191283)\n\nIssue:
https://github.com/elastic/kibana/issues/191060\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios.","sha":"2d81ab694e079c4cc1d9ebc3b8586f4bfe7bb20a"}}]}]
BACKPORT-->

Co-authored-by: Julia <iuliia.guskova@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:project-deploy-observability Create an Observability project release_note:fix Team:obs-ux-management Observability Management User Experience Team Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.15.0 v8.15.1 v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ResponseOps][Alerts] Mute alert option visible to user with only read permission
6 participants