feat(rca): edit notes #191546
Merged
feat(rca): edit notes #191546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
kdelemme
added
release_note:skip
|
/ci |
|
/ci |
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
botelastic
bot
added
the
ci:project-deploy-observability
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
History
To update your PR or re-run it, just comment with: |
benakansara
reviewed
Aug 29, 2024
| throw new Error('User does not have permission to delete note'); | ||
| } | ||
|
|
||
| investigation.notes = investigation.notes.filter((currNote) => { |
There was a problem hiding this comment.
nit: maybe find or forEach would be better instead of filter?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #190358
Summary
This PR adds a new API to update an existing note, and allow the author of the note to edit their note from the UI.
I've also addressed a few comments mentioned in the base PR, namely the 'esql' constant.
This PR will be rebased when the blocked PR is merged, and then opened for review to avoid tagging more people than needed.
Screen.Recording.2024-08-27.at.3.07.41.PM.mov