Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spaces] Enhancement in create space UI #191586

Merged
merged 6 commits into from
Aug 29, 2024

Conversation

sebelga
Copy link
Contributor

@sebelga sebelga commented Aug 28, 2024

In this PR I've added a few enhancements to the manage Space (create) UI.

  • Added a placeholder to indicate what the undefined value means
Screenshot 2024-08-28 at 10 59 17
  • Added a new form validation to require the solution view to be set (only when creating a new space)
Screenshot 2024-08-28 at 11 16 15

@sebelga sebelga self-assigned this Aug 28, 2024
@sebelga sebelga added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Aug 28, 2024
@sebelga
Copy link
Contributor Author

sebelga commented Aug 28, 2024

/ci

@sebelga sebelga added the release_note:skip Skip the PR/issue when compiling release notes label Aug 28, 2024
@sebelga
Copy link
Contributor Author

sebelga commented Aug 28, 2024

/ci

@sebelga sebelga marked this pull request as ready for review August 29, 2024 11:05
@sebelga sebelga requested a review from a team as a code owner August 29, 2024 11:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

Copy link
Contributor

@SiddharthMantri SiddharthMantri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ran locally - i can see the expected change.
image

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
spaces 184.5KB 185.1KB +654.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sebelga

@sebelga
Copy link
Contributor Author

sebelga commented Aug 29, 2024

Thanks for the review @SiddharthMantri !

@sebelga sebelga merged commit 3a57478 into elastic:main Aug 29, 2024
21 checks passed
@sebelga sebelga deleted the space-ui/tweaks-solution-selection branch August 29, 2024 13:18
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants