Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Move @kbn/config-schema to server] kbn-io-ts-utils #191692

Merged

Conversation

afharo
Copy link
Member

@afharo afharo commented Aug 29, 2024

Summary

Part of #189476.

We want to avoid @kbn/config-schema from leaking to the browser, and this package depends on it.

More specifically, this PR removes an unused API from the @kbn/io-ts-utils package to remove its dependency on @kbn/config-schema.

For maintainers

@afharo afharo added technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:obs-knowledge Observability Experience Knowledge team labels Aug 29, 2024
@afharo afharo requested a review from a team as a code owner August 29, 2024 00:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-knowledge-team (Team:obs-knowledge)

@afharo afharo enabled auto-merge (squash) August 29, 2024 00:25
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo merged commit b79f5ab into elastic:main Aug 29, 2024
23 checks passed
@afharo afharo deleted the move-config-schema-to-server/kbn-io-ts-utils branch August 29, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-knowledge Observability Experience Knowledge team technical debt Improvement of the software architecture and operational architecture v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants