[Defend Workflows] Fix bug when event filter value cannot be changed without using {backspace} #192196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gergoabraham
added
release_note:skip
|
/ci |
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
vitaliidm
approved these changes
Sep 9, 2024
Comment on lines
173
to
177
| if (searchVal) { | ||
| onChange(''); | ||
| } | ||
|
|
||
| setSearchQuery(searchVal); |
There was a problem hiding this comment.
would be great to add here comments what these 2 calls doing and why they needed
There was a problem hiding this comment.
added, thanks for the review!
dd2bf53
ashokaditya
reviewed
Sep 9, 2024
|
|
||
| expect(mockOnChange).toHaveBeenCalledWith('value 1'); | ||
| }); | ||
|
|
||
| test('it invokes "onChange" with empty value (i.e. clears selection) when new value searched', async () => { |
There was a problem hiding this comment.
nit: no need for an async block here
There was a problem hiding this comment.
🦅 👁️ !
27c1c4d
ashokaditya
approved these changes
Sep 9, 2024
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
gergoabraham
added
v8.16.0
and removed
backport:skip
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
gergoabraham
added a commit
to gergoabraham/kibana
that referenced
this pull request
Sep 16, 2024
…without using {backspace} (elastic#192196)
## Summary
This PR does 2 things around editing the value field for an Event
Filter.
1. It fixes the issue when during editing an existing Event Filter you
cannot update the value without pressing {backspace}, by clearing
selection when user is typing: 5da28aa
Before:
➡️
After:
2. Improves suggestions: before the change, suggestions were there
initially, but after they are narrowed down by typing, they won't be
displayed again after the user clears the input field. Therefore
f9d60cf sets the suggestion search
query unconditionally, helping with this issue.
Before:
➡️
After:
### Checklist
Delete any items that are not applicable to this PR.
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
---------
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit b31d119)
gergoabraham
added a commit
that referenced
this pull request
Sep 16, 2024
…anged without using {backspace} (#192196) (#192977)
# Backport
This will backport the following commits from `main` to `8.x`:
- [[Defend Workflows] Fix bug when event filter value cannot be changed
without using {backspace}
(#192196)](#192196)
<!--- Backport version: 9.6.0 -->
### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)
<!--BACKPORT [{"author":{"name":"Gergő
Ábrahám","email":"gergo.abraham@elastic.co"},"sourceCommit":{"committedDate":"2024-09-13T16:59:44Z","message":"[Defend
Workflows] Fix bug when event filter value cannot be changed without
using {backspace} (#192196)\n\n## Summary\r\n\r\nThis PR does 2 things
around editing the value field for an Event\r\nFilter.\r\n\r\n1. It
fixes the issue when during editing an existing Event Filter
you\r\ncannot update the value without pressing {backspace}, by
clearing\r\nselection when user is typing:
5da28aa\r\nBefore:\r\n\r\n\r\n➡️
\r\nAfter:\r\n\r\n\r\n\r\n2.
Improves suggestions: before the change, suggestions were
there\r\ninitially, but after they are narrowed down by typing, they
won't be\r\ndisplayed again after the user clears the input field.
Therefore\r\nf9d60cf223644a3072d1a60fe273586338247b96 sets the
suggestion search\r\nquery unconditionally, helping with this
issue.\r\nBefore:\r\n\r\n\r\n➡️
\r\nAfter:\r\n\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"b31d119e5532c362c44a134547f461fd7db56770","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","v9.0.0","Team:Defend
Workflows"],"title":"[Defend Workflows] Fix bug when event filter value
cannot be changed without using
{backspace}","number":192196,"url":"https://github.com/elastic/kibana/pull/192196","mergeCommit":{"message":"[Defend
Workflows] Fix bug when event filter value cannot be changed without
using {backspace} (#192196)\n\n## Summary\r\n\r\nThis PR does 2 things
around editing the value field for an Event\r\nFilter.\r\n\r\n1. It
fixes the issue when during editing an existing Event Filter
you\r\ncannot update the value without pressing {backspace}, by
clearing\r\nselection when user is typing:
5da28aa\r\nBefore:\r\n\r\n\r\n➡️
\r\nAfter:\r\n\r\n\r\n\r\n2.
Improves suggestions: before the change, suggestions were
there\r\ninitially, but after they are narrowed down by typing, they
won't be\r\ndisplayed again after the user clears the input field.
Therefore\r\nf9d60cf223644a3072d1a60fe273586338247b96 sets the
suggestion search\r\nquery unconditionally, helping with this
issue.\r\nBefore:\r\n\r\n\r\n➡️
\r\nAfter:\r\n\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"b31d119e5532c362c44a134547f461fd7db56770"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192196","number":192196,"mergeCommit":{"message":"[Defend
Workflows] Fix bug when event filter value cannot be changed without
using {backspace} (#192196)\n\n## Summary\r\n\r\nThis PR does 2 things
around editing the value field for an Event\r\nFilter.\r\n\r\n1. It
fixes the issue when during editing an existing Event Filter
you\r\ncannot update the value without pressing {backspace}, by
clearing\r\nselection when user is typing:
5da28aa\r\nBefore:\r\n\r\n\r\n➡️
\r\nAfter:\r\n\r\n\r\n\r\n2.
Improves suggestions: before the change, suggestions were
there\r\ninitially, but after they are narrowed down by typing, they
won't be\r\ndisplayed again after the user clears the input field.
Therefore\r\nf9d60cf223644a3072d1a60fe273586338247b96 sets the
suggestion search\r\nquery unconditionally, helping with this
issue.\r\nBefore:\r\n\r\n\r\n➡️
\r\nAfter:\r\n\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"b31d119e5532c362c44a134547f461fd7db56770"}}]}]
BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR does 2 things around editing the value field for an Event Filter.
It fixes the issue when during editing an existing Event Filter you cannot update the value without pressing {backspace}, by clearing selection when user is typing: 5da28aa
Before:
➡️
After:
Improves suggestions: before the change, suggestions were there initially, but after they are narrowed down by typing, they won't be displayed again after the user clears the input field. Therefore f9d60cf sets the suggestion search query unconditionally, helping with this issue.
Before:
➡️
After:
Checklist
Delete any items that are not applicable to this PR.