Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Console] Fix flaky tests and unskip the ones that now work #193237

Merged
merged 4 commits into from
Sep 18, 2024
Merged

[Console] Fix flaky tests and unskip the ones that now work #193237

merged 4 commits into from
Sep 18, 2024

Conversation

sabarasaba
Copy link
Member

Summary

Unskip and fix flaky tests

Closes: #186501 #186935

@sabarasaba sabarasaba added Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.16.0 labels Sep 18, 2024
@sabarasaba sabarasaba self-assigned this Sep 18, 2024
@sabarasaba
Copy link
Member Author

/ci

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6968

[✅] test/functional/apps/console/config.ts: 100/100 tests passed.

see run history

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #5 / Use get case configuration hook returns the initial configuration if none matches the owner

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sabarasaba

@sabarasaba sabarasaba marked this pull request as ready for review September 18, 2024 06:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

ElenaStoeva
ElenaStoeva approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these tests @sabarasaba! Lgtm 👍

@sabarasaba sabarasaba added backport:skip This commit does not require backporting and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.16.0 labels Sep 18, 2024
@sabarasaba sabarasaba merged commit 7549c11 into elastic:main Sep 18, 2024
25 checks passed
@alisonelizabeth alisonelizabeth mentioned this pull request Sep 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElenaStoeva ElenaStoeva ElenaStoeva approved these changes

Assignees

@sabarasaba sabarasaba

Labels
backport:skip This commit does not require backporting Feature:Console Dev Tools Console Feature release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v9.0.0
Projects
None yet
Milestone
No milestone
5 participants
@sabarasaba @kibanamachine @kibana-ci @elasticmachine @ElenaStoeva