Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Lens] Corrects incorrect copy for line chart & fix flaky test (#192734) #193347

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…ic#192734)

## Summary
Corrects incorrect copy for line chart.

Rewrites some of the tests to rtl.
Unskips flaky or failing tests.
Fixes elastic#192476
Removes some errors from the console that appear during unit test
running.

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit e1db296)
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #10 / Create renders correctly with optional fields
  • [job] [logs] Jest Tests #10 / DeleteConfirmationModal calls onConfirm

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB -802.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mbondyra

@kibanamachine kibanamachine merged commit 3a62655 into elastic:8.x Sep 18, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants