Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] FinalEdit: Add name and kql_query fields + shared components #193828

Merged
merged 50 commits into from
Oct 14, 2024
Merged

[Security Solution] FinalEdit: Add name and kql_query fields + shared components #193828

merged 50 commits into from
Oct 14, 2024

Commits on Sep 27, 2024

  1. integrate state and components

    @maximpn @nikitaindik
    maximpn authored and nikitaindik committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    12bdeae View commit details
    Browse the repository at this point in the history

  2. move tab related components to components folder

    @maximpn @nikitaindik
    maximpn authored and nikitaindik committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    8ecf7ae View commit details
    Browse the repository at this point in the history

  3. adopt SplitAccordion

    @maximpn @nikitaindik
    maximpn authored and nikitaindik committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    2294396 View commit details
    Browse the repository at this point in the history

  4. reduce type casting to bare minimum

    @maximpn @nikitaindik
    maximpn authored and nikitaindik committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    204933f View commit details
    Browse the repository at this point in the history

  5. improve component's naming

    @maximpn @nikitaindik
    maximpn authored and nikitaindik committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    64ddaa7 View commit details
    Browse the repository at this point in the history

  6. improve function naming

    @maximpn @nikitaindik
    maximpn authored and nikitaindik committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    6b51235 View commit details
    Browse the repository at this point in the history

  7. remove unused code

    @maximpn @nikitaindik
    maximpn authored and nikitaindik committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    1a0fa9a View commit details
    Browse the repository at this point in the history

  8. integrate state and components

    @maximpn @nikitaindik
    maximpn authored and nikitaindik committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    c3bcaae View commit details
    Browse the repository at this point in the history

  9. Set up data passage to make field forms work

    @nikitaindik
    nikitaindik committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    f991566 View commit details
    Browse the repository at this point in the history

  10. Add FieldFormWrapper to encapsulate form setup

    @nikitaindik
    nikitaindik committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    ee92867 View commit details
    Browse the repository at this point in the history

  11. Extract common fields into a separate component

    @nikitaindik
    nikitaindik committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    2684b22 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'maximpn_integrate-prebuilt-rule-upgrade-state-and-compo… 

    …nents' into 3wd-field-edit-base
    @nikitaindik
    nikitaindik committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    a09e90c View commit details
    Browse the repository at this point in the history

  13. Merge remote-tracking branch 'upstream/main' into 3wd-field-edit-base

    @nikitaindik
    nikitaindik committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    ac4048e View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Merge remote-tracking branch 'upstream/main' into 3wd-field-edit-base

    @nikitaindik
    nikitaindik committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    798592a View commit details
    Browse the repository at this point in the history

  2. Account for renames in Maxim's PR

    @nikitaindik
    nikitaindik committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d753724 View commit details
    Browse the repository at this point in the history

  3. Account for more renames

    @nikitaindik
    nikitaindik committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    076c7a0 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Pass diffableRule and field value setter via context

    @nikitaindik
    nikitaindik committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    718c088 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Merge remote-tracking branch 'upstream/main' into 3wd-field-edit-base

    @nikitaindik
    nikitaindik committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    91e47fd View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Make kql_query work

    @nikitaindik
    nikitaindik committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    0407cbe View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into 3wd-field-edit-base

    @nikitaindik
    nikitaindik committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a1b0000 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2024

  1. Merge branch 'main' into 3wd-field-edit-base

    @maximpn
    maximpn authored Oct 6, 2024
    Configuration menu
    Copy the full SHA
    19e4101 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Merge remote-tracking branch 'upstream/main' into 3wd-field-edit-base

    @nikitaindik
    nikitaindik committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    54183c7 View commit details
    Browse the repository at this point in the history

  2. Add a spacer to the callout and add plurals to callout copy

    @nikitaindik
    nikitaindik committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    9509411 View commit details
    Browse the repository at this point in the history

  3. Extract hidden fields into a separate variable

    @nikitaindik
    nikitaindik committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    51637f4 View commit details
    Browse the repository at this point in the history

  4. Simplify setting resolved value

    @nikitaindik
    nikitaindik committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    83c476d View commit details
    Browse the repository at this point in the history

  5. Refactor deserializtion code

    @nikitaindik
    nikitaindik committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    e45796e View commit details
    Browse the repository at this point in the history

  6. Refactor onSubmit validation handling

    @nikitaindik
    nikitaindik committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    022ef98 View commit details
    Browse the repository at this point in the history

  7. Refactor getDefaultValue

    @nikitaindik
    nikitaindik committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    f92d273 View commit details
    Browse the repository at this point in the history

  8. Use i18n for button labels

    @nikitaindik
    nikitaindik committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    caa3064 View commit details
    Browse the repository at this point in the history

  9. Wrap form handlers in useCallback

    @nikitaindik
    nikitaindik committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    e491ad7 View commit details
    Browse the repository at this point in the history

  10. Move calculation of useRuleIndexPattern parameters into a separate … 

    …function
    @nikitaindik
    nikitaindik committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    bdd4937 View commit details
    Browse the repository at this point in the history

  11. Remove braces

    @nikitaindik
    nikitaindik committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    f9a6ba1 View commit details
    Browse the repository at this point in the history

  12. Extract FinalSide mode values into an enum

    @nikitaindik
    nikitaindik committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    265c8c8 View commit details
    Browse the repository at this point in the history

  13. Refactor FinalEditContextProvider to accept children as `PropsWithC… 

    …hildren`
    @nikitaindik
    nikitaindik committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    db49679 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Fix Storybook types

    @nikitaindik
    nikitaindik committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    3d185d1 View commit details
    Browse the repository at this point in the history

  2. Make TS happy

    @nikitaindik
    nikitaindik committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    233fb28 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into 3wd-field-edit-base

    @nikitaindik
    nikitaindik committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    2fdfabd View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2024

  1. Merge branch 'main' into 3wd-field-edit-base

    @nikitaindik
    nikitaindik authored Oct 12, 2024
    Configuration menu
    Copy the full SHA
    e8a7b5e View commit details
    Browse the repository at this point in the history

  2. Update x-pack/plugins/security_solution/public/detection_engine/rule_… 

    …management/model/prebuilt_rule_upgrade/constants.ts


🤦 Typo

Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co>
    @nikitaindik @maximpn
    nikitaindik and maximpn authored Oct 12, 2024
    Configuration menu
    Copy the full SHA
    02710b3 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Update code comment text

    @nikitaindik
    nikitaindik committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    9a4741b View commit details
    Browse the repository at this point in the history

  2. Fix a typo in isNonUpgradeableFieldName

    @nikitaindik
    nikitaindik committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    05563a5 View commit details
    Browse the repository at this point in the history

  3. Simplify isTimelineSearchOpen/toggleIsTimelineSearchOpen implemen… 

    …tation
    @nikitaindik
    nikitaindik committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    61326b8 View commit details
    Browse the repository at this point in the history

  4. Move getting saved query ID into a function

    @nikitaindik
    nikitaindik committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    d0c6f55 View commit details
    Browse the repository at this point in the history

  5. Refactor getUseRuleIndexPatternParameters

    @nikitaindik
    nikitaindik committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    5b3ebf9 View commit details
    Browse the repository at this point in the history

  6. Move field-related types and constants into fields.ts

    @nikitaindik
    nikitaindik committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    2079647 View commit details
    Browse the repository at this point in the history

  7. Make a separate type for field components

    @nikitaindik
    nikitaindik committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    9749c8c View commit details
    Browse the repository at this point in the history

  8. Add explicit field component return types

    @nikitaindik
    nikitaindik committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    048dfac View commit details
    Browse the repository at this point in the history

  9. Refactor passing data via local context

    @nikitaindik
    nikitaindik committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    0a98280 View commit details
    Browse the repository at this point in the history

  10. Remove duplicated RuleUpgradeState type

    @nikitaindik
    nikitaindik committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    655d126 View commit details
    Browse the repository at this point in the history

  11. Merge remote-tracking branch 'upstream/main' into 3wd-field-edit-base

    @nikitaindik
    nikitaindik committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    7b4265c View commit details
    Browse the repository at this point in the history