Apply backpressure to the task poller whenever Elasticsearch requests respond with 503 errors #196900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ersin-erdal
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11489635605 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 23, 2024
… respond with 503 errors (elastic#196900) Resolves: elastic#195134 This PR adds 503 error check to the error filter of `createManagedConfiguration` function, besides the 501 error . So it applies backpressure to the task poller for 503 errors as well. (cherry picked from commit 292a7d3)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 24, 2024
…quests respond with 503 errors (#196900) (#197544) # Backport This will backport the following commits from `main` to `8.x`: - [Apply backpressure to the task poller whenever Elasticsearch requests respond with 503 errors (#196900)](#196900) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ersin Erdal","email":"92688503+ersin-erdal@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-23T23:16:45Z","message":"Apply backpressure to the task poller whenever Elasticsearch requests respond with 503 errors (#196900)\n\nResolves: #195134\r\n\r\nThis PR adds 503 error check to the error filter of\r\n`createManagedConfiguration` function, besides the 501 error .\r\nSo it applies backpressure to the task poller for 503 errors as well.","sha":"292a7d384e51ca9e76d09f817f583bd0b201d9e0","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor"],"title":"Apply backpressure to the task poller whenever Elasticsearch requests respond with 503 errors","number":196900,"url":"https://github.com/elastic/kibana/pull/196900","mergeCommit":{"message":"Apply backpressure to the task poller whenever Elasticsearch requests respond with 503 errors (#196900)\n\nResolves: #195134\r\n\r\nThis PR adds 503 error check to the error filter of\r\n`createManagedConfiguration` function, besides the 501 error .\r\nSo it applies backpressure to the task poller for 503 errors as well.","sha":"292a7d384e51ca9e76d09f817f583bd0b201d9e0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196900","number":196900,"mergeCommit":{"message":"Apply backpressure to the task poller whenever Elasticsearch requests respond with 503 errors (#196900)\n\nResolves: #195134\r\n\r\nThis PR adds 503 error check to the error filter of\r\n`createManagedConfiguration` function, besides the 501 error .\r\nSo it applies backpressure to the task poller for 503 errors as well.","sha":"292a7d384e51ca9e76d09f817f583bd0b201d9e0"}}]}] BACKPORT--> Co-authored-by: Ersin Erdal <92688503+ersin-erdal@users.noreply.github.com>
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
ersin-erdal
added a commit
to ersin-erdal/kibana
that referenced
this pull request
Oct 24, 2024
… respond with 503 errors (elastic#196900) Resolves: elastic#195134 This PR adds 503 error check to the error filter of `createManagedConfiguration` function, besides the 501 error . So it applies backpressure to the task poller for 503 errors as well. (cherry picked from commit 292a7d3)
ersin-erdal
added a commit
that referenced
this pull request
Oct 24, 2024
…equests respond with 503 errors (#196900) (#197705) # Backport This will backport the following commits from `main` to `8.16`: - [Apply backpressure to the task poller whenever Elasticsearch requests respond with 503 errors (#196900)](#196900) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ersin Erdal","email":"92688503+ersin-erdal@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-23T23:16:45Z","message":"Apply backpressure to the task poller whenever Elasticsearch requests respond with 503 errors (#196900)\n\nResolves: #195134\r\n\r\nThis PR adds 503 error check to the error filter of\r\n`createManagedConfiguration` function, besides the 501 error .\r\nSo it applies backpressure to the task poller for 503 errors as well.","sha":"292a7d384e51ca9e76d09f817f583bd0b201d9e0","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.16.0","v8.17.0"],"number":196900,"url":"https://github.com/elastic/kibana/pull/196900","mergeCommit":{"message":"Apply backpressure to the task poller whenever Elasticsearch requests respond with 503 errors (#196900)\n\nResolves: #195134\r\n\r\nThis PR adds 503 error check to the error filter of\r\n`createManagedConfiguration` function, besides the 501 error .\r\nSo it applies backpressure to the task poller for 503 errors as well.","sha":"292a7d384e51ca9e76d09f817f583bd0b201d9e0"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196900","number":196900,"mergeCommit":{"message":"Apply backpressure to the task poller whenever Elasticsearch requests respond with 503 errors (#196900)\n\nResolves: #195134\r\n\r\nThis PR adds 503 error check to the error filter of\r\n`createManagedConfiguration` function, besides the 501 error .\r\nSo it applies backpressure to the task poller for 503 errors as well.","sha":"292a7d384e51ca9e76d09f817f583bd0b201d9e0"}},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/197544","number":197544,"state":"MERGED","mergeCommit":{"sha":"e2001cadd96d112108ee60780bf3708d5fa48a14","message":"[8.x] Apply backpressure to the task poller whenever Elasticsearch requests respond with 503 errors (#196900) (#197544)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [Apply backpressure to the task poller whenever Elasticsearch requests\nrespond with 503 errors\n(#196900)](https://github.com/elastic/kibana/pull/196900)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Ersin\nErdal\",\"email\":\"92688503+ersin-erdal@users.noreply.github.com\"},\"sourceCommit\":{\"committedDate\":\"2024-10-23T23:16:45Z\",\"message\":\"Apply\nbackpressure to the task poller whenever Elasticsearch requests respond\nwith 503 errors (#196900)\\n\\nResolves: #195134\\r\\n\\r\\nThis PR adds 503\nerror check to the error filter of\\r\\n`createManagedConfiguration`\nfunction, besides the 501 error .\\r\\nSo it applies backpressure to the\ntask poller for 503 errors as\nwell.\",\"sha\":\"292a7d384e51ca9e76d09f817f583bd0b201d9e0\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"Team:ResponseOps\",\"v9.0.0\",\"backport:prev-minor\"],\"title\":\"Apply\nbackpressure to the task poller whenever Elasticsearch requests respond\nwith 503\nerrors\",\"number\":196900,\"url\":\"https://github.com/elastic/kibana/pull/196900\",\"mergeCommit\":{\"message\":\"Apply\nbackpressure to the task poller whenever Elasticsearch requests respond\nwith 503 errors (#196900)\\n\\nResolves: #195134\\r\\n\\r\\nThis PR adds 503\nerror check to the error filter of\\r\\n`createManagedConfiguration`\nfunction, besides the 501 error .\\r\\nSo it applies backpressure to the\ntask poller for 503 errors as\nwell.\",\"sha\":\"292a7d384e51ca9e76d09f817f583bd0b201d9e0\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/196900\",\"number\":196900,\"mergeCommit\":{\"message\":\"Apply\nbackpressure to the task poller whenever Elasticsearch requests respond\nwith 503 errors (#196900)\\n\\nResolves: #195134\\r\\n\\r\\nThis PR adds 503\nerror check to the error filter of\\r\\n`createManagedConfiguration`\nfunction, besides the 501 error .\\r\\nSo it applies backpressure to the\ntask poller for 503 errors as\nwell.\",\"sha\":\"292a7d384e51ca9e76d09f817f583bd0b201d9e0\"}}]}] BACKPORT-->\n\nCo-authored-by: Ersin Erdal <92688503+ersin-erdal@users.noreply.github.com>"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #195134
This PR adds 503 error check to the error filter of
createManagedConfigurationfunction, besides the 501 error .So it applies backpressure to the task poller for 503 errors as well.