[Security Solution][Notes] - fix an issue that breaks the notes management page, an enum value was missing from the api #196912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ement page, an enum value was missing from the api
PhilippeOberti
added
backport
release_note:skip
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
kqualters-elastic
approved these changes
Oct 18, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
|
|
Starting backport for target branches: 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11408746449 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 18, 2024
…ement page, an enum value was missing from the api (elastic#196912) ## Summary _**Notes: please ignore the spaces introduced in the first commit, Webstorm is trying to be smart... CI should take care of fixing that in a second commit shortly**_ This PR fixes a small issue that prevents the notes management page to load. The issue comes from the fact that one of the enum values passed to filter notes was missing from the open api spec. This issue was introduced in this recent [PR](elastic#195501). Current notes management borken page  This is the error in the network tab  This PR fixes the issue  --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit bf7c5aa)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 18, 2024
…ement page, an enum value was missing from the api (elastic#196912) ## Summary _**Notes: please ignore the spaces introduced in the first commit, Webstorm is trying to be smart... CI should take care of fixing that in a second commit shortly**_ This PR fixes a small issue that prevents the notes management page to load. The issue comes from the fact that one of the enum values passed to filter notes was missing from the open api spec. This issue was introduced in this recent [PR](elastic#195501). Current notes management borken page  This is the error in the network tab  This PR fixes the issue  --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit bf7c5aa)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 18, 2024
… management page, an enum value was missing from the api (#196912) (#196936) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Notes] - fix an issue that breaks the notes management page, an enum value was missing from the api (#196912)](#196912) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2024-10-18T18:09:02Z","message":"[Security Solution][Notes] - fix an issue that breaks the notes management page, an enum value was missing from the api (#196912)\n\n## Summary\r\n\r\n_**Notes: please ignore the spaces introduced in the first commit,\r\nWebstorm is trying to be smart... CI should take care of fixing that in\r\na second commit shortly**_\r\n\r\nThis PR fixes a small issue that prevents the notes management page to\r\nload. The issue comes from the fact that one of the enum values passed\r\nto filter notes was missing from the open api spec. This issue was\r\nintroduced in this recent\r\n[PR](https://github.com/elastic/kibana/pull/195501).\r\n\r\nCurrent notes management borken page\r\n\r\n\r\nThis is the error in the network tab\r\n\r\n\r\nThis PR fixes the issue\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"bf7c5aaf29e475979023a607a4f318b5f005d0d8","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","v8.16.0"],"title":"[Security Solution][Notes] - fix an issue that breaks the notes management page, an enum value was missing from the api","number":196912,"url":"https://github.com/elastic/kibana/pull/196912","mergeCommit":{"message":"[Security Solution][Notes] - fix an issue that breaks the notes management page, an enum value was missing from the api (#196912)\n\n## Summary\r\n\r\n_**Notes: please ignore the spaces introduced in the first commit,\r\nWebstorm is trying to be smart... CI should take care of fixing that in\r\na second commit shortly**_\r\n\r\nThis PR fixes a small issue that prevents the notes management page to\r\nload. The issue comes from the fact that one of the enum values passed\r\nto filter notes was missing from the open api spec. This issue was\r\nintroduced in this recent\r\n[PR](https://github.com/elastic/kibana/pull/195501).\r\n\r\nCurrent notes management borken page\r\n\r\n\r\nThis is the error in the network tab\r\n\r\n\r\nThis PR fixes the issue\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"bf7c5aaf29e475979023a607a4f318b5f005d0d8"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196912","number":196912,"mergeCommit":{"message":"[Security Solution][Notes] - fix an issue that breaks the notes management page, an enum value was missing from the api (#196912)\n\n## Summary\r\n\r\n_**Notes: please ignore the spaces introduced in the first commit,\r\nWebstorm is trying to be smart... CI should take care of fixing that in\r\na second commit shortly**_\r\n\r\nThis PR fixes a small issue that prevents the notes management page to\r\nload. The issue comes from the fact that one of the enum values passed\r\nto filter notes was missing from the open api spec. This issue was\r\nintroduced in this recent\r\n[PR](https://github.com/elastic/kibana/pull/195501).\r\n\r\nCurrent notes management borken page\r\n\r\n\r\nThis is the error in the network tab\r\n\r\n\r\nThis PR fixes the issue\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"bf7c5aaf29e475979023a607a4f318b5f005d0d8"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Oct 18, 2024
…s management page, an enum value was missing from the api (#196912) (#196935) # Backport This will backport the following commits from `main` to `8.16`: - [[Security Solution][Notes] - fix an issue that breaks the notes management page, an enum value was missing from the api (#196912)](#196912) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2024-10-18T18:09:02Z","message":"[Security Solution][Notes] - fix an issue that breaks the notes management page, an enum value was missing from the api (#196912)\n\n## Summary\r\n\r\n_**Notes: please ignore the spaces introduced in the first commit,\r\nWebstorm is trying to be smart... CI should take care of fixing that in\r\na second commit shortly**_\r\n\r\nThis PR fixes a small issue that prevents the notes management page to\r\nload. The issue comes from the fact that one of the enum values passed\r\nto filter notes was missing from the open api spec. This issue was\r\nintroduced in this recent\r\n[PR](https://github.com/elastic/kibana/pull/195501).\r\n\r\nCurrent notes management borken page\r\n\r\n\r\nThis is the error in the network tab\r\n\r\n\r\nThis PR fixes the issue\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"bf7c5aaf29e475979023a607a4f318b5f005d0d8","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","v8.16.0"],"title":"[Security Solution][Notes] - fix an issue that breaks the notes management page, an enum value was missing from the api","number":196912,"url":"https://github.com/elastic/kibana/pull/196912","mergeCommit":{"message":"[Security Solution][Notes] - fix an issue that breaks the notes management page, an enum value was missing from the api (#196912)\n\n## Summary\r\n\r\n_**Notes: please ignore the spaces introduced in the first commit,\r\nWebstorm is trying to be smart... CI should take care of fixing that in\r\na second commit shortly**_\r\n\r\nThis PR fixes a small issue that prevents the notes management page to\r\nload. The issue comes from the fact that one of the enum values passed\r\nto filter notes was missing from the open api spec. This issue was\r\nintroduced in this recent\r\n[PR](https://github.com/elastic/kibana/pull/195501).\r\n\r\nCurrent notes management borken page\r\n\r\n\r\nThis is the error in the network tab\r\n\r\n\r\nThis PR fixes the issue\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"bf7c5aaf29e475979023a607a4f318b5f005d0d8"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196912","number":196912,"mergeCommit":{"message":"[Security Solution][Notes] - fix an issue that breaks the notes management page, an enum value was missing from the api (#196912)\n\n## Summary\r\n\r\n_**Notes: please ignore the spaces introduced in the first commit,\r\nWebstorm is trying to be smart... CI should take care of fixing that in\r\na second commit shortly**_\r\n\r\nThis PR fixes a small issue that prevents the notes management page to\r\nload. The issue comes from the fact that one of the enum values passed\r\nto filter notes was missing from the open api spec. This issue was\r\nintroduced in this recent\r\n[PR](https://github.com/elastic/kibana/pull/195501).\r\n\r\nCurrent notes management borken page\r\n\r\n\r\nThis is the error in the network tab\r\n\r\n\r\nThis PR fixes the issue\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"bf7c5aaf29e475979023a607a4f318b5f005d0d8"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Notes: please ignore the spaces introduced in the first commit, Webstorm is trying to be smart... CI should take care of fixing that in a second commit shortly
This PR fixes a small issue that prevents the notes management page to load. The issue comes from the fact that one of the enum values passed to filter notes was missing from the open api spec. This issue was introduced in this recent PR.
Current notes management borken page
This is the error in the network tab
This PR fixes the issue
