Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecuritySolution] Add text intro to Asset Criticality on upload page #197436

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

machadoum
Copy link
Member

@machadoum machadoum commented Oct 23, 2024

Summary

Add text intro to Asset Criticality on the upload page.
Described here: #196633 (comment)

Screenshot 2024-10-23 at 15 21 06

@machadoum machadoum self-assigned this Oct 23, 2024
@machadoum machadoum requested a review from joedatlive October 23, 2024 13:28
@machadoum machadoum added v9.0.0 Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Theme: entity_analytics Feature:Entity Analytics Security Solution Entity Analytics features Team:Entity Analytics Security Entity Analytics Team v8.16.0 backport:version Backport to applied version labels v8.17.0 release_note:skip Skip the PR/issue when compiling release notes bug Fixes for quality problems that affect the customer experience fixed labels Oct 23, 2024
@machadoum machadoum marked this pull request as ready for review October 23, 2024 13:29
@machadoum machadoum requested a review from a team as a code owner October 23, 2024 13:29
@machadoum machadoum requested a review from hop-dev October 23, 2024 13:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-entity-analytics (Team:Entity Analytics)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.7MB 20.7MB +308.0B

cc @machadoum

@machadoum machadoum merged commit 0a825ef into elastic:main Oct 24, 2024
68 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11498260675

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 24, 2024
…elastic#197436)

## Summary

Add text intro to Asset Criticality on the upload page.
Described here:
elastic#196633 (comment)

![Screenshot 2024-10-23 at 15 21
06](https://github.com/user-attachments/assets/fa984960-6cec-4efa-b009-0044520bb6e6)

(cherry picked from commit 0a825ef)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 24, 2024
…elastic#197436)

## Summary

Add text intro to Asset Criticality on the upload page.
Described here:
elastic#196633 (comment)

![Screenshot 2024-10-23 at 15 21
06](https://github.com/user-attachments/assets/fa984960-6cec-4efa-b009-0044520bb6e6)

(cherry picked from commit 0a825ef)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.16
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 24, 2024
…ad page (#197436) (#197616)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[SecuritySolution] Add text intro to Asset Criticality on upload page
(#197436)](#197436)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Pablo
Machado","email":"pablo.nevesmachado@elastic.co"},"sourceCommit":{"committedDate":"2024-10-24T11:22:10Z","message":"[SecuritySolution]
Add text intro to Asset Criticality on upload page (#197436)\n\n##
Summary\r\n\r\nAdd text intro to Asset Criticality on the upload
page.\r\nDescribed
here:\r\nhttps://github.com//issues/196633#issuecomment-2420541914\r\n\r\n![Screenshot
2024-10-23 at 15
21\r\n06](https://github.com/user-attachments/assets/fa984960-6cec-4efa-b009-0044520bb6e6)","sha":"0a825ef7841673beea4a23c6ab38f18676a6f7b8","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","fixed","Team:
SecuritySolution","Theme: entity_analytics","Feature:Entity
Analytics","Team:Entity
Analytics","v8.16.0","backport:version","v8.17.0"],"title":"[SecuritySolution]
Add text intro to Asset Criticality on upload
page","number":197436,"url":"https://github.com/elastic/kibana/pull/197436","mergeCommit":{"message":"[SecuritySolution]
Add text intro to Asset Criticality on upload page (#197436)\n\n##
Summary\r\n\r\nAdd text intro to Asset Criticality on the upload
page.\r\nDescribed
here:\r\nhttps://github.com//issues/196633#issuecomment-2420541914\r\n\r\n![Screenshot
2024-10-23 at 15
21\r\n06](https://github.com/user-attachments/assets/fa984960-6cec-4efa-b009-0044520bb6e6)","sha":"0a825ef7841673beea4a23c6ab38f18676a6f7b8"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197436","number":197436,"mergeCommit":{"message":"[SecuritySolution]
Add text intro to Asset Criticality on upload page (#197436)\n\n##
Summary\r\n\r\nAdd text intro to Asset Criticality on the upload
page.\r\nDescribed
here:\r\nhttps://github.com//issues/196633#issuecomment-2420541914\r\n\r\n![Screenshot
2024-10-23 at 15
21\r\n06](https://github.com/user-attachments/assets/fa984960-6cec-4efa-b009-0044520bb6e6)","sha":"0a825ef7841673beea4a23c6ab38f18676a6f7b8"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co>
kibanamachine added a commit that referenced this pull request Oct 24, 2024
…d page (#197436) (#197617)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[SecuritySolution] Add text intro to Asset Criticality on upload page
(#197436)](#197436)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Pablo
Machado","email":"pablo.nevesmachado@elastic.co"},"sourceCommit":{"committedDate":"2024-10-24T11:22:10Z","message":"[SecuritySolution]
Add text intro to Asset Criticality on upload page (#197436)\n\n##
Summary\r\n\r\nAdd text intro to Asset Criticality on the upload
page.\r\nDescribed
here:\r\nhttps://github.com//issues/196633#issuecomment-2420541914\r\n\r\n![Screenshot
2024-10-23 at 15
21\r\n06](https://github.com/user-attachments/assets/fa984960-6cec-4efa-b009-0044520bb6e6)","sha":"0a825ef7841673beea4a23c6ab38f18676a6f7b8","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","fixed","Team:
SecuritySolution","Theme: entity_analytics","Feature:Entity
Analytics","Team:Entity
Analytics","v8.16.0","backport:version","v8.17.0"],"title":"[SecuritySolution]
Add text intro to Asset Criticality on upload
page","number":197436,"url":"https://github.com/elastic/kibana/pull/197436","mergeCommit":{"message":"[SecuritySolution]
Add text intro to Asset Criticality on upload page (#197436)\n\n##
Summary\r\n\r\nAdd text intro to Asset Criticality on the upload
page.\r\nDescribed
here:\r\nhttps://github.com//issues/196633#issuecomment-2420541914\r\n\r\n![Screenshot
2024-10-23 at 15
21\r\n06](https://github.com/user-attachments/assets/fa984960-6cec-4efa-b009-0044520bb6e6)","sha":"0a825ef7841673beea4a23c6ab38f18676a6f7b8"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197436","number":197436,"mergeCommit":{"message":"[SecuritySolution]
Add text intro to Asset Criticality on upload page (#197436)\n\n##
Summary\r\n\r\nAdd text intro to Asset Criticality on the upload
page.\r\nDescribed
here:\r\nhttps://github.com//issues/196633#issuecomment-2420541914\r\n\r\n![Screenshot
2024-10-23 at 15
21\r\n06](https://github.com/user-attachments/assets/fa984960-6cec-4efa-b009-0044520bb6e6)","sha":"0a825ef7841673beea4a23c6ab38f18676a6f7b8"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels bug Fixes for quality problems that affect the customer experience Feature:Entity Analytics Security Solution Entity Analytics features fixed release_note:skip Skip the PR/issue when compiling release notes Team:Entity Analytics Security Entity Analytics Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Theme: entity_analytics v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants