Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aria-labelledby to index details flyout to tell screen reader what to announce when the flyout is opened #19776

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Add aria-labelledby to index details flyout to tell screen reader what to announce when the flyout is opened #19776

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions ...ugins/index_management/public/sections/index_list/components/detail_panel/detail_panel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,21 +69,28 @@ export class DetailPanel extends Component {
component = <Summary />;
}
return (
<EuiFlyout data-test-subj="indexDetailFlyout" onClose={closeDetailPanel}>
<EuiFlyout
data-test-subj="indexDetailFlyout"
onClose={closeDetailPanel}
aria-labelledby="indexDetailsFlyoutTitle"
>
<EuiFlyoutHeader>
<EuiTitle size="l">
<EuiTitle size="l" id="indexDetailsFlyoutTitle">
<h2>{indexName}</h2>
</EuiTitle>
<EuiTabs>{this.renderTabs()}</EuiTabs>
</EuiFlyoutHeader>

<EuiFlyoutBody>{component}</EuiFlyoutBody>

<EuiFlyoutFooter>
<EuiFlexGroup justifyContent="spaceBetween">
<EuiFlexItem grow={false}>
<EuiButtonEmpty iconType="cross" onClick={closeDetailPanel}>
Close
</EuiButtonEmpty>
</EuiFlexItem>

<EuiFlexItem grow={false}>
<Route
key="menu"
Expand Down