Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add described-by attribute to duration-selection directive to make children inputs screen reader accessible #19779

Merged

Conversation

cjcenizal
Copy link
Contributor

Fixes #19474

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjcenizal cjcenizal merged commit 0a2ce7d into elastic:master Jun 14, 2018
@cjcenizal cjcenizal deleted the watcher-duration-select-labeling branch June 14, 2018 00:05
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Jun 14, 2018
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Jun 14, 2018
cjcenizal added a commit that referenced this pull request Jun 14, 2018
cjcenizal added a commit that referenced this pull request Jun 14, 2018
maryia-lapata pushed a commit to maryia-lapata/kibana that referenced this pull request Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants