Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] - skipping failing sourcerer Cypress test failing on main #199030

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

@PhilippeOberti PhilippeOberti added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v9.0.0 Team:Threat Hunting:Investigations Security Solution Investigations Team labels Nov 5, 2024
@PhilippeOberti PhilippeOberti requested a review from a team as a code owner November 5, 2024 17:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11689823407

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 199030

Questions ?

Please refer to the Backport tool documentation

@jbudz
Copy link
Member

jbudz commented Nov 5, 2024

Already partially skipped on 8.x: https://github.com/elastic/kibana/blob/8.x/x-pack/test/security_solution_cypress/cypress/e2e/investigations/sourcerer/sourcerer_timeline.cy.ts#L65

I pushed ab74598

jbudz pushed a commit that referenced this pull request Nov 5, 2024
@PhilippeOberti PhilippeOberti deleted the skipping-failing-tests branch November 5, 2024 18:33
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #6 / AllCasesListGeneric Actions Row actions update the severity of a case: low

Metrics [docs]

✅ unchanged

xcrzx added a commit that referenced this pull request Nov 7, 2024
…tion (#199122)

**Related to: #195888

## Summary

Add default index pattern creation to the new stream-based package
installation method to match the behavior of standard package
installation.

Switching to stream-based package installation resulted in the default
index patterns not being created, even after installing the rules
package. While this likely doesn’t affect production, as multiple
integrations are usually installed in Kibana (creating the default index
pattern in any case), this change has impacted some tests:
#199030. So restoring the original
behaviour
mgadewoll pushed a commit to mgadewoll/kibana that referenced this pull request Nov 7, 2024
mbondyra pushed a commit to mbondyra/kibana that referenced this pull request Nov 8, 2024
…tion (elastic#199122)

**Related to: elastic#195888

## Summary

Add default index pattern creation to the new stream-based package
installation method to match the behavior of standard package
installation.

Switching to stream-based package installation resulted in the default
index patterns not being created, even after installing the rules
package. While this likely doesn’t affect production, as multiple
integrations are usually installed in Kibana (creating the default index
pattern in any case), this change has impacted some tests:
elastic#199030. So restoring the original
behaviour
xcrzx added a commit to xcrzx/kibana that referenced this pull request Nov 8, 2024
…tion (elastic#199122)

**Related to: elastic#195888

## Summary

Add default index pattern creation to the new stream-based package
installation method to match the behavior of standard package
installation.

Switching to stream-based package installation resulted in the default
index patterns not being created, even after installing the rules
package. While this likely doesn’t affect production, as multiple
integrations are usually installed in Kibana (creating the default index
pattern in any case), this change has impacted some tests:
elastic#199030. So restoring the original
behaviour

(cherry picked from commit 22d3e62)

# Conflicts:
#	x-pack/test/security_solution_cypress/cypress/e2e/investigations/sourcerer/sourcerer_timeline.cy.ts
xcrzx added a commit that referenced this pull request Nov 8, 2024
…stallation (#199122) (#199453)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Fleet] Added default index pattern creation to stream-based
installation (#199122)](#199122)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dmitrii
Shevchenko","email":"dmitrii.shevchenko@elastic.co"},"sourceCommit":{"committedDate":"2024-11-07T09:04:56Z","message":"[Fleet]
Added default index pattern creation to stream-based installation
(#199122)\n\n**Related to:
https://github.com/elastic/kibana/pull/195888**\r\n\r\n##
Summary\r\n\r\nAdd default index pattern creation to the new
stream-based package\r\ninstallation method to match the behavior of
standard package\r\ninstallation.\r\n\r\nSwitching to stream-based
package installation resulted in the default\r\nindex patterns not being
created, even after installing the rules\r\npackage. While this likely
doesn’t affect production, as multiple\r\nintegrations are usually
installed in Kibana (creating the default index\r\npattern in any case),
this change has impacted some
tests:\r\nhttps://github.com//pull/199030. So restoring
the
original\r\nbehaviour","sha":"22d3e628931706dee4c0d8eec068575d264bb13e","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:version","v8.17.0"],"number":199122,"url":"https://github.com/elastic/kibana/pull/199122","mergeCommit":{"message":"[Fleet]
Added default index pattern creation to stream-based installation
(#199122)\n\n**Related to:
https://github.com/elastic/kibana/pull/195888**\r\n\r\n##
Summary\r\n\r\nAdd default index pattern creation to the new
stream-based package\r\ninstallation method to match the behavior of
standard package\r\ninstallation.\r\n\r\nSwitching to stream-based
package installation resulted in the default\r\nindex patterns not being
created, even after installing the rules\r\npackage. While this likely
doesn’t affect production, as multiple\r\nintegrations are usually
installed in Kibana (creating the default index\r\npattern in any case),
this change has impacted some
tests:\r\nhttps://github.com//pull/199030. So restoring
the
original\r\nbehaviour","sha":"22d3e628931706dee4c0d8eec068575d264bb13e"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199122","number":199122,"mergeCommit":{"message":"[Fleet]
Added default index pattern creation to stream-based installation
(#199122)\n\n**Related to:
https://github.com/elastic/kibana/pull/195888**\r\n\r\n##
Summary\r\n\r\nAdd default index pattern creation to the new
stream-based package\r\ninstallation method to match the behavior of
standard package\r\ninstallation.\r\n\r\nSwitching to stream-based
package installation resulted in the default\r\nindex patterns not being
created, even after installing the rules\r\npackage. While this likely
doesn’t affect production, as multiple\r\nintegrations are usually
installed in Kibana (creating the default index\r\npattern in any case),
this change has impacted some
tests:\r\nhttps://github.com//pull/199030. So restoring
the
original\r\nbehaviour","sha":"22d3e628931706dee4c0d8eec068575d264bb13e"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels backported release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants