From 95a8b39f3f7244943d3e3ffbcfbe22a93ab79134 Mon Sep 17 00:00:00 2001 From: lcawl Date: Mon, 27 Jan 2025 14:30:00 -0800 Subject: [PATCH 1/3] Add migration guide to doc link service --- src/platform/packages/shared/kbn-doc-links/src/get_doc_links.ts | 1 + src/platform/packages/shared/kbn-doc-links/src/types.ts | 1 + 2 files changed, 2 insertions(+) diff --git a/src/platform/packages/shared/kbn-doc-links/src/get_doc_links.ts b/src/platform/packages/shared/kbn-doc-links/src/get_doc_links.ts index ad76bb9369cd9..7b78a737d2e1d 100644 --- a/src/platform/packages/shared/kbn-doc-links/src/get_doc_links.ts +++ b/src/platform/packages/shared/kbn-doc-links/src/get_doc_links.ts @@ -293,6 +293,7 @@ export const getDocLinks = ({ kibanaBranch, buildFlavor }: GetDocLinkOptions): D xpackSecurity: `${KIBANA_DOCS}xpack-security.html`, restApis: `${KIBANA_DOCS}api.html`, dashboardImportExport: `${KIBANA_DOCS}dashboard-api.html`, + migrationGuide: `${KIBANA_DOCS}breaking-changes.html`, }, upgradeAssistant: { overview: `${KIBANA_DOCS}upgrade-assistant.html`, diff --git a/src/platform/packages/shared/kbn-doc-links/src/types.ts b/src/platform/packages/shared/kbn-doc-links/src/types.ts index a065b7a9f6db9..a097a432b14dd 100644 --- a/src/platform/packages/shared/kbn-doc-links/src/types.ts +++ b/src/platform/packages/shared/kbn-doc-links/src/types.ts @@ -254,6 +254,7 @@ export interface DocLinks { readonly secureSavedObject: string; readonly xpackSecurity: string; readonly dashboardImportExport: string; + readonly migrationGuide: string; }; readonly upgradeAssistant: { readonly overview: string; From eee2c546e7688fcb07e60abcb53193dad2a49dd4 Mon Sep 17 00:00:00 2001 From: lcawl Date: Mon, 27 Jan 2025 17:33:57 -0800 Subject: [PATCH 2/3] Add both Elasticsearch and Kibana migration URLs --- .../packages/shared/kbn-doc-links/src/get_doc_links.ts | 3 ++- src/platform/packages/shared/kbn-doc-links/src/types.ts | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/platform/packages/shared/kbn-doc-links/src/get_doc_links.ts b/src/platform/packages/shared/kbn-doc-links/src/get_doc_links.ts index 7b78a737d2e1d..36e8c8cd4cb61 100644 --- a/src/platform/packages/shared/kbn-doc-links/src/get_doc_links.ts +++ b/src/platform/packages/shared/kbn-doc-links/src/get_doc_links.ts @@ -293,7 +293,7 @@ export const getDocLinks = ({ kibanaBranch, buildFlavor }: GetDocLinkOptions): D xpackSecurity: `${KIBANA_DOCS}xpack-security.html`, restApis: `${KIBANA_DOCS}api.html`, dashboardImportExport: `${KIBANA_DOCS}dashboard-api.html`, - migrationGuide: `${KIBANA_DOCS}breaking-changes.html`, + upgradeNotes: `${KIBANA_DOCS}breaking-changes-summary.html`, }, upgradeAssistant: { overview: `${KIBANA_DOCS}upgrade-assistant.html`, @@ -397,6 +397,7 @@ export const getDocLinks = ({ kibanaBranch, buildFlavor }: GetDocLinkOptions): D typesRemoval: `${ELASTICSEARCH_DOCS}removal-of-types.html`, setupUpgrade: `${ELASTICSEARCH_DOCS}setup-upgrade.html`, apiCompatibilityHeader: `${ELASTICSEARCH_DOCS}api-conventions.html#api-compatibility`, + migrationGuide: `${ELASTICSEARCH_DOCS}breaking-changes.html` }, siem: { guide: `${SECURITY_SOLUTION_DOCS}index.html`, diff --git a/src/platform/packages/shared/kbn-doc-links/src/types.ts b/src/platform/packages/shared/kbn-doc-links/src/types.ts index a097a432b14dd..ece18b02d602c 100644 --- a/src/platform/packages/shared/kbn-doc-links/src/types.ts +++ b/src/platform/packages/shared/kbn-doc-links/src/types.ts @@ -254,7 +254,7 @@ export interface DocLinks { readonly secureSavedObject: string; readonly xpackSecurity: string; readonly dashboardImportExport: string; - readonly migrationGuide: string; + readonly upgradeNotes: string; }; readonly upgradeAssistant: { readonly overview: string; From ae486627a3fc99a089f0196427e899b63f5d0402 Mon Sep 17 00:00:00 2001 From: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Date: Tue, 28 Jan 2025 02:19:05 +0000 Subject: [PATCH 3/3] [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' --- src/platform/packages/shared/kbn-doc-links/src/get_doc_links.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/platform/packages/shared/kbn-doc-links/src/get_doc_links.ts b/src/platform/packages/shared/kbn-doc-links/src/get_doc_links.ts index 36e8c8cd4cb61..7b39986c796c6 100644 --- a/src/platform/packages/shared/kbn-doc-links/src/get_doc_links.ts +++ b/src/platform/packages/shared/kbn-doc-links/src/get_doc_links.ts @@ -397,7 +397,7 @@ export const getDocLinks = ({ kibanaBranch, buildFlavor }: GetDocLinkOptions): D typesRemoval: `${ELASTICSEARCH_DOCS}removal-of-types.html`, setupUpgrade: `${ELASTICSEARCH_DOCS}setup-upgrade.html`, apiCompatibilityHeader: `${ELASTICSEARCH_DOCS}api-conventions.html#api-compatibility`, - migrationGuide: `${ELASTICSEARCH_DOCS}breaking-changes.html` + migrationGuide: `${ELASTICSEARCH_DOCS}breaking-changes.html`, }, siem: { guide: `${SECURITY_SOLUTION_DOCS}index.html`,