[APM] Override EUI chart default styles for gridlines #21723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/apm-ui |
💚 Build Succeeded |
This was referenced Aug 7, 2018
formgeist
added a commit
that referenced
this pull request
Aug 7, 2018
formgeist
added a commit
that referenced
this pull request
Aug 7, 2018
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21683
Since EUI chart is now available, but still in development, it inadverdently overrides the current style implementation of
react-visfor APM. We discovered that it was overriding the gridlines styles, making them barely visible in our graph objects. I've implemented a simple override in the APM plugin to revert the style.Example of current state
Example after override
