[Infra UI] Make Redux store available for the whole app #22169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weltenwort
added
WIP
💔 Build Failed |
💔 Build Failed |
weltenwort
force-pushed
the
infra-ui-refactor-redux-store
branch
from
e42e3e0 to
a9dd5e5
Compare
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
weltenwort
changed the title
weltenwort
force-pushed
the
infra-ui-refactor-redux-store
branch
from
284717e to
792f662
Compare
💔 Build Failed |
skh
approved these changes
Aug 21, 2018
| @@ -22,7 +22,7 @@ export const loadEntriesActionCreators = createGraphqlOperationActionCreators< | |||
|
|
|||
There was a problem hiding this comment.
If I'm not mistaken this results in a prefix x-pack/infra/remote/entries on actions related to log entries. Can we make it log_entries?
There was a problem hiding this comment.
Indeed, good catch! I'll fix that and the other ones below.
| @@ -27,7 +27,7 @@ export const loadMoreEntriesActionCreators = createGraphqlOperationActionCreator | |||
|
|
|||
There was a problem hiding this comment.
See previous comments, can we use log_entries?
| @@ -22,7 +22,7 @@ export const loadSummaryActionCreators = createGraphqlOperationActionCreators< | |||
|
|
|||
There was a problem hiding this comment.
See previous comments, I believe this results in a prefix x-pack/infra/remote/summary on action names, can we use log_summary?
💔 Build Failed |
The redux store and its slices now live in `public/store`. It contains two top-level entries `local` and `remote`. The `local` slice holds all the slices that represent local application state while the `remote` slice holds all the slices that contain data fetched from remote sources with their associated metadata (e.g. loading state).
weltenwort
force-pushed
the
infra-ui-refactor-redux-store
branch
from
5f7d008 to
53c7c1b
Compare
weltenwort
changed the title
💔 Build Failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21850
New redux store location
The redux store is now located in
x-pack/plugin/infra/public/state. It is not provided locally to just thelogspage, but injected at the very top of the React hierarchy:https://github.com/elastic/kibana/blob/284717e7b4f6a4d7d702919d527beaf403510521/x-pack/plugins/infra/public/apps/start_app.tsx#L32-L38
New redux store structure
The store has been partitioned into
localandremoteslices. Thelocalslice manages state that relates to the local ui state of the application while theremoteslice manages state that is fetched from the server.Each slice can export (through its
index.tsfile) a combination ofThese are hierarchically composed in the store's
actions.ts,epics.ts,reducer.tsandselectors.ts. Slices must not know about their location in the store. Action creators and reducers are limited to their slice.Selectors are lifted to the parent hierarchy level (using 'globalizeSelectors()
) in the parent slice'sselectors.ts' file, e.g. https://github.com/elastic/kibana/blob/284717e7b4f6a4d7d702919d527beaf403510521/x-pack/plugins/infra/public/store/local/selectors.ts#L13-L16Selectors that span multiple slices can be implemented as shared selectors in a common ancestor of all depended upon slices, e.g.
https://github.com/elastic/kibana/blob/284717e7b4f6a4d7d702919d527beaf403510521/x-pack/plugins/infra/public/store/selectors.ts#L47-L66
Epics are only allowed to access the state via selectors declared in the dependency argument. The combined set of selectors that satisfies the dependencies of all composed epics is injected at the store root: https://github.com/elastic/kibana/blob/284717e7b4f6a4d7d702919d527beaf403510521/x-pack/plugins/infra/public/store/store.ts#L36-L45
Container Reorganization
Along with the store slice changes, the containers have been moved from the
logging_legacyto thelogsdirectory. They have been reorganized to roughly correspond to the slices.Local/Remote state cleanup
The remaining local
visibleLogPositionstate has been moved fromlogEntriesto the local 'logPositionslice. Similarly, the visible log summary state has also been moved from the remotelogSummaryslice to the local 'logPositionslice. Other configuration state fromlogSummaryhas been moved to the locallogMinimapslice.Initialization and cleanup via containers
The
asChildFunctionRendererhelper, used in the creation of containers, has gained theonInitializeandonCleanuphandlers in its options. They allow for easy dispatching of actions as part of the containers lifecycle:https://github.com/elastic/kibana/blob/284717e7b4f6a4d7d702919d527beaf403510521/x-pack/plugins/infra/public/containers/logs/with_log_position.ts#L32-L34
This will become useful as more remote state needs to fetched and cleaned up on-demand. I expect this to gain a few more features as the app grows.