From 4b1001fc92b9e30259f227a6837bfd3e31bb0a8f Mon Sep 17 00:00:00 2001
From: Larry Gregory <larry.gregory@elastic.co>
Date: Sat, 8 Sep 2018 09:05:05 -0400
Subject: [PATCH] attempt to fix flaky tests

---
 .../functional/apps/security/rbac_phase1.js   | 26 ++++++++++++-------
 1 file changed, 16 insertions(+), 10 deletions(-)

diff --git a/x-pack/test/functional/apps/security/rbac_phase1.js b/x-pack/test/functional/apps/security/rbac_phase1.js
index ed61533df5cced..b0dee94d5899e3 100644
--- a/x-pack/test/functional/apps/security/rbac_phase1.js
+++ b/x-pack/test/functional/apps/security/rbac_phase1.js
@@ -27,8 +27,8 @@ export default function ({ getService, getPageObjects }) {
       await PageObjects.security.addRole('rbac_all', {
         "kibana": ["all"],
         "indices": [{
-          "names": [ "logstash-*" ],
-          "privileges": [ "read", "view_index_metadata" ]
+          "names": ["logstash-*"],
+          "privileges": ["read", "view_index_metadata"]
         }]
       });
 
@@ -36,16 +36,18 @@ export default function ({ getService, getPageObjects }) {
       await PageObjects.security.addRole('rbac_read', {
         "kibana": ["read"],
         "indices": [{
-          "names": [ "logstash-*" ],
-          "privileges": [ "read", "view_index_metadata" ]
+          "names": ["logstash-*"],
+          "privileges": ["read", "view_index_metadata"]
         }]
       });
       await PageObjects.security.clickElasticsearchUsers();
       log.debug('After Add user new: , userObj.userName');
-      await PageObjects.security.addUser({ username: 'kibanauser', password: 'changeme',
+      await PageObjects.security.addUser({
+        username: 'kibanauser', password: 'changeme',
         confirmPassword: 'changeme', fullname: 'kibanafirst kibanalast',
         email: 'kibanauser@myEmail.com', save: true,
-        roles: ['rbac_all'] });
+        roles: ['rbac_all']
+      });
       log.debug('After Add user: , userObj.userName');
       const users = indexBy(await PageObjects.security.getElasticsearchUsers(), 'username');
       log.debug('actualUsers = %j', users);
@@ -55,10 +57,12 @@ export default function ({ getService, getPageObjects }) {
       expect(users.kibanauser.reserved).to.be(false);
       await PageObjects.security.clickElasticsearchUsers();
       log.debug('After Add user new: , userObj.userName');
-      await PageObjects.security.addUser({ username: 'kibanareadonly', password: 'changeme',
+      await PageObjects.security.addUser({
+        username: 'kibanareadonly', password: 'changeme',
         confirmPassword: 'changeme', fullname: 'kibanareadonlyFirst kibanareadonlyLast',
         email: 'kibanareadonly@myEmail.com', save: true,
-        roles: ['rbac_read'] });
+        roles: ['rbac_read']
+      });
       log.debug('After Add user: , userObj.userName');
       const users1 = indexBy(await PageObjects.security.getElasticsearchUsers(), 'username');
       const user = users1.kibanareadonly;
@@ -79,7 +83,8 @@ export default function ({ getService, getPageObjects }) {
 
       log.debug('navigateToApp visualize');
       await PageObjects.security.login('kibanauser', 'changeme');
-      await PageObjects.common.navigateToUrl('visualize', 'new');
+      log.debug('navigateToApp visualize');
+      await PageObjects.visualize.navigateToNewVisualization();
       log.debug('clickVerticalBarChart');
       await PageObjects.visualize.clickVerticalBarChart();
       await PageObjects.visualize.clickNewSearch();
@@ -100,7 +105,8 @@ export default function ({ getService, getPageObjects }) {
 
       log.debug('navigateToApp visualize');
       await PageObjects.security.login('kibanareadonly', 'changeme');
-      await PageObjects.common.navigateToUrl('visualize', 'new');
+      log.debug('navigateToApp visualize');
+      await PageObjects.visualize.navigateToNewVisualization();
       log.debug('clickVerticalBarChart');
       await PageObjects.visualize.clickVerticalBarChart();
       await PageObjects.visualize.clickNewSearch();