-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infra UI] Provide routes for accessing pre-filtered log views #23246
[Infra UI] Provide routes for accessing pre-filtered log views #23246
Conversation
💚 Build Succeeded |
💔 Build Failed |
looks like a failure during test setup. jenkins, test this again |
💚 Build Succeeded |
💔 Build Failed |
flaky reporting test - jenkins, test this |
💚 Build Succeeded |
68a1558
to
50ae47e
Compare
@skh I rebased this on the feature branch |
💔 Build Failed |
flaky reporting test - jenkins, test this again |
💚 Build Succeeded |
Can you elaborate how the When I use the URL path |
I have tested with the following URL paths:
They behave as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
@skh What you are observing there is the result of the asymmetry between what the (TL;DR: It's being read as the "desired position" and written as the reported visible position.)
If, after this sequence of events, the I suspect the request with I hope that was somewhat helpful. Let me know if I should try harder to explain. 😉 |
Indeed it was, thank you! |
This PR introduces a set of routes that can be used as stable entry points into the infra ui with partly pre-populated stated (e.g. filters and time):
app/infra/#/link-to/container-logs/:containerId[?time=${TIMESTAMP}]
app/infra/#/link-to/host-logs/:hostname[?time=${TIMESTAMP}]
app/infra/#/link-to/pod-logs/:podId[?time=${TIMESTAMP}]
It also fixes the links from the waffle map to the logging ui to result in an appropriately filtered view.
A follow-up PR will add
uiExports
to make similar factory functions available to other Kibana plugins.Notes and Limitations
<Node>
component does not know its own true type, which is hard-coded tohost
. The url generation should already work forcontainer
andpod
types as well, though. So once the<Node>
is fixed in that regard, appropriate urls would be generated.