[ui/utils] share sync subscribe logic #23341
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💚 Build Succeeded |
src/ui/public/utils/subscribe.ts
Outdated
| $scope.$apply(() => fn(...args)); | ||
| } | ||
| } catch (error) { | ||
| fatalError(error); |
There was a problem hiding this comment.
question: not sure if it's a big deal, but shouldn't we unsubscribe from original observable if we call fatalError when next fails?
There was a problem hiding this comment.
Rxjs takes care of that because fatalError() rethrows the error and when a next() handler throws the parent is unsubscribed.
There was a problem hiding this comment.
Ah, right, I forgot that fatalError always throws.
src/ui/public/utils/subscribe.ts
Outdated
| * Subscribe to an observable at a $scope, ensuring that the digest cycle | ||
| * is run for subscriber hooks and routing errors to fatalError if not handled. | ||
| */ | ||
| export function subscribe<T>( |
There was a problem hiding this comment.
note: subscribe is a bit too generic, but I don't know a better name either, the only thing that comes to my mind is subscribeWithScope, but it's arguable. So feel free to keep it as is, just wanted to note.
There was a problem hiding this comment.
I was thinking subscribeAtScope(), but then I kept misremembering it as subscribeWithScope(), so I figured we can try it out. Shouldn't be a problem to rename it if we desire down the road.
spalger
force-pushed
the
implement/shared-sync-subscription-util
branch
from
771a7f7 to
dd10472
Compare
💚 Build Succeeded |
In `ui/public/config/config.js` we have subscription logic that delivers values from an observable synchronously and also ensuring that values are received within a digest cycle. I need to do the same in elastic#23217 but want to keep as few checks for `$rootScope.$$phase` as possible, so I broke the subscription logic into a shared util. In order to make the utility a little more helpful it will also trigger fatal errors if an observable errors without having an error handler, or if `observer.next()`, `observer.error()`, or `observer.complete()` throw, which would normally be swallowed by RxJS.
|
6.5/6.x: dd716f3 |
In
ui/public/config/config.jswe have subscription logic that delivers values from an observable synchronously and also ensuring that values are received within a digest cycle. I need to do the same in #23217 but want to keep as few checks for$rootScope.$$phaseas possible, so I broke the subscription logic into a shared util.In order to make the utility a little more helpful it will also trigger fatal errors if an observable errors without having an error handler, or if
observer.next(),observer.error(), orobserver.complete()throw, which would normally be swallowed by RxJS.