Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Make sure anomalyChartRecords gets initialized as an Array. #24021

Merged
merged 1 commit into from
Oct 16, 2018
Merged

[ML] Make sure anomalyChartRecords gets initialized as an Array. #24021

merged 1 commit into from
Oct 16, 2018

Conversation

walterra
Copy link
Contributor

Summary

Fixes an issue where resizing the Anomaly Explorer window could trigger an error if the only job being loaded so far didn't have any anomalyChartRecords.

Checklist

Checklist not applicable except:

@walterra walterra added bug Fixes for quality problems that affect the customer experience v7.0.0 :ml Feature:ml-results legacy - do not use v6.5.0 labels Oct 15, 2018
@walterra walterra self-assigned this Oct 15, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

alvarezmelissa87
alvarezmelissa87 approved these changes Oct 15, 2018
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

jgowdyelastic
jgowdyelastic approved these changes Oct 15, 2018
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

peteharverson
peteharverson approved these changes Oct 15, 2018
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@walterra walterra merged commit 81d22d2 into elastic:master Oct 16, 2018
@walterra walterra deleted the ml-initialize-anomaly-records branch October 16, 2018 07:25
walterra added a commit to walterra/kibana that referenced this pull request Oct 16, 2018
@walterra
[ML] Make sure anomalyChartRecords gets initialized as an Array. (ela…
1cccafa 
…stic#24021)

Fixes an issue where resizing the Anomaly Explorer window could trigger an error if the only job being loaded so far didn't have any anomalyChartRecords.
@walterra walterra mentioned this pull request Oct 16, 2018
Merged
walterra added a commit that referenced this pull request Oct 16, 2018
@walterra
[ML] Make sure anomalyChartRecords gets initialized as an Array. (#24021
4826063 
) (#24061)

Fixes an issue where resizing the Anomaly Explorer window could trigger an error if the only job being loaded so far didn't have any anomalyChartRecords.
@sophiec20 sophiec20 added the Feature:Anomaly Detection ML anomaly detection label Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

Assignees

@walterra walterra

Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection Feature:ml-results legacy - do not use :ml v6.5.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@walterra @elasticmachine @alvarezmelissa87 @peteharverson @jgowdyelastic @sophiec20