Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations for Tag Cloud #24065

Merged

Conversation

maryia-lapata
Copy link
Contributor

@maryia-lapata maryia-lapata commented Oct 16, 2018

Apply translation for Tag Cloud Visualization component

#23257

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@maryia-lapata maryia-lapata added v6.5.0 Feature:Tagcloud Tag cloud visualization feature labels Oct 16, 2018
@maryia-lapata maryia-lapata self-assigned this Oct 16, 2018
@maryia-lapata maryia-lapata requested a review from timroes October 16, 2018 10:08
Copy link
Contributor

@pavel06081991 pavel06081991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@maryia-lapata maryia-lapata merged commit 2872bc6 into elastic:master Oct 17, 2018
@maryia-lapata maryia-lapata deleted the feature/translations/tagcloud_ branch October 17, 2018 10:25
maryia-lapata added a commit to maryia-lapata/kibana that referenced this pull request Oct 17, 2018
maryia-lapata added a commit to maryia-lapata/kibana that referenced this pull request Oct 17, 2018
maryia-lapata added a commit that referenced this pull request Oct 17, 2018
* Translations for Tag Cloud (#24065)

* Translate pie and vaslib_basic_options (#23761) (#24124)

Translate pie and vislib_basic_options

* [I18n] Add one-time binding to angularjs i18n (#23499) (#23965)

* Add one-time binding to angularjs i18n

* Add watcher for values property

* Watch values field only if it is provided

* Fix ci

* Translations for Tag Cloud (#24065)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants