Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra UI] WithCapabilities container #24069

Merged
merged 2 commits into from
Oct 17, 2018

Conversation

skh
Copy link
Contributor

@skh skh commented Oct 16, 2018

Implements #23572

To test this, you need a node of which you know that it doesn't report data which is needed for a layout. Either:

  • look at e.g. demo-stack-apache-01 which doesn't report Kubernetes metrics. The Kubernetes section on the metrics page shouldn't be visible.
  • Edit one of the layout definitions in public/pages/metrics/layouts to only require impossible capabilities for one section, e.g. change requires: ['system.cpu'] to requires: ['XXX.cpu']. The corresponding section should no longer be visible on the metrics page that uses that layouts definition.

(This is a redone version of #24067)

@skh skh added the Feature:Metrics UI Metrics UI feature label Oct 16, 2018
@skh skh requested review from simianhacker and XavierM October 16, 2018 10:30
@skh
Copy link
Contributor Author

skh commented Oct 16, 2018

@XavierM I had to work in your timepicker changes during the rebase. If you could check that I didn't break it it would be most helpful.

@skh skh added the review label Oct 16, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... I read through the code and nothing popped out. Also loaded it in the browser and everything seems to be working as expected. Good Job!

@skh
Copy link
Contributor Author

skh commented Oct 16, 2018

jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@skh skh merged commit 5f72145 into elastic:feature-infra-ui Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants