handle EuiSearchBar query parse failures #25235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
bug
|
Pinging @elastic/kibana-management |
💚 Build Succeeded |
cjcenizal
suggested changes
Nov 9, 2018
| @@ -61,6 +61,26 @@ class TableUI extends PureComponent { | |||
| onShowRelationships: PropTypes.func.isRequired, | |||
| }; | |||
|
|
|||
| state = { | |||
| isSearchTextValid: true, | |||
There was a problem hiding this comment.
Maybe set parseErrorMessage: null here, to give people one place to see all of the state properties in use?
| let queryParseError; | ||
| if (!this.state.isSearchTextValid) { | ||
| const parseErrorMsg = intl.formatMessage({ | ||
| id: 'kbn.management.objects.objectsTable.table.searchBarUnableToParseQuery', |
There was a problem hiding this comment.
Based on the i18n naming guidelines, I think this should be kbn.management.objects.objectsTable.searchBar.unableToParseQueryErrorMessage.
| defaultMessage: 'Unable to parse query', | ||
| }); | ||
| queryParseError = ( | ||
| <div className="euiFormErrorText euiFormRow__text"> |
There was a problem hiding this comment.
If we use EuiFormErrorText here instead then we become uncoupled from the CSS classes used (an implementation detail) and gain an accessibility improvement because the error will announce itself when it appears.
<EuiFormErrorText>
{`${parseErrorMsg}. ${this.state.parseErrorMessage}`}
</EuiFormErrorText>Formatting looks unchanged:
| return ( | ||
| <Fragment> | ||
| <EuiSearchBar | ||
| box={{ ['data-test-subj']: 'savedObjectSearchBar' }} |
There was a problem hiding this comment.
I tested this and it looks like we can remove the brackets to make this slightly simpler:
box={{ 'data-test-subj': 'savedObjectSearchBar' }}
| @@ -46,8 +46,28 @@ class SearchUI extends PureComponent { | |||
| }); | |||
| } | |||
|
|
|||
| state = { | |||
| isSearchTextValid: true, | |||
There was a problem hiding this comment.
Same suggestion here as in the other component.
| defaultMessage: 'Unable to parse query', | ||
| }); | ||
| queryParseError = ( | ||
| <div className="euiFormErrorText euiFormRow__text"> |
| ); | ||
|
|
||
| // Send invalid query | ||
| component.find('input').simulate('keyup', { target: { value: '?' } }); |
There was a problem hiding this comment.
Is it possible to use a data-test-subj selector the way you did in the other test?
💚 Build Succeeded |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Nov 13, 2018
* handle EuiSearchBar query parse failures * I18n parse failure messages * review updates * more cleanup on settings search.test
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Nov 13, 2018
* handle EuiSearchBar query parse failures * I18n parse failure messages * review updates * more cleanup on settings search.test
nreese
added a commit
that referenced
this pull request
Nov 13, 2018
XavierM
added a commit
that referenced
this pull request
Nov 14, 2018
* Translations for Coordinate Map (#23952)
translate Coordinate Map
* Translations for Region Map (#23875)
add translations for region_map plugin
* [Tools] Add TemplateLiteral parsing to i18n_check tool (#24580)
* [Tools] Add TemplateLiteral parsing to i18n_check tool
* Add comments
* [ML] Remove obsolete sentence from info tooltip. (#24716)
* Translate security/users component (#23940)
Translate security/users
* [Docs] Remove beta notes for ML and Query bar (#24718)
* Translations for Table Vis plugin (#23679)
add translations for table vis plugin
* Feature/translate new nav bar (#24326)
translate new_nav_bar
* center content in fullscreen mode, hide K7 top nav (#24589)
* [APM] Fixes rare cases where KibanaLink is loaded outside of React context (#24705)
* Fixes rare cases where KibanaLink will be loaded outside of React context and requires no redux connect dependency
* Fixes tests for updated Kibana link component
* Removes obsolete snapshot
* [ui/timeBuckets/calcAutoInterval] Refactor (#24669)
* [ui/timeBuckets] test calcAutoInterval module
* [ui/timeBuckets] refactor calcAutoInterval* methods
* [calcAutoInterval] return 0ms when duration is invalid
* [calcAutoInterval] incorporate review feedback
* fix(watch): Add WatchErrors to capture invalid watches (#23887)
Instead of immediately throwing an error if a watch Action is invalid (an email for example), there is now an `option` object that we can pass to the `fromUpstreamJson()` method and receive back any error that might exist in a Watch.
The Watch has a new "watchErrors" property to display configuration error in the UI.
fixes #20305
fixes #20970
* [build] avoid extra bootstrap (#24697)
* [Console] Add ccr apis to console autocomplete (#24739)
* fixing issue with doc link paths
* dding ccr API endpoints to autocomplet
* fixing issue with documentation links
* fixing generated specs {indices} -> {index}
* refactor(Watcher): Reword translation id for missing property on objects (#24753)
* [Monitoring] Use the cluster name from metadata if it exists (#24495)
* Use the cluster name from metadata if it exists
* PR comments
* [dev/build] scan node_modules rather than lots of deleteAll() calls (#24692)
* Default scroll wheel zoom to false on vega maps. Update docs (#21169)
* Default scroll wheel zoom to false on vega maps. Update docs
* Update scroll wheel to false in tests
* Return promise in reporting jobs API (#24769)
* [Rollups] Copy improvements (#24528)
* Reporting cookies 2 (#24752)
* Revert "Reporting cookies (#24177)"
This reverts commit 9f4ec18000a74e269276ff943979799ccbd4d950.
* Take 2
* Adding comment
* Better escaping and encoding for use in eval
* Checking for an empty string also
* Fixing session test
* [master] disable flaky test - #24287
* [Rollups] Fix time field not being recognized due to ordering of aggs (#24783)
* Fix time field not being recognized due to ordering of aggs
* Clean up UI whitespace
* Update snapshot
* [@kbn/datemath] improve types (#24671)
* [kbn-datemath][parseEsInterval] improve types slightly
* [kbn-datemath][vis/leastCommonInterval] make types more precise
* [ui/leastCommonInterval] fix bug in finding same types
* add back valid test
* [yarn] bump elasticsearch-js and makelogs (#24767)
In order to support esjs apiVersion 6.5 we need to upgrade to the newly released version of elasticsearch-js. Bumping makelogs allowed us to keep only one version of the elasticsearch module installed.
* [APM] Removes action menus (#24748)
* Removes infra links and replaces context menu with single discover links for now
* Changes discover links to use empty button style
* Fixes unauthorized error in es datasources (#24624)
* Fixes check for security plugin
* Cleaned up security check logic. Fixed tests for create_handlers. Added TODOs
* Updated comment
* Added tests
* Updated variable names
* [optimizer] ignore node_modules anywhere in the x-pack directory (#24797)
I noticed the following message while watching the build output:
```
00:33:19.131 │ info [kibana] > /var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/install/kibana/bin/kibana --optimize.useBundleCache=true --env.name=development --logging.json=false --server.port=5620 --optimize.watchPort=5630 --optimize.watchPrebuild=true --status.allowAnonymous=true --elasticsearch.url=http://elastic:changeme@localhost:9220 --elasticsearch.username=elastic --elasticsearch.password=changeme --server.uuid=5b2de169-2785-441b-ae8c-186a1936b17d --xpack.xpack_main.telemetry.enabled=false --xpack.security.encryptionKey="wuGNaIhoMpk5sO4UBxgr3NyW1sFcLgIf" --optimize.enabled=true --xpack.reporting.capture.browser.type=chromium --xpack.spaces.enabled=false
00:33:38.533 │ proc [kibana] log [23:20:25.923] [info][optimize] Optimizing and caching bundles for ml, stateSessionStorageRedirect, status_page, timelion, graph, monitoring, login, logout, dashboardViewer, apm, canvas, infra and kibana. This may take a few minutes
00:34:12.650 │ proc [kibana] [BABEL] Note: The code generator has deoptimised the styling of "/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/install/kibana/node_modules/x-pack/plugins/infra/node_modules/lodash/lodash.js" as it exceeds the max of "500KB".
00:36:11.346 │ proc [kibana] log [23:22:58.721] [info][optimize] Optimization of bundles for ml, stateSessionStorageRedirect, status_page, timelion, graph, monitoring, login, logout, dashboardViewer, apm, canvas, infra and kibana complete in 152.79 seconds
```
The "code generator has deoptimised" line specifically raised a red flag as babel shouldn't be running on node_modules. We have admittedly weak regular expressions in two places to enforce this. The first is in https://github.com/elastic/kibana/blob/49071132c3c14590dea877bccb7647bbec1e1459/src/setup_node_env/babel_register/register.js#L42, which I verified matched `node_modules` directories within the `node_modules/x-pack` directory, but the other is https://github.com/elastic/kibana/blob/49071132c3c14590dea877bccb7647bbec1e1459/src/optimize/base_optimizer.js#L152-L154 which does not. It only excludes files from babel in webpack if they are within a node_modules directory that is a direct child of `node_modules/xpack`, but with InfraOps and Canvas we now have node_module directories at `plugins/*/node_modules`.
This should probably be fixed by preventing plugins from installing their own node_modules, but since that would involve upgrading/moving plugins between major versions of dependencies like lodash that's somewhat impractical from where I stand, so instead I've just updated the webpack module rule to exclude any `node_modules/xpack/**/node_modules` directory.
* [beats/heartbeat] Fix heartbeat add data instructions (#24795)
This commit does three things:
0. This fixes the instructions for interacting with the heartbeat service, which is called `heartbeat-elastic` not `heartbeat`
1. This removes some extraneous text that should be reserved for the subsequent section.
2. This makes the instructions for creating a monitor more explicit
* [ML] Fix a call stack size exception triggered by a negative tickInterval. (#24742)
In certain cases tickInterval mistakenly could end up being negative which made getTickValues() run into a call stack size exception. This PR fixes it by a) adding a check to getTickValues() that interval must not be 0 or smaller and b) changing the way the tickInterval is determined in the Anomaly Explorer Charts.
* [ML] Removing new ML job link in basic license (#24676)
* [ML] Reducing risk of upload timeouts (#24677)
* [ML] Reducing risk of upload timeouts
* function rename
* removing hardcoded number
* fixing typo
* updating comment
* [APM] Added line-height to table cell (#24768)
Improved reading of the contents, especially in the Transaction Flyout.
* [ML] Fixes missing y-axis description for rare chart. (#24823)
Fixes the missing y-axis description for rare charts in the form of y-axis event distribution split by {{fieldName}}. The intention is to briefly clarify that the type of chart is different than the other ones which have a count or metric based y-axis. This text is in addition to the text provided (but hidden without hovering) in the info icon tooltip.
* Check for toast before waiting for page to finish loading to avoid mi… (#24424)
* Check for toast before waiting for page to finish loading to avoid missing the toast by the time the page finishes
* turn test back on
* Feature/translate new nav bar breadcrumb state (#24327)
Translate new_nav_bar breadcrumbState
* add i18n angular module as dependency for nav bar directive (#24754)
* Add onBrush functionality to APM monitoring ui graphs (#24840)
* [tests] localhost.com -> localhost (#23816)
* Removes defunct function test runner Grunt task (#24673)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
* Re-initialize Rollup Management userHasLeftApp state to fix bug with clearing URLjob deep-link when detail panel is closed. (#24841)
* Add warning to the documentation_links file about link validation gotcha (#24786)
* add warning to the documentation_links file about link validation gotcha
* Use Clint's full name
* Fix Wildcard Queries Against The Default Field (#24778)
When querying against the default field (i.e. querying without specifying a field) we weren't correctly handling values with wildcards in them.
* [BeatsCM] Change Index template name (#24835)
* [BeatsCM] Change Index template name
* Update x-pack/plugins/beats_management/server/management_server.ts
* Update x-pack/plugins/beats_management/server/lib/adapters/database/__tests__/test_contract.ts
* Add a console.error to visualize errors (#24581)
* [Rollups] Fix i18n bugs (#23848)
* Internationalize job details tabs and wrap instances in EuiErrorBoundary to visually localize the error.
* Localize no default index pattern message.
* Localize es interval errors.
* Localize job action menu and confirm delete modal.
* Remove unnecessary use of injectI18n from tabs.
* Localize job status.
* Localize steps.
* Remove template literals from FormattedMessages.
* [APM] fixes #24563 by de-duping the column field id 'sample' (#24690)
* [APM] fixes #24563 by replacing de-duping the twice-used column field id
* [APM] fixed issue with service column not sorting in ManagedTable
* [APM] make render field on ITableColumn optional and allowing it to use EUI's default value
* Design clean-up for 6.5, Part Deux (#24862)
* Fixes active tab state
* Removes beta labels from ML and search bar
* Reverts visual regression with right-to-left timeline fix
* Creates space for agent marks beneath tick marks
* Fixes ordering problem with timeline transaction icons
* Updates string 0 to be an integer instead for CSS bottom value
* Allows build to be ran on Windows (#24374)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
* refactor: Convert utils/collection to Typescript (#23992)
* Vega translations (#23677)
add vega translations
* [APM] Hoist loading of waterfall and flatten it (#24651)
* [APM] Hoist loading of waterfall and flatten it
Remove unused test
Convert to typescript
* Address feedback
* Make `totalDuration` optional
* Renamed rootTransaction to traceRoot
* [APM] Only show relevant service legends
* Adds services label to the service legend
* [APM] Clock skew fix
Only skew child spans from the same service
Take parent skew into account when finding diff
# Conflicts:
# x-pack/plugins/apm/public/components/app/TransactionDetails/Transaction/WaterfallContainer/Waterfall/waterfall_helpers/__snapshots__/waterfall_helpers.test.ts.snap
# x-pack/plugins/apm/public/components/app/TransactionDetails/Transaction/WaterfallContainer/Waterfall/waterfall_helpers/waterfall_helpers.test.ts
# x-pack/plugins/apm/public/components/app/TransactionDetails/Transaction/WaterfallContainer/Waterfall/waterfall_helpers/waterfall_helpers.ts
* Use switch statement
* [ML] Set new index pattern as default one if no default index pattern exists yet. (#24337)
This replicates the behaviour of the management UI: If there's no default index pattern, the one created via file visualizer's import will be set as the default index pattern.
* Fixes APM snapshot for CSS value (#24898)
* Translations for Dev Tools (#23951)
translate dev-tools-console
* [ML] Display a ordinal y axis for low cardinality rare charts. (#24852)
Introduces a categorical/ordinal y axis for rare charts with a cardinality of <= 10. This also adds unit tests for the rare/population chart which are the bulk of the PR.
* [InfraOps] Preserve time values when navigating from the waffle map to the logs and details pages (#24666)
This adds `time` and `from`/`to` parameters to the metrics and logs links of node context menu in the waffle map.
* [APM] fixes #23808 by adding docs links for user/tags transaction apis for the java agent (#24869)
* [ML] Fixes bug with category filtering flag for rare/population charts. (#24901)
Fixes a bug where the filtering limit of categories for the rare chart was actually applied to the population chart variant.
* Reorders agents for on prem tutorial (#24872)
* [DOCS] Updates monitoring diagram (#24851)
* [ML] Fix for delimited data with whitespace in fields (#24899)
* [ML] Fix for delimted data with whitespace in fields
* rewriting to use papaparse transform function
* Fix error log formatting (#24788)
* [ML] Fixing issues when trying to import non-timestamp data (#24894)
* [ML] Fixing issues when trying to import non-timestamp data
* making results link time range optional
* small cleanup after fixing merge conflict
* console: add ignore_failure to ingest common auto complete (#24915)
* Update CI setup for windows to install yarn in global path (#24558)
* Update windows ci setup to install yarn global
* Keep formatting consistent
* Update yarn installation for linux
* Updating paths and removing cache folder
* [Rollups] Re-enable rollup support (#24888)
* Re-enable rollup support extension points
* [Rollups] Hide rollups consumption behind a feature flag in Advanced Settings. (#24698)
* adding alt tag with empty text to fix jsx-a11y errors (#24922)
* Disabling es lint for 3 of the canvas files (#24902)
disabling eslint for Canvas because we are adding in jsx-a11y rules to eslint and adding a missing copyright header
* add css grid style to prevent calendar bounce (#24913)
* Upgrading deep-extend to 0.6.0 (#22817)
* Upgrading deep-extend to 0.6.0
* Upgrading deep-extend again
* [dev/build] avoid building packages twice (#24696)
* Reverting 22816, upgrading mocha is breaking the custom reporter (#24951)
* [Rollups] Mark beta in rollup index pattern creation (#24805)
* Add beta UI tags to rollup index pattern creation
* Add test, update snapshots
* Address feedback, adjust copy, and localize rollup index pattern creation
* [APM] Fix divide by 0 bug in percentage duration (#24675)
* [APM] Fixes #40165 by consolidating logic where total duration could be 0 and handling it with a fallback value
* [APM] renamed file from .js to .ts and defined a default value for fallback
* [APM] Add type definitions for apm formatters
* [APM] add basic type definition for imported @elastic/numeral module
* [APM] rename getDurationPercent to asPercent
* [APM] Update tests with the renamed formatter function
* [APM] Pr feedback & typescript cleanup
* [APM] fix bucket & chart point type errors
* Fix typescript issue
* [APM] last minute code cleanup
* [I18n] Sanitize angular directive message before inserting it to DOM (#24830)
* [I18n] Sanitize message before inserting it to DOM
* Add tests
* [APM] Discover links with quoted values and use default 24h as time range (#24900)
* [APM] Discover links with quoted values
* Use 24h as default time range
* Fix/react intl testing helper functions (#24527)
update testing helper functions for react-intl
now we use real intl object passed by IntlProvider via context instead of mocking intl object.
so now data(strings, JSX) passed to FormattedMessage component via values are compiled and
are inserted in the output of FormattedMessage component
* Using Joi.object when configuring route validation (#24596)
* Using Joi.object when configuring route validation
* Adding forgotten API
* Fixing test
* Adding "Successfully logged out" page (#23890)
* Adding very basic place for the logged out page
* Redirecting to logged_out when we aren't using SLO
* Basing styles on the login styles
* Fixing linting errors
* Responding to PR feedback
* Fixing issue with the basepath and the login link
* Adding proper i18n prefix
* Updating unit tests
* User management - email and name should be optional (#24842)
Fixes #17952
* Add more accurate details on scripted field querying
* [esArchiver] auto-create the default space object when necessary (#24953)
* [esArchiver] auto-create the default space object when necessary
* [esArchiver] check for spaces plugin to create default space
* [ML] Fix for check for enabled xpack features (#24986)
* Adding jsxa11y into eslint rules (#23932)
* Duplicate search strategy errors to correspond to the number of original requests. This fixes a bug in which more than one search request error would result in a fatal error. (#24952)
* [Rollups] Disable deletion of started rollup jobs (#24878)
* Disable deletion of started rollup jobs.
* Update empty prompt icon.
* Add isUpdating selector and display a spinner instead of the action button when jobs are being updated.
* Localize Navigation component.
* Add noticeable delay of 300ms show spinner displays and doesn't flicker.
* Unable to filter saved objects by single type (#24950)
* display danger toast when savedObjectClient.find fails
* move toast notification out of is mounted check
* add test case for savedObjectsClient.find exeception
* compare query to current activeQuery from state to ignore out of order requests
* [Rollups] Add noOpSearchStrategy to handle rollup searches when rollups are disabled (#24798)
* Surface error within Dashboard panel.
* [config] transform plugin deprecations before checking for unused settings (#21294)
* transform plugin deprecations before checking for unused settings
* async deprecations provider
* refactor
* assign
* async tests
* Add png output to reports 65 (#24759)
* Changes for new PNG image output for reports
Change PNG button name from Download to Generate
Changes for new PNG image output for reports
Change PNG button name from Download to Generate
Remove compatabilityShim from PNG and move to PDF folders
Changed API parameters to contain only required parameters
Added test cases for PNG reporting and added title back into the PNG API call
Merge of security changes for PNG reporting
Fixed issues with test cases for both PDF and PNG
Updated test snapshots for PNG and PDF test changes
* Adding new security changes made for PDF into new PNG code
* Removed commented out lines that were not needed
* Fixes font picker when using custom fonts (#24937)
* Adds custom font as option in font picker
* Adjusted font sizes in ecommerce sample worpad
* Adjusted font sizes in sample flight workpad
* Adjusted font sizes in smaple web logs workpad
* Return wrapped unknown errors from rollup CRUD API. (#25032)
* Simplify pseudo localization for React components. (#24903)
* [APM] Fix missing parent issue (#25029)
* Show aliases in index details (#24048)
* Adds aliases to details for indicies.
* Lists aliases when there is more than one.
Fixes reload call using duplicate code atm.
Removes unintentional formatting change.
* Silly line ending removed by accident.
* Simplifies fetching aliases to single method/file.
* Adds superfluous logs statement.
* Uses the correct i18n translation variable for the header.
* Sets the translation variable to the correctly spelled variable.
* Simplifies building an array of aliases.
* Does not export fetchAliases as default.
* Makes the code more readable by destructing results.
* Adds test for expected results and no results.
* Adding support for single session cookies appearing in an Array (#24984)
* Adding support for single auth cookies appearing in an Array
* Removing redundant newline
* [Tools] Fix js multiline parsing in angular expressions (#24812)
* [Tools] Fix js multiline parsing in angular expressions
* Add test
* skip png screenshot comparison tests, they will fail on certain jenkins agents (#25028)
* [build] Support version-qualifier flag (#21663)
* [build] Support version-qualifier flag
* add help description
* fix test
* is-release
* temp: re-add alpha1 to package.json
* use version qualifier in build
* fix merge
* Revert "temp: re-add alpha1 to package.json"
This reverts commit a70688542cb7e79758f5173d137158219bff606b.
* x-pack
* remove ci build flag
* remove ci build flag
* remove qualifier from canvas
* remove qualifier from infra
* fix x-pack argv
* update comment
* Generate the correct bucket keys regardless of query type (#25002)
1. filter's query is a plain string
2. filter's query is a query_string query
3. filter's query is some other query DSL object
* Chore: fix canvas linting (#25024)
This fixes `yarn run lint` from within the Canvas plugin path.
- Point to the correct eslint config file
- Use absolute path for `packageDir`
- Remove extraneous `packageDir` settings
* Fix: socket setup (#24550)
PR fixes issues with the socket connection.
- handle socket failures
- previously would either leave Canvas in an infinite loading state, or load the app even when it wouldn't function
- upgrade socket.io
- add headers to socket connection and modify auth connection
* [ftr] allow filtering suites by tag (#25021)
Closes #22840
In the functional tests we want a better way to include/exclude certain tests, especially as we move forward with #22359. This PR allows us to decorate suite objects with "tags", which won't clutter up the test names and can be used to filter out specific tests within a single test config. The functional test runner supports defining `--include-tag` and `--exclude-tag` CLI arguments, and multiple can be defined.
The method of filtering out tests for running against cloud has been updated to use this approach and I plan to do the same to #22359 once this is merged.
* Prepend ES endpoint with slash (#25073)
* [Rollups] Fix invalid date histogram interval warning (#25066)
* Fix invalid date histogram interval warning
* Remove erroneous line
* [Rollups] Surface index pattern validation errors in Rollup Job wizard. (#25078)
* Show fatal error for unexpected errors.
* Added sort order to share menu options. (#25058)
* Added sort order to share menu options.
Sorts ascending on sort order first then ascending on name. Any menu item without a sort order gets set to zero.
* Moved new sortOrder property from node_modules
* Had to rerun the snapshot for the share menu with the sortOrder in it.
* Feature/translate canvas plugin src elements (#23755)
translate canvas canvas_plugin_src elements
* Translate vis color schema labels (#23603)
Translate color schemas labels
* Feature/translate license management (#24341)
Translate license management
* Ensure we probably init the route for the ccr page (#25050)
* Translations for ui/vis (#23694)
* Translate default editor
* Translate aria-labels, update ids
* Fix review comments
* Revert deletion of NOT
* Use one-time binding
* Translations for ui/vis
* Revert changes
* Fix a typo
* Refactoring
* Revert translations since they aren't displayed on ui
* resolve review comments
* [ML] Fixes typo. (#25130)
Fixes "Dectector" Typo.
* fixing issue with deleting scripted field in index pattern section (#25122)
* Replace xvfb with headless browser (#24904)
* Replace xvfb with headless browser
* Update karma to run in headless chrome
Update Karma tests for an option to run chrome in headless.
* Fix lint issues
* Fix spaces
* Security - convert LESS to SASS (#25079)
* convert security less to sass
* remove unused less styles from xpack_main
* [Infra UI] Rename InfraOps to Infrastructure (#25135)
* Re-enable these tests (#24600)
* Unskip the mappings test (#24667)
* Disable animations for xpack functional tests too (#25148)
* [Rollups] Improve Rollup Job Wizard error handling (#25092)
* Consistently format errors with showApiWarning and showApiError helpers.
* Use fatalError for unexpected errors.
* Localize errors.
* Surface error in Job List when the jobs can't be loaded.
* [InputControlVis] React 16.4+ compatibility (#25164)
* [input-control-vis/list-control-editor] add failing test to verify issue
* [input-control-vis/list-control-editor] update prevFieldName when fieldName changes
* fix typos (#25176)
* Fix aria attribute of icons on status page. (#25179)
* remove dashboardContext (#23227)
* Add Cloudwatch Logs tutorial (#24582)
* Add Cloudwatch Logs tutorial
This is the first tutorial that makes use of Functionbeat, so it adds the
related instructions.
Closes #23708.
* Fix dashboard export documentation (#24701)
* Infra UI: Fixing minor typo (#25005)
Resolves #25007.
Outbound traffic is generally denoted with TX, abbreviation for Transmit, instead of RX, abbreviation of Receive.
This PR fixes this minor typo.
* [Infra UI] Add beta badge with tooltip to the header (#25113)
In accordance with #25008, this adds a "Beta" badge with a corresponding tooltip to the header.
* Fix TSVB state updates when changing indexpatterns (#24832)
* Move fieldsFetch logic into the vis editor
* Add annotations index pattern change detection
* Fix async update of state. Add functional test
* Add missing data archive
* Force fetch when component mount the first time
* Fix parameters naming
* Refactoring indexPatterns to fetch
* [ML] MultiMetric/Population Job creation: Allow model plot enablement via checkbox (#24914)
* Add route/api-mapping for validateCardinality
* Create directive for enableModelPlot checkbox
* Ensure model plot enabled prior to cardinality check
* Add callout when cardinality high
* ensure correct cardinality success check
* Population wizard: add enableModelPlot checkbox
* Update with suggested changes from review
* Remove warning when invalid. Add tests.
* Ensure checkbox updated on uncheck
* remove inspector from Vis (#24112)
* [Tools] Rename i18n context field to description field (#25105)
* [Tools] Rename React i18n context field to description field
* Rename context to description in all i18n use cases
* [I18n] Migrate enzyme helpers to TypeScript (#25108)
* [I18n] Migrate enzyme helpers to TypeScript
* Migrate src enzyme helpers
* Remove eslint comments
* [Tools] Exclude node_modules folders from i18n_check (#25112)
* [Tools] Exclude node_modules folders from i18n_check
* Make node_modules be ignored by default
* Update exclusion patterns
* Remove console.log (#25207)
* [Infra UI] Normalizing CPU usage for waffle map (#25123)
This PR changes the aggregation for calculating the CPU usage for hosts to match the metrics overview calculation by adding both system and user together then dividing it by the number of cores. This PR also includes a fix for the Docker cpu field.
* other bucket filter for table and vislib legend (#24473)
* Ensure baselayers display in region maps (#22609)
* Add tmsLayers placeholder array to collections. Bind collections to wms-options scope
* Move tmsLayers attribute declaration to base visualization creation
* Add test to verify presence of road_map base layer option
* [ML] JobList search bar: Show useful error on invalid query (#25153)
* Show error on invalid query
* Additional undefined check for query
* Cleanup undefined check
* Fix missing TSVB markdown variables (#25132)
* Move fieldsFetch logic into the vis editor
* Add annotations index pattern change detection
* Fix async update of state. Add functional test
* Add missing data archive
* Force fetch when component mount the first time
* Fix parameters naming
* Refactoring indexPatterns to fetch
* Add observables and pipe data updates to markdown panel config
* Fix jest test
* Add timestamps for logs into the functional tests reports (#24509)
* feat(NA): first version to add logs to the functional test runner when running on dev.
* fix(NA): change timestamp position.
* test(NA): add unit test for tooling log text writer with timestamp.
* test(NA): update test and snapshots
* fix(NA): only apply timestamp logs for the jenkins test reports.
* test(NA): update jest snapshots correctly.
* fix(NA): only add timestamp for the test results cached chunk logs.
* fix(NA): rollback bad changes.
* refact(NA): change comments on code to be more clear with the purpose.
* refact(NA): rename chunk to line.
* feat(NA): log the relative time info since the start time of the task instead of the absolute time.
* [ML] Removes deprecated angularjs based jobs list and related code. (#25216)
* Fix the jenkins job for cloud to export headless browser variable (#25242)
* Add hacky workaround for getDerivedStateFromProps change in react 16.4 (#25142)
* [DOCS] Updates Elasticsearch and Kibana monitoring screenshots (#25035)
* Fix context test timing (#24949)
* Add sleeps so tests will pass
* removed a space in a comment
* replaced some sleeps with waiting for loading indicator
* Removed context page object calls from filter_bar and doc_table services
* kibana design owns .scss files (#23889)
* [APM] Show message for missing transaction sample (#25141)
* [BeatsCM] Rework table controls to use the pattern now found in the rest of Kibana (#25131)
* Rework table controls to use the pattern now found in the rest of Kibana
* Fix TS errors
* better fix TS issue
* uncomment code removed for testing
* dont allow tag creation if id is invalid (#25133)
* Adding beta marker (#25256)
* [BeatsCM] error on issues dont disable (#25149)
* display error messages for failed checks vs disableing plugin
* update text
* change order of check
* tweak security check
* re-disable on invalid license, update text
* update text
* tweaks
* tweak text
* Make canvas common lib ready for dependencies static analysis (#24756)
* refact(NA): make canvas common lib ready for static analysis.
* refact(NA): change export named to export all on canvas commmon lib datatable.
* tes(NA): fix isValid http url function name.
* refact(NA): rename parse to parseDataUrl
* Remove extra period for heartbeat add data (#25221)
* [ML] Add user privilege check to Jobs List group selector control (#25225)
* Implement new platform plugin discovery. (#24256)
* Add APM UI to codeowners (#25218)
* [APM] Additional clock skew fixes (#25097)
* Refactor service colors
* Calculate duration from full waterfall
* Ensure timeline label is not truncated
* Adjust child if it starts after parent has ended
* Add mark for traceRootDuration instead of xMax
* Fix tests
* [Infra UI] Work around IE11 flexbox alignment problems (#25224)
This works around some IE11 bugs with flexbox alignment, particularly [Flexbug #4](https://github.com/philipwalton/flexbugs#4-flex-shorthand-declarations-with-unitless-flex-basis-values-are-ignored) and a misinterpretation of the default alignment.
fixes #24758
fixes #24839
fixes #24791
fixes #24757
* Fixes bug with rison decode on Kibana links (#25214)
* Fixes bug with rison decode vs encode
* Adds and updates tests for kibana link component
* remove vis dependency from request handlers (#24119)
* [Infra UI] Remove duplicate "Overview" in detail page title (#25283)
This removes the duplicate word "Overview" from the title of the container details page.
fixes #24160
* Use the newly added remote_cluster field for ccr (#25248)
* [ML] Restore missing job timepicker modal. (#25288)
* [ML] Restore missing job timepicker modal.
* [ML] Added a karma/mocha test to verify dependencies are loaded correctly for new_job_controller.
* [ML] Use consistent import style.
* [DOCS] Adds screenshot for Data Visualizer (#25182)
* Updating request to ^2.88 (#25236)
* Move call to standard index pattern `fields for wildcard` from client to server (#25270)
* [canvas] unify eslint config in .eslintrc.js (#25260)
Simply remove the remaining eslint config files from canvas and merge with other canvas related overrides in `.eslintrc.js`
* [ML] Fixes file data viz file size check and format as bytes (#25295)
* [ML] Fixes file data viz file size check and format as bytes
* [ML] Fix typo in file size error callout
* Fix: Canvas babel build (#25184)
Closes https://github.com/elastic/kibana/issues/25154
Canvas' threading code uses babel-register for the runtime, much like Kibana does, so we can execute code that uses newer syntax (mostly es modules at this point...). The default configuration of babel-register ignores `node_modules`, and since x-pack is built into `node_modules`, this worked fine in dev mode and not at all in the build.
There was also an issue where Kibana's build step removes all bablerc files, which meant Canvas' threaded runtime also wasn't getting any of the settings.
This PR pulls in the configuration from Kibana, which has an exception for transpiling x-pack code, and allows the runtime to operate correctly in the build.
Huge thanks to @jbudz for helping me sort out the issue!
@spalger ~~know more about babel than I do, if we can just use `@kbn/babel-preset/node_preset` directly instead, that seems less likely to break going forward. I meant to try it but ran out of time yesterday to make another build.~~ Works! PR updated.
* [build] Uses node-archive to zip/tar packages (#25031)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
* [canvas] move yarn scripts to node scripts (#25258)
* [canvas] move yarn scripts to node scripts
* [canvas/eslint] allow scripts to access devDeps
* [canvas/eslint] remove packageDir override
* [x-pack] move babel-register to deps for canvas
* [canvas] rename scripts from : to _
* [canvas] update readme with correct script paths
* [canvas] remove yarn.lock file
* Remove redundant require
* Only loading the default index pattern when it's required (#25175)
* [build] make target folder before building packages (#25312)
* Revert "[build] Uses node-archive to zip/tar packages (#25031)" (#25326)
This reverts commit d89cc0ee150207aea5624bf2260c3cdc39981de5.
* [DOCS] Fixes typo in create role API (#25314)
* Fix execution examples for filebeat / metricbeat (#25170)
On windows these binaries are likely not on the path. By using `.\` as a prefix
these commands will correctly execute.
* [migration] Retry attempts for ES service unavailable (#25255)
Resolves a race condition where ES is technically up, but the Kibana
index is not.
Closes #25027
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
* [BeatsCM] text update (#25297)
* progress
* add missing text changes
* text tweak
* Update x-pack/plugins/beats_management/public/components/table/assignment_schema.ts
* fix: restore canvas error dialog
* [Rollups] Fix day of month only showing ordinals (#25322)
* Fix day of month only showing ordinals
* Wait for global loading indicator when creating index pattern (#25329)
* [canvas/gulp-scripts] replace script path in argv with gulp path (#25352)
* [build] Uses node-archive to zip/tar packages (#25335)
Started digging into an issue where compressing library didn't include empty
directories, which tar/zip should. After investigating the issue I feel it's
best to use a more established project.
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
* [migrations] Disable replicas (#25274)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
* Fix Canvas autocomplete to suggest all functions (#25351)
* fix: getFunctionDefinitions to load after the registry has been populated
* fix: use getBrowserRegistries instead of registry itself
* [BeatsCM] Allow for config based override of default user role (#25364)
* Allow for config based override of default user role
* [beats-cm] convert xpack.beats.defaultUserRole to array of roles
* [beats-cm] keep this context in #checkLicense
* Relax hosts validation in Beats central management (#25376)
Current regexp was disallowing schema part of the URL (https://), so
https hosts couldn't be configured.
I opted for fully relaxing the reg exp here, as Beat will check it
anyway, and report errors in case it's wrong.
* Auto open browser on server startup (#24843)
* Adds dev dependency on opn for opening browsers and other things.
* Adds a --open option to cli to open browser window.
* Removes unused variable in index.
* Adds opn types to dev dependencies from definitely typed.
* Adds open to the cliArgs type to allow for consistency.
* Updates snapshots that require valid cliArgs types.
* Moves opn to direct dependency since its used in cli.
* [cli] move --open handling to cluster manager
* Adds support for running --open with --no-base-path
* Fix File Upload fatal (#25361)
## Summary (fixes #25342)
There is a fatal when using the File Upload control in the image upload control. While the fatal appears to originate within the File Upload control, it is actually [coming from](https://github.com/clintandrewhall/kibana/blob/file-upload/x-pack/plugins/canvas/public/components/loading/index.js#L15) `Loading`, which attempts to use `react-redux` to change the `backgroundColor` of the loading indicator based on the page.
I couldn't find an instance where we use this Loading indicator outside of a redux context, so I've opted to simply use the control directly. @rashidkpc agreed this would be a good fix for the moment.
In addition, I fixed a props error coming from the data-url field that made it read-only, so I fixed that, too, as well as a formatting issue with the Set button.
## Test Plan
Added a `setTimeout` call to simulate load. Toggled between data url and literal URL.
- Before
- After
- Fixed Warning
### Checklist
Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.
- [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)
- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~
~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~
~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~
### For maintainers
~~- [] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
* Fix: Asset preservation (#25359)
* fix: proptype error
* fix: correct proptype checking
* fix: add assets placeholder to initial state
* chore: add history formatting function
* fix: load workpad assets when ids change
this causes the correct assets to be used
* [DOCS] Fixes typo in Kibana create role example (#25345)
* EAH - add typescript to a couple of ui/public/utils files (#23946)
* typescriptin a few ui/public
* remove mistaken commits
* typescript numeric
* ts migrateLegacyQuery
* object or string type
* no need for file extension on import statement
* revert mistaken commit
* type fix - only object
* snake case!
* Update EUI to v5.0.0 (#25316)
* update EUI to v5.0.0
* update snapshots
* revert snapshot change
* revert snapshot change (2)
* [DOCS] Adds data visualizer restriction (#25399)
* Using the new ES Realm syntax for SAML (#25223)
* [APM] Fix missing transaction message (#25353)
* [APM] Fix Rison issues (#25377)
* [APM] Fix Rison issues
* Fix CI
* Removed abstractions (and broke tests)
* Slight rework and small bugfix for query param handling
* Removed typo used for visibility testing oops
* Removes unused dep because linting doesnt work apparently
* [DOCS] Adds early draft of Canvas docs (#25395)
* [DOCS] Adds early draft of Canvas docs
* [DOCS] Added images and beta label to Canvas docs
* [DOCS] Clarify security requirements for monitoring (#24881)
* Update "Debugging server code" instructions in CONTRIBUTING.md (#25397)
* Add more details for debugging Kibana server
* add debugging server code to table to contents
* [ML] angularjs controller initialization tests. (#25382)
* [ML] Confirm Modal Controller Test.
* [ML] Message Bar Controller test.
* [ML] Data Visualizer Controller test.
* [ML] Detector Filter Modal Controller test.
* [ML] Detector Modal Controller test.
* [ML] Save Status Modal Controller test.
* [ML] Multi Metric Create Job Controller test.
* [ML] Population Create Job Controller test.
* [ML] Recognize Create Job Controller test.
* [ML] Single Metric Create Job Controller test.
* [ML] Index Or Search Controller test.
* [ML] Job Type Controller test.
* [ML] Angular Bootstrap Patch Dropdown Controller test.
* [ML] Settings Controller test.
* [ML] Calenders List Controller test.
* [ML] New Event Modal Controller test.
* [ML] New Event Modal Controller test.
* [ML] Create Calendar Controller test.
* [ML] Time Series Explorer Controller test.
* [ML] Fixes typo, clearer test name.
* [ML] Fixes tests by restoring stubs.
* [APM] Fix gap in timeline and fallback when traceroot is missing (#25346)
* Fix gap in timeline
* Show fallback when traceroot is unavailable
* Fix test
* Fix rendering issues with styled-components
* Remove `parentTransactionSkew `
* Minor test fixes
* [ML] Updates job type and APM module icon to new designs (#25380)
* [ML] Updates job type and APM module icon to new designs
* [ML] Use self closing tags for icons
* [ML] Removes unnecessary icon from jobs list
* [ML] Fixes the layout of the cards in the Data Visualizer on IE (#25383)
* [DOCS] Updates information regarding usage of sample data indices (#25424)
* Update clickOptionalAddNewButton method used in createIndexPattern (#25414)
* Wrap long field names in Rollup Job Wizard tables. (#25405)
* Upgrading grunt-contrib-watch (#22818)
* [APM] Format as microseconds (#24974)
* [APM] Format as microseconds
* Split interface into `value` and `options`
* Update formatters.test.ts
* [APM] Minor cleanup of constants (#25177)
* [APM] Minor cleanup of constants
* Simplify constants test
* fix: get correct plugins path (#25448)
we can't check the name of the outer path because it can change, instead, just make sure there's a plugins path there
* Fix non-conforming licenses on devDependencies and add the ability to whitelisting devOnly licenses (#23859)
* chore(19834): upgraded yargs dependency to 4.8.1 in order to remove pkg-conf dependency license conflict.
* chore(19834): override xmldom to one of the allowed licenses (MIT).
* chore(19834): added some overrides and whitelistenig for Apache2.
* chore(19834): correct overides for some apache2 licenses.
* chore(NA): updated specific dependency needs.
* chore(19834): added some more info on updated licenses.
* chore(19834): small note on dependencies use versions.
* feat(NA): add the ability to white list licenses only valid for dev only dependencies.
* chore(NA): update yarn lock files to include integrity check.
* fix(NA): yarn lock file for kbn ui framework.
* docs(NA): fix uncompleted comment left on the code.
* [Tools] Add string concatenation parsing (#25381)
* Docs/canvas get started (#25476)
* edits to canvas getting started docs
* edit to canvas workpad docs
* [DOCS] Refreshes ML job creation screenshots (#25417)
* [DOCS] Adds docs for managing, creating, and visualizing rollups (#25450)
* [DOCS] Adds docs for managing, creating, and visualizing rollups
* [DOCS] Fixed broken link]
* [DOCS] Updates docs based on review feedback
* Fix: Quote the index pattern in SQL input (#25488)
SQL requires that you quote the index name if you are using special characters (like *, with an index pattern). Our default value didn't work since `logstash*` was not quoted.
### Before
### After
...and if you select some valid fields so you don't get an array in the results:
* [ui] default to k7Design in releases (#25487)
* [ui] default to k7Design in releases
* [ci] don't build in release mode for testing
* [ci] run SNAPSHOT build
* Only set timeout when larger 0 in timelion (#25461)
* logo updates for marketing (#25489)
* [kbn-pm] Use yarn workspaces for dependencies (#24095)
* Run jenkins:unit task with dev flag in order to run license check (#19832)
* chore(19674): added dev flag when calling jenkins:unit grunt task so we can check dev licenses on ours ci jobs.
* chore(NA): update yarn lock files with integrity info.
* [Flaky test fix] Turn back on data_shared_attributes test (#25156)
* Turn back on data_shared_attributes test and run 20x
* Add some clean up
* Be more determinism, less refactoring.
* Go back to a single test run
* [ci] define matrix axes in code (#25360)
* [ci] define matrix axes in code
* [ci] add null exclude rule
* [ci] make script executable
* [ci] execute sub-scripts
* [ci] simplify job variable name
* fix(NA): recent unconforming licenses. (#25560)
* [canvas] Improve plugin pre-build (#25267)
Fixes https://github.com/elastic/kibana/issues/23552
Extends the webpack config used to pre-build `x-pack/plugins/canvas/canvas_plugins_src` so that it does a couple things:
- use the "browser" and "main" fields when defined by packages, this allows the already transpiled output of packages like `@elastic/eui` to be used rather than rebuilding from source
- use the `@kbn/babel-preset/webpack_preset` for babel-loader
- include all errors in the log output when an error occurs
* Fixes duplicate 'Value' options in math function select (#25556)
* [Canvas] Decrease size of tray toggle (#25470)
* decrease size of toggle bar
* change bg colors for toggle
* Adds UI notification for dropped spans (#25017)
* Adds icon and tooltip for dropped spans
* Adds callout and style in transaction flyout instead of timeline for dropped spans message
* Review tweaks and linting fixes
* [I18n] Translate Timelion (#23880)
* Add translations for timelion plugin
* Fix bugs
* Fix messages ids, resolve comments
* Update translations
* Refactor links messages
* Fix values bug
* Use template literals to avoid single quote escaping
* [Tools] Validate values in nested ICU messages (#25378)
* [i18n] Translations for Monitoring: Logstash (#24897)
* Translate Monitoring logstash
* Fix a typo
* Update unit tests
* [DOCS] Adds known limitation for exporting a data table (#25561)
* disable flaky test
* handle EuiSearchBar query parse failures (#25235)
* handle EuiSearchBar query parse failures
* I18n parse failure messages
* review updates
* more cleanup on settings search.test
* Fix paths to the i18n enzyme helpers in monitoring tests. (#25593)
* Fixes index pattern wizard when there are remote clusters but no local indices (#24339)
* don't hide wizard if clusters exist
* catch errors
* add toast notifs if unable to load data
* [kbn-plugin-generator] add reference to es script in Kibana (#25607)
* [kbn-plugin-generator] gitignore app.css if scss used (#25609)
When generating a plugin with the plugin generator and scss is in use, we should add the generated `app.css` file to the .gitignore file.
* [DOCS] Saved object migrations (#25558)
* Add a note about index migrations to the kibana setup docs
* Tewak the migrations asciidocs for clarity
* docs: refine saved object migration details
Breaking down the migration process into sections helps people find
and link to relevant information more easily.
The focus is on ongoing maintenance of Kibana, whereas the initial new
experience in 6.5.0 is treated as a note of clarification.
Error handling should be expanded in the future to include details about
specific known error cases.
* [es-test-cluster] increase start timeout for snapshots (#25600)
* [Bug] Fixing flash of unstyled dashboard content (#25559)
Fixes #25375
* Feature/translate monitoring table (#24973)
* Translate monitoring -> summary_status, table, main.html in directives
* Fix issues
* Fix tests
* Add disable eslint for unused var intl
* Combine common pdf png functions (#25152)
* Create common routines for PDF and PNG report processing
* REmove Blacklisted headers not needed
* Changes for issues with PDF and PNG testing
As per Joel Griffith suggestion I added removal of toast notifications after each click download report. And removed setting of image density to 300.
* removed uneccesary image compare routine
* Moved server from property on job to passed in parameter.
* consolidated PDF and PNG testing
Moved test code from PDF and PNG index.test.js into a common index.test.js that now tests the common functions.
* Typescripted the common functions and broke out tests to individual test files
* Create a common create mock server function that all new tests call
* Removed unnecessary exception check and removed test include from index.ts
* Add href option in addition to onClick (#25233)
* Add href option in addition to onClick
* Small modificationd and adding tests
* Add missing import
* Switch order of tests
* Don't close panel menu again
* Merge with Master 11/14/2018
nreese
added a commit
that referenced
this pull request
Nov 14, 2018
cuff-links
pushed a commit
that referenced
this pull request
Nov 15, 2018
* refactor(Watcher): Reword translation id for missing property on objects (#24753)
* [Monitoring] Use the cluster name from metadata if it exists (#24495)
* Use the cluster name from metadata if it exists
* PR comments
* [dev/build] scan node_modules rather than lots of deleteAll() calls (#24692)
* Default scroll wheel zoom to false on vega maps. Update docs (#21169)
* Default scroll wheel zoom to false on vega maps. Update docs
* Update scroll wheel to false in tests
* Return promise in reporting jobs API (#24769)
* [Rollups] Copy improvements (#24528)
* Reporting cookies 2 (#24752)
* Revert "Reporting cookies (#24177)"
This reverts commit 9f4ec18000a74e269276ff943979799ccbd4d950.
* Take 2
* Adding comment
* Better escaping and encoding for use in eval
* Checking for an empty string also
* Fixing session test
* [master] disable flaky test - #24287
* [Rollups] Fix time field not being recognized due to ordering of aggs (#24783)
* Fix time field not being recognized due to ordering of aggs
* Clean up UI whitespace
* Update snapshot
* [@kbn/datemath] improve types (#24671)
* [kbn-datemath][parseEsInterval] improve types slightly
* [kbn-datemath][vis/leastCommonInterval] make types more precise
* [ui/leastCommonInterval] fix bug in finding same types
* add back valid test
* [yarn] bump elasticsearch-js and makelogs (#24767)
In order to support esjs apiVersion 6.5 we need to upgrade to the newly released version of elasticsearch-js. Bumping makelogs allowed us to keep only one version of the elasticsearch module installed.
* [APM] Removes action menus (#24748)
* Removes infra links and replaces context menu with single discover links for now
* Changes discover links to use empty button style
* Fixes unauthorized error in es datasources (#24624)
* Fixes check for security plugin
* Cleaned up security check logic. Fixed tests for create_handlers. Added TODOs
* Updated comment
* Added tests
* Updated variable names
* [optimizer] ignore node_modules anywhere in the x-pack directory (#24797)
I noticed the following message while watching the build output:
```
00:33:19.131 │ info [kibana] > /var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/install/kibana/bin/kibana --optimize.useBundleCache=true --env.name=development --logging.json=false --server.port=5620 --optimize.watchPort=5630 --optimize.watchPrebuild=true --status.allowAnonymous=true --elasticsearch.url=http://elastic:changeme@localhost:9220 --elasticsearch.username=elastic --elasticsearch.password=changeme --server.uuid=5b2de169-2785-441b-ae8c-186a1936b17d --xpack.xpack_main.telemetry.enabled=false --xpack.security.encryptionKey="wuGNaIhoMpk5sO4UBxgr3NyW1sFcLgIf" --optimize.enabled=true --xpack.reporting.capture.browser.type=chromium --xpack.spaces.enabled=false
00:33:38.533 │ proc [kibana] log [23:20:25.923] [info][optimize] Optimizing and caching bundles for ml, stateSessionStorageRedirect, status_page, timelion, graph, monitoring, login, logout, dashboardViewer, apm, canvas, infra and kibana. This may take a few minutes
00:34:12.650 │ proc [kibana] [BABEL] Note: The code generator has deoptimised the styling of "/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/install/kibana/node_modules/x-pack/plugins/infra/node_modules/lodash/lodash.js" as it exceeds the max of "500KB".
00:36:11.346 │ proc [kibana] log [23:22:58.721] [info][optimize] Optimization of bundles for ml, stateSessionStorageRedirect, status_page, timelion, graph, monitoring, login, logout, dashboardViewer, apm, canvas, infra and kibana complete in 152.79 seconds
```
The "code generator has deoptimised" line specifically raised a red flag as babel shouldn't be running on node_modules. We have admittedly weak regular expressions in two places to enforce this. The first is in https://github.com/elastic/kibana/blob/49071132c3c14590dea877bccb7647bbec1e1459/src/setup_node_env/babel_register/register.js#L42, which I verified matched `node_modules` directories within the `node_modules/x-pack` directory, but the other is https://github.com/elastic/kibana/blob/49071132c3c14590dea877bccb7647bbec1e1459/src/optimize/base_optimizer.js#L152-L154 which does not. It only excludes files from babel in webpack if they are within a node_modules directory that is a direct child of `node_modules/xpack`, but with InfraOps and Canvas we now have node_module directories at `plugins/*/node_modules`.
This should probably be fixed by preventing plugins from installing their own node_modules, but since that would involve upgrading/moving plugins between major versions of dependencies like lodash that's somewhat impractical from where I stand, so instead I've just updated the webpack module rule to exclude any `node_modules/xpack/**/node_modules` directory.
* [beats/heartbeat] Fix heartbeat add data instructions (#24795)
This commit does three things:
0. This fixes the instructions for interacting with the heartbeat service, which is called `heartbeat-elastic` not `heartbeat`
1. This removes some extraneous text that should be reserved for the subsequent section.
2. This makes the instructions for creating a monitor more explicit
* [ML] Fix a call stack size exception triggered by a negative tickInterval. (#24742)
In certain cases tickInterval mistakenly could end up being negative which made getTickValues() run into a call stack size exception. This PR fixes it by a) adding a check to getTickValues() that interval must not be 0 or smaller and b) changing the way the tickInterval is determined in the Anomaly Explorer Charts.
* [ML] Removing new ML job link in basic license (#24676)
* [ML] Reducing risk of upload timeouts (#24677)
* [ML] Reducing risk of upload timeouts
* function rename
* removing hardcoded number
* fixing typo
* updating comment
* [APM] Added line-height to table cell (#24768)
Improved reading of the contents, especially in the Transaction Flyout.
* [ML] Fixes missing y-axis description for rare chart. (#24823)
Fixes the missing y-axis description for rare charts in the form of y-axis event distribution split by {{fieldName}}. The intention is to briefly clarify that the type of chart is different than the other ones which have a count or metric based y-axis. This text is in addition to the text provided (but hidden without hovering) in the info icon tooltip.
* Check for toast before waiting for page to finish loading to avoid mi… (#24424)
* Check for toast before waiting for page to finish loading to avoid missing the toast by the time the page finishes
* turn test back on
* Feature/translate new nav bar breadcrumb state (#24327)
Translate new_nav_bar breadcrumbState
* add i18n angular module as dependency for nav bar directive (#24754)
* Add onBrush functionality to APM monitoring ui graphs (#24840)
* [tests] localhost.com -> localhost (#23816)
* Removes defunct function test runner Grunt task (#24673)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
* Re-initialize Rollup Management userHasLeftApp state to fix bug with clearing URLjob deep-link when detail panel is closed. (#24841)
* Add warning to the documentation_links file about link validation gotcha (#24786)
* add warning to the documentation_links file about link validation gotcha
* Use Clint's full name
* Fix Wildcard Queries Against The Default Field (#24778)
When querying against the default field (i.e. querying without specifying a field) we weren't correctly handling values with wildcards in them.
* [BeatsCM] Change Index template name (#24835)
* [BeatsCM] Change Index template name
* Update x-pack/plugins/beats_management/server/management_server.ts
* Update x-pack/plugins/beats_management/server/lib/adapters/database/__tests__/test_contract.ts
* Add a console.error to visualize errors (#24581)
* [Rollups] Fix i18n bugs (#23848)
* Internationalize job details tabs and wrap instances in EuiErrorBoundary to visually localize the error.
* Localize no default index pattern message.
* Localize es interval errors.
* Localize job action menu and confirm delete modal.
* Remove unnecessary use of injectI18n from tabs.
* Localize job status.
* Localize steps.
* Remove template literals from FormattedMessages.
* [APM] fixes #24563 by de-duping the column field id 'sample' (#24690)
* [APM] fixes #24563 by replacing de-duping the twice-used column field id
* [APM] fixed issue with service column not sorting in ManagedTable
* [APM] make render field on ITableColumn optional and allowing it to use EUI's default value
* Design clean-up for 6.5, Part Deux (#24862)
* Fixes active tab state
* Removes beta labels from ML and search bar
* Reverts visual regression with right-to-left timeline fix
* Creates space for agent marks beneath tick marks
* Fixes ordering problem with timeline transaction icons
* Updates string 0 to be an integer instead for CSS bottom value
* Allows build to be ran on Windows (#24374)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
* refactor: Convert utils/collection to Typescript (#23992)
* Vega translations (#23677)
add vega translations
* [APM] Hoist loading of waterfall and flatten it (#24651)
* [APM] Hoist loading of waterfall and flatten it
Remove unused test
Convert to typescript
* Address feedback
* Make `totalDuration` optional
* Renamed rootTransaction to traceRoot
* [APM] Only show relevant service legends
* Adds services label to the service legend
* [APM] Clock skew fix
Only skew child spans from the same service
Take parent skew into account when finding diff
# Conflicts:
# x-pack/plugins/apm/public/components/app/TransactionDetails/Transaction/WaterfallContainer/Waterfall/waterfall_helpers/__snapshots__/waterfall_helpers.test.ts.snap
# x-pack/plugins/apm/public/components/app/TransactionDetails/Transaction/WaterfallContainer/Waterfall/waterfall_helpers/waterfall_helpers.test.ts
# x-pack/plugins/apm/public/components/app/TransactionDetails/Transaction/WaterfallContainer/Waterfall/waterfall_helpers/waterfall_helpers.ts
* Use switch statement
* [ML] Set new index pattern as default one if no default index pattern exists yet. (#24337)
This replicates the behaviour of the management UI: If there's no default index pattern, the one created via file visualizer's import will be set as the default index pattern.
* Fixes APM snapshot for CSS value (#24898)
* Translations for Dev Tools (#23951)
translate dev-tools-console
* [ML] Display a ordinal y axis for low cardinality rare charts. (#24852)
Introduces a categorical/ordinal y axis for rare charts with a cardinality of <= 10. This also adds unit tests for the rare/population chart which are the bulk of the PR.
* [InfraOps] Preserve time values when navigating from the waffle map to the logs and details pages (#24666)
This adds `time` and `from`/`to` parameters to the metrics and logs links of node context menu in the waffle map.
* [APM] fixes #23808 by adding docs links for user/tags transaction apis for the java agent (#24869)
* [ML] Fixes bug with category filtering flag for rare/population charts. (#24901)
Fixes a bug where the filtering limit of categories for the rare chart was actually applied to the population chart variant.
* Reorders agents for on prem tutorial (#24872)
* [DOCS] Updates monitoring diagram (#24851)
* [ML] Fix for delimited data with whitespace in fields (#24899)
* [ML] Fix for delimted data with whitespace in fields
* rewriting to use papaparse transform function
* Fix error log formatting (#24788)
* [ML] Fixing issues when trying to import non-timestamp data (#24894)
* [ML] Fixing issues when trying to import non-timestamp data
* making results link time range optional
* small cleanup after fixing merge conflict
* console: add ignore_failure to ingest common auto complete (#24915)
* Update CI setup for windows to install yarn in global path (#24558)
* Update windows ci setup to install yarn global
* Keep formatting consistent
* Update yarn installation for linux
* Updating paths and removing cache folder
* [Rollups] Re-enable rollup support (#24888)
* Re-enable rollup support extension points
* [Rollups] Hide rollups consumption behind a feature flag in Advanced Settings. (#24698)
* adding alt tag with empty text to fix jsx-a11y errors (#24922)
* Disabling es lint for 3 of the canvas files (#24902)
disabling eslint for Canvas because we are adding in jsx-a11y rules to eslint and adding a missing copyright header
* add css grid style to prevent calendar bounce (#24913)
* Upgrading deep-extend to 0.6.0 (#22817)
* Upgrading deep-extend to 0.6.0
* Upgrading deep-extend again
* [dev/build] avoid building packages twice (#24696)
* Reverting 22816, upgrading mocha is breaking the custom reporter (#24951)
* [Rollups] Mark beta in rollup index pattern creation (#24805)
* Add beta UI tags to rollup index pattern creation
* Add test, update snapshots
* Address feedback, adjust copy, and localize rollup index pattern creation
* [APM] Fix divide by 0 bug in percentage duration (#24675)
* [APM] Fixes #40165 by consolidating logic where total duration could be 0 and handling it with a fallback value
* [APM] renamed file from .js to .ts and defined a default value for fallback
* [APM] Add type definitions for apm formatters
* [APM] add basic type definition for imported @elastic/numeral module
* [APM] rename getDurationPercent to asPercent
* [APM] Update tests with the renamed formatter function
* [APM] Pr feedback & typescript cleanup
* [APM] fix bucket & chart point type errors
* Fix typescript issue
* [APM] last minute code cleanup
* [I18n] Sanitize angular directive message before inserting it to DOM (#24830)
* [I18n] Sanitize message before inserting it to DOM
* Add tests
* [APM] Discover links with quoted values and use default 24h as time range (#24900)
* [APM] Discover links with quoted values
* Use 24h as default time range
* Fix/react intl testing helper functions (#24527)
update testing helper functions for react-intl
now we use real intl object passed by IntlProvider via context instead of mocking intl object.
so now data(strings, JSX) passed to FormattedMessage component via values are compiled and
are inserted in the output of FormattedMessage component
* Using Joi.object when configuring route validation (#24596)
* Using Joi.object when configuring route validation
* Adding forgotten API
* Fixing test
* Adding "Successfully logged out" page (#23890)
* Adding very basic place for the logged out page
* Redirecting to logged_out when we aren't using SLO
* Basing styles on the login styles
* Fixing linting errors
* Responding to PR feedback
* Fixing issue with the basepath and the login link
* Adding proper i18n prefix
* Updating unit tests
* User management - email and name should be optional (#24842)
Fixes #17952
* Add more accurate details on scripted field querying
* [esArchiver] auto-create the default space object when necessary (#24953)
* [esArchiver] auto-create the default space object when necessary
* [esArchiver] check for spaces plugin to create default space
* [ML] Fix for check for enabled xpack features (#24986)
* Adding jsxa11y into eslint rules (#23932)
* Duplicate search strategy errors to correspond to the number of original requests. This fixes a bug in which more than one search request error would result in a fatal error. (#24952)
* [Rollups] Disable deletion of started rollup jobs (#24878)
* Disable deletion of started rollup jobs.
* Update empty prompt icon.
* Add isUpdating selector and display a spinner instead of the action button when jobs are being updated.
* Localize Navigation component.
* Add noticeable delay of 300ms show spinner displays and doesn't flicker.
* Unable to filter saved objects by single type (#24950)
* display danger toast when savedObjectClient.find fails
* move toast notification out of is mounted check
* add test case for savedObjectsClient.find exeception
* compare query to current activeQuery from state to ignore out of order requests
* Added some tweaks for tests to pass on OSX.
* [Rollups] Add noOpSearchStrategy to handle rollup searches when rollups are disabled (#24798)
* Surface error within Dashboard panel.
* [config] transform plugin deprecations before checking for unused settings (#21294)
* transform plugin deprecations before checking for unused settings
* async deprecations provider
* refactor
* assign
* async tests
* Add png output to reports 65 (#24759)
* Changes for new PNG image output for reports
Change PNG button name from Download to Generate
Changes for new PNG image output for reports
Change PNG button name from Download to Generate
Remove compatabilityShim from PNG and move to PDF folders
Changed API parameters to contain only required parameters
Added test cases for PNG reporting and added title back into the PNG API call
Merge of security changes for PNG reporting
Fixed issues with test cases for both PDF and PNG
Updated test snapshots for PNG and PDF test changes
* Adding new security changes made for PDF into new PNG code
* Removed commented out lines that were not needed
* Fixes font picker when using custom fonts (#24937)
* Adds custom font as option in font picker
* Adjusted font sizes in ecommerce sample worpad
* Adjusted font sizes in sample flight workpad
* Adjusted font sizes in smaple web logs workpad
* Return wrapped unknown errors from rollup CRUD API. (#25032)
* Simplify pseudo localization for React components. (#24903)
* [APM] Fix missing parent issue (#25029)
* Show aliases in index details (#24048)
* Adds aliases to details for indicies.
* Lists aliases when there is more than one.
Fixes reload call using duplicate code atm.
Removes unintentional formatting change.
* Silly line ending removed by accident.
* Simplifies fetching aliases to single method/file.
* Adds superfluous logs statement.
* Uses the correct i18n translation variable for the header.
* Sets the translation variable to the correctly spelled variable.
* Simplifies building an array of aliases.
* Does not export fetchAliases as default.
* Makes the code more readable by destructing results.
* Adds test for expected results and no results.
* Adding support for single session cookies appearing in an Array (#24984)
* Adding support for single auth cookies appearing in an Array
* Removing redundant newline
* [Tools] Fix js multiline parsing in angular expressions (#24812)
* [Tools] Fix js multiline parsing in angular expressions
* Add test
* skip png screenshot comparison tests, they will fail on certain jenkins agents (#25028)
* [build] Support version-qualifier flag (#21663)
* [build] Support version-qualifier flag
* add help description
* fix test
* is-release
* temp: re-add alpha1 to package.json
* use version qualifier in build
* fix merge
* Revert "temp: re-add alpha1 to package.json"
This reverts commit a70688542cb7e79758f5173d137158219bff606b.
* x-pack
* remove ci build flag
* remove ci build flag
* remove qualifier from canvas
* remove qualifier from infra
* fix x-pack argv
* update comment
* Generate the correct bucket keys regardless of query type (#25002)
1. filter's query is a plain string
2. filter's query is a query_string query
3. filter's query is some other query DSL object
* Chore: fix canvas linting (#25024)
This fixes `yarn run lint` from within the Canvas plugin path.
- Point to the correct eslint config file
- Use absolute path for `packageDir`
- Remove extraneous `packageDir` settings
* Fix: socket setup (#24550)
PR fixes issues with the socket connection.
- handle socket failures
- previously would either leave Canvas in an infinite loading state, or load the app even when it wouldn't function
- upgrade socket.io
- add headers to socket connection and modify auth connection
* [ftr] allow filtering suites by tag (#25021)
Closes #22840
In the functional tests we want a better way to include/exclude certain tests, especially as we move forward with #22359. This PR allows us to decorate suite objects with "tags", which won't clutter up the test names and can be used to filter out specific tests within a single test config. The functional test runner supports defining `--include-tag` and `--exclude-tag` CLI arguments, and multiple can be defined.
The method of filtering out tests for running against cloud has been updated to use this approach and I plan to do the same to #22359 once this is merged.
* Prepend ES endpoint with slash (#25073)
* [Rollups] Fix invalid date histogram interval warning (#25066)
* Fix invalid date histogram interval warning
* Remove erroneous line
* [Rollups] Surface index pattern validation errors in Rollup Job wizard. (#25078)
* Show fatal error for unexpected errors.
* Added sort order to share menu options. (#25058)
* Added sort order to share menu options.
Sorts ascending on sort order first then ascending on name. Any menu item without a sort order gets set to zero.
* Moved new sortOrder property from node_modules
* Had to rerun the snapshot for the share menu with the sortOrder in it.
* Feature/translate canvas plugin src elements (#23755)
translate canvas canvas_plugin_src elements
* Translate vis color schema labels (#23603)
Translate color schemas labels
* Feature/translate license management (#24341)
Translate license management
* Ensure we probably init the route for the ccr page (#25050)
* Translations for ui/vis (#23694)
* Translate default editor
* Translate aria-labels, update ids
* Fix review comments
* Revert deletion of NOT
* Use one-time binding
* Translations for ui/vis
* Revert changes
* Fix a typo
* Refactoring
* Revert translations since they aren't displayed on ui
* resolve review comments
* [ML] Fixes typo. (#25130)
Fixes "Dectector" Typo.
* fixing issue with deleting scripted field in index pattern section (#25122)
* Replace xvfb with headless browser (#24904)
* Replace xvfb with headless browser
* Update karma to run in headless chrome
Update Karma tests for an option to run chrome in headless.
* Fix lint issues
* Fix spaces
* Security - convert LESS to SASS (#25079)
* convert security less to sass
* remove unused less styles from xpack_main
* [Infra UI] Rename InfraOps to Infrastructure (#25135)
* Re-enable these tests (#24600)
* Unskip the mappings test (#24667)
* Disable animations for xpack functional tests too (#25148)
* [Rollups] Improve Rollup Job Wizard error handling (#25092)
* Consistently format errors with showApiWarning and showApiError helpers.
* Use fatalError for unexpected errors.
* Localize errors.
* Surface error in Job List when the jobs can't be loaded.
* [InputControlVis] React 16.4+ compatibility (#25164)
* [input-control-vis/list-control-editor] add failing test to verify issue
* [input-control-vis/list-control-editor] update prevFieldName when fieldName changes
* fix typos (#25176)
* Fix aria attribute of icons on status page. (#25179)
* remove dashboardContext (#23227)
* Add Cloudwatch Logs tutorial (#24582)
* Add Cloudwatch Logs tutorial
This is the first tutorial that makes use of Functionbeat, so it adds the
related instructions.
Closes #23708.
* Fix dashboard export documentation (#24701)
* Infra UI: Fixing minor typo (#25005)
Resolves #25007.
Outbound traffic is generally denoted with TX, abbreviation for Transmit, instead of RX, abbreviation of Receive.
This PR fixes this minor typo.
* [Infra UI] Add beta badge with tooltip to the header (#25113)
In accordance with #25008, this adds a "Beta" badge with a corresponding tooltip to the header.
* Fix TSVB state updates when changing indexpatterns (#24832)
* Move fieldsFetch logic into the vis editor
* Add annotations index pattern change detection
* Fix async update of state. Add functional test
* Add missing data archive
* Force fetch when component mount the first time
* Fix parameters naming
* Refactoring indexPatterns to fetch
* [ML] MultiMetric/Population Job creation: Allow model plot enablement via checkbox (#24914)
* Add route/api-mapping for validateCardinality
* Create directive for enableModelPlot checkbox
* Ensure model plot enabled prior to cardinality check
* Add callout when cardinality high
* ensure correct cardinality success check
* Population wizard: add enableModelPlot checkbox
* Update with suggested changes from review
* Remove warning when invalid. Add tests.
* Ensure checkbox updated on uncheck
* remove inspector from Vis (#24112)
* [Tools] Rename i18n context field to description field (#25105)
* [Tools] Rename React i18n context field to description field
* Rename context to description in all i18n use cases
* [I18n] Migrate enzyme helpers to TypeScript (#25108)
* [I18n] Migrate enzyme helpers to TypeScript
* Migrate src enzyme helpers
* Remove eslint comments
* [Tools] Exclude node_modules folders from i18n_check (#25112)
* [Tools] Exclude node_modules folders from i18n_check
* Make node_modules be ignored by default
* Update exclusion patterns
* Remove console.log (#25207)
* [Infra UI] Normalizing CPU usage for waffle map (#25123)
This PR changes the aggregation for calculating the CPU usage for hosts to match the metrics overview calculation by adding both system and user together then dividing it by the number of cores. This PR also includes a fix for the Docker cpu field.
* other bucket filter for table and vislib legend (#24473)
* Ensure baselayers display in region maps (#22609)
* Add tmsLayers placeholder array to collections. Bind collections to wms-options scope
* Move tmsLayers attribute declaration to base visualization creation
* Add test to verify presence of road_map base layer option
* [ML] JobList search bar: Show useful error on invalid query (#25153)
* Show error on invalid query
* Additional undefined check for query
* Cleanup undefined check
* Fix missing TSVB markdown variables (#25132)
* Move fieldsFetch logic into the vis editor
* Add annotations index pattern change detection
* Fix async update of state. Add functional test
* Add missing data archive
* Force fetch when component mount the first time
* Fix parameters naming
* Refactoring indexPatterns to fetch
* Add observables and pipe data updates to markdown panel config
* Fix jest test
* Add timestamps for logs into the functional tests reports (#24509)
* feat(NA): first version to add logs to the functional test runner when running on dev.
* fix(NA): change timestamp position.
* test(NA): add unit test for tooling log text writer with timestamp.
* test(NA): update test and snapshots
* fix(NA): only apply timestamp logs for the jenkins test reports.
* test(NA): update jest snapshots correctly.
* fix(NA): only add timestamp for the test results cached chunk logs.
* fix(NA): rollback bad changes.
* refact(NA): change comments on code to be more clear with the purpose.
* refact(NA): rename chunk to line.
* feat(NA): log the relative time info since the start time of the task instead of the absolute time.
* [ML] Removes deprecated angularjs based jobs list and related code. (#25216)
* Fix the jenkins job for cloud to export headless browser variable (#25242)
* Add hacky workaround for getDerivedStateFromProps change in react 16.4 (#25142)
* [DOCS] Updates Elasticsearch and Kibana monitoring screenshots (#25035)
* Fix context test timing (#24949)
* Add sleeps so tests will pass
* removed a space in a comment
* replaced some sleeps with waiting for loading indicator
* Removed context page object calls from filter_bar and doc_table services
* kibana design owns .scss files (#23889)
* [APM] Show message for missing transaction sample (#25141)
* [BeatsCM] Rework table controls to use the pattern now found in the rest of Kibana (#25131)
* Rework table controls to use the pattern now found in the rest of Kibana
* Fix TS errors
* better fix TS issue
* uncomment code removed for testing
* dont allow tag creation if id is invalid (#25133)
* Adding beta marker (#25256)
* [BeatsCM] error on issues dont disable (#25149)
* display error messages for failed checks vs disableing plugin
* update text
* change order of check
* tweak security check
* re-disable on invalid license, update text
* update text
* tweaks
* tweak text
* Make canvas common lib ready for dependencies static analysis (#24756)
* refact(NA): make canvas common lib ready for static analysis.
* refact(NA): change export named to export all on canvas commmon lib datatable.
* tes(NA): fix isValid http url function name.
* refact(NA): rename parse to parseDataUrl
* Remove extra period for heartbeat add data (#25221)
* [ML] Add user privilege check to Jobs List group selector control (#25225)
* Implement new platform plugin discovery. (#24256)
* Add APM UI to codeowners (#25218)
* [APM] Additional clock skew fixes (#25097)
* Refactor service colors
* Calculate duration from full waterfall
* Ensure timeline label is not truncated
* Adjust child if it starts after parent has ended
* Add mark for traceRootDuration instead of xMax
* Fix tests
* [Infra UI] Work around IE11 flexbox alignment problems (#25224)
This works around some IE11 bugs with flexbox alignment, particularly [Flexbug #4](https://github.com/philipwalton/flexbugs#4-flex-shorthand-declarations-with-unitless-flex-basis-values-are-ignored) and a misinterpretation of the default alignment.
fixes #24758
fixes #24839
fixes #24791
fixes #24757
* Fixes bug with rison decode on Kibana links (#25214)
* Fixes bug with rison decode vs encode
* Adds and updates tests for kibana link component
* remove vis dependency from request handlers (#24119)
* [Infra UI] Remove duplicate "Overview" in detail page title (#25283)
This removes the duplicate word "Overview" from the title of the container details page.
fixes #24160
* Use the newly added remote_cluster field for ccr (#25248)
* [ML] Restore missing job timepicker modal. (#25288)
* [ML] Restore missing job timepicker modal.
* [ML] Added a karma/mocha test to verify dependencies are loaded correctly for new_job_controller.
* [ML] Use consistent import style.
* [DOCS] Adds screenshot for Data Visualizer (#25182)
* Updating request to ^2.88 (#25236)
* Move call to standard index pattern `fields for wildcard` from client to server (#25270)
* [canvas] unify eslint config in .eslintrc.js (#25260)
Simply remove the remaining eslint config files from canvas and merge with other canvas related overrides in `.eslintrc.js`
* [ML] Fixes file data viz file size check and format as bytes (#25295)
* [ML] Fixes file data viz file size check and format as bytes
* [ML] Fix typo in file size error callout
* Fix: Canvas babel build (#25184)
Closes https://github.com/elastic/kibana/issues/25154
Canvas' threading code uses babel-register for the runtime, much like Kibana does, so we can execute code that uses newer syntax (mostly es modules at this point...). The default configuration of babel-register ignores `node_modules`, and since x-pack is built into `node_modules`, this worked fine in dev mode and not at all in the build.
There was also an issue where Kibana's build step removes all bablerc files, which meant Canvas' threaded runtime also wasn't getting any of the settings.
This PR pulls in the configuration from Kibana, which has an exception for transpiling x-pack code, and allows the runtime to operate correctly in the build.
Huge thanks to @jbudz for helping me sort out the issue!
@spalger ~~know more about babel than I do, if we can just use `@kbn/babel-preset/node_preset` directly instead, that seems less likely to break going forward. I meant to try it but ran out of time yesterday to make another build.~~ Works! PR updated.
* [build] Uses node-archive to zip/tar packages (#25031)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
* [canvas] move yarn scripts to node scripts (#25258)
* [canvas] move yarn scripts to node scripts
* [canvas/eslint] allow scripts to access devDeps
* [canvas/eslint] remove packageDir override
* [x-pack] move babel-register to deps for canvas
* [canvas] rename scripts from : to _
* [canvas] update readme with correct script paths
* [canvas] remove yarn.lock file
* Remove redundant require
* Only loading the default index pattern when it's required (#25175)
* [build] make target folder before building packages (#25312)
* Revert "[build] Uses node-archive to zip/tar packages (#25031)" (#25326)
This reverts commit d89cc0ee150207aea5624bf2260c3cdc39981de5.
* [DOCS] Fixes typo in create role API (#25314)
* Fix execution examples for filebeat / metricbeat (#25170)
On windows these binaries are likely not on the path. By using `.\` as a prefix
these commands will correctly execute.
* [migration] Retry attempts for ES service unavailable (#25255)
Resolves a race condition where ES is technically up, but the Kibana
index is not.
Closes #25027
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
* [BeatsCM] text update (#25297)
* progress
* add missing text changes
* text tweak
* Update x-pack/plugins/beats_management/public/components/table/assignment_schema.ts
* fix: restore canvas error dialog
* [Rollups] Fix day of month only showing ordinals (#25322)
* Fix day of month only showing ordinals
* Wait for global loading indicator when creating index pattern (#25329)
* [canvas/gulp-scripts] replace script path in argv with gulp path (#25352)
* [build] Uses node-archive to zip/tar packages (#25335)
Started digging into an issue where compressing library didn't include empty
directories, which tar/zip should. After investigating the issue I feel it's
best to use a more established project.
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
* [migrations] Disable replicas (#25274)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
* Fix Canvas autocomplete to suggest all functions (#25351)
* fix: getFunctionDefinitions to load after the registry has been populated
* fix: use getBrowserRegistries instead of registry itself
* [BeatsCM] Allow for config based override of default user role (#25364)
* Allow for config based override of default user role
* [beats-cm] convert xpack.beats.defaultUserRole to array of roles
* [beats-cm] keep this context in #checkLicense
* Relax hosts validation in Beats central management (#25376)
Current regexp was disallowing schema part of the URL (https://), so
https hosts couldn't be configured.
I opted for fully relaxing the reg exp here, as Beat will check it
anyway, and report errors in case it's wrong.
* Auto open browser on server startup (#24843)
* Adds dev dependency on opn for opening browsers and other things.
* Adds a --open option to cli to open browser window.
* Removes unused variable in index.
* Adds opn types to dev dependencies from definitely typed.
* Adds open to the cliArgs type to allow for consistency.
* Updates snapshots that require valid cliArgs types.
* Moves opn to direct dependency since its used in cli.
* [cli] move --open handling to cluster manager
* Adds support for running --open with --no-base-path
* Fix File Upload fatal (#25361)
## Summary (fixes #25342)
There is a fatal when using the File Upload control in the image upload control. While the fatal appears to originate within the File Upload control, it is actually [coming from](https://github.com/clintandrewhall/kibana/blob/file-upload/x-pack/plugins/canvas/public/components/loading/index.js#L15) `Loading`, which attempts to use `react-redux` to change the `backgroundColor` of the loading indicator based on the page.
I couldn't find an instance where we use this Loading indicator outside of a redux context, so I've opted to simply use the control directly. @rashidkpc agreed this would be a good fix for the moment.
In addition, I fixed a props error coming from the data-url field that made it read-only, so I fixed that, too, as well as a formatting issue with the Set button.
## Test Plan
Added a `setTimeout` call to simulate load. Toggled between data url and literal URL.
- Before
- After
- Fixed Warning
### Checklist
Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.
- [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)
- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~
~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~
~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~
### For maintainers
~~- [] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
* Fix: Asset preservation (#25359)
* fix: proptype error
* fix: correct proptype checking
* fix: add assets placeholder to initial state
* chore: add history formatting function
* fix: load workpad assets when ids change
this causes the correct assets to be used
* [DOCS] Fixes typo in Kibana create role example (#25345)
* EAH - add typescript to a couple of ui/public/utils files (#23946)
* typescriptin a few ui/public
* remove mistaken commits
* typescript numeric
* ts migrateLegacyQuery
* object or string type
* no need for file extension on import statement
* revert mistaken commit
* type fix - only object
* snake case!
* Update EUI to v5.0.0 (#25316)
* update EUI to v5.0.0
* update snapshots
* revert snapshot change
* revert snapshot change (2)
* [DOCS] Adds data visualizer restriction (#25399)
* Using the new ES Realm syntax for SAML (#25223)
* [APM] Fix missing transaction message (#25353)
* [APM] Fix Rison issues (#25377)
* [APM] Fix Rison issues
* Fix CI
* Removed abstractions (and broke tests)
* Slight rework and small bugfix for query param handling
* Removed typo used for visibility testing oops
* Removes unused dep because linting doesnt work apparently
* [DOCS] Adds early draft of Canvas docs (#25395)
* [DOCS] Adds early draft of Canvas docs
* [DOCS] Added images and beta label to Canvas docs
* [DOCS] Clarify security requirements for monitoring (#24881)
* Update "Debugging server code" instructions in CONTRIBUTING.md (#25397)
* Add more details for debugging Kibana server
* add debugging server code to table to contents
* [ML] angularjs controller initialization tests. (#25382)
* [ML] Confirm Modal Controller Test.
* [ML] Message Bar Controller test.
* [ML] Data Visualizer Controller test.
* [ML] Detector Filter Modal Controller test.
* [ML] Detector Modal Controller test.
* [ML] Save Status Modal Controller test.
* [ML] Multi Metric Create Job Controller test.
* [ML] Population Create Job Controller test.
* [ML] Recognize Create Job Controller test.
* [ML] Single Metric Create Job Controller test.
* [ML] Index Or Search Controller test.
* [ML] Job Type Controller test.
* [ML] Angular Bootstrap Patch Dropdown Controller test.
* [ML] Settings Controller test.
* [ML] Calenders List Controller test.
* [ML] New Event Modal Controller test.
* [ML] New Event Modal Controller test.
* [ML] Create Calendar Controller test.
* [ML] Time Series Explorer Controller test.
* [ML] Fixes typo, clearer test name.
* [ML] Fixes tests by restoring stubs.
* [APM] Fix gap in timeline and fallback when traceroot is missing (#25346)
* Fix gap in timeline
* Show fallback when traceroot is unavailable
* Fix test
* Fix rendering issues with styled-components
* Remove `parentTransactionSkew `
* Minor test fixes
* [ML] Updates job type and APM module icon to new designs (#25380)
* [ML] Updates job type and APM module icon to new designs
* [ML] Use self closing tags for icons
* [ML] Removes unnecessary icon from jobs list
* [ML] Fixes the layout of the cards in the Data Visualizer on IE (#25383)
* [DOCS] Updates information regarding usage of sample data indices (#25424)
* Update clickOptionalAddNewButton method used in createIndexPattern (#25414)
* Wrap long field names in Rollup Job Wizard tables. (#25405)
* Upgrading grunt-contrib-watch (#22818)
* [APM] Format as microseconds (#24974)
* [APM] Format as microseconds
* Split interface into `value` and `options`
* Update formatters.test.ts
* [APM] Minor cleanup of constants (#25177)
* [APM] Minor cleanup of constants
* Simplify constants test
* fix: get correct plugins path (#25448)
we can't check the name of the outer path because it can change, instead, just make sure there's a plugins path there
* Fix non-conforming licenses on devDependencies and add the ability to whitelisting devOnly licenses (#23859)
* chore(19834): upgraded yargs dependency to 4.8.1 in order to remove pkg-conf dependency license conflict.
* chore(19834): override xmldom to one of the allowed licenses (MIT).
* chore(19834): added some overrides and whitelistenig for Apache2.
* chore(19834): correct overides for some apache2 licenses.
* chore(NA): updated specific dependency needs.
* chore(19834): added some more info on updated licenses.
* chore(19834): small note on dependencies use versions.
* feat(NA): add the ability to white list licenses only valid for dev only dependencies.
* chore(NA): update yarn lock files to include integrity check.
* fix(NA): yarn lock file for kbn ui framework.
* docs(NA): fix uncompleted comment left on the code.
* [Tools] Add string concatenation parsing (#25381)
* Docs/canvas get started (#25476)
* edits to canvas getting started docs
* edit to canvas workpad docs
* [DOCS] Refreshes ML job creation screenshots (#25417)
* [DOCS] Adds docs for managing, creating, and visualizing rollups (#25450)
* [DOCS] Adds docs for managing, creating, and visualizing rollups
* [DOCS] Fixed broken link]
* [DOCS] Updates docs based on review feedback
* Fix: Quote the index pattern in SQL input (#25488)
SQL requires that you quote the index name if you are using special characters (like *, with an index pattern). Our default value didn't work since `logstash*` was not quoted.
### Before
### After
...and if you select some valid fields so you don't get an array in the results:
* [ui] default to k7Design in releases (#25487)
* [ui] default to k7Design in releases
* [ci] don't build in release mode for testing
* [ci] run SNAPSHOT build
* Only set timeout when larger 0 in timelion (#25461)
* logo updates for marketing (#25489)
* [kbn-pm] Use yarn workspaces for dependencies (#24095)
* Run jenkins:unit task with dev flag in order to run license check (#19832)
* chore(19674): added dev flag when calling jenkins:unit grunt task so we can check dev licenses on ours ci jobs.
* chore(NA): update yarn lock files with integrity info.
* [Flaky test fix] Turn back on data_shared_attributes test (#25156)
* Turn back on data_shared_attributes test and run 20x
* Add some clean up
* Be more determinism, less refactoring.
* Go back to a single test run
* [ci] define matrix axes in code (#25360)
* [ci] define matrix axes in code
* [ci] add null exclude rule
* [ci] make script executable
* [ci] execute sub-scripts
* [ci] simplify job variable name
* fix(NA): recent unconforming licenses. (#25560)
* [canvas] Improve plugin pre-build (#25267)
Fixes https://github.com/elastic/kibana/issues/23552
Extends the webpack config used to pre-build `x-pack/plugins/canvas/canvas_plugins_src` so that it does a couple things:
- use the "browser" and "main" fields when defined by packages, this allows the already transpiled output of packages like `@elastic/eui` to be used rather than rebuilding from source
- use the `@kbn/babel-preset/webpack_preset` for babel-loader
- include all errors in the log output when an error occurs
* Fixes duplicate 'Value' options in math function select (#25556)
* [Canvas] Decrease size of tray toggle (#25470)
* decrease size of toggle bar
* change bg colors for toggle
* Adds UI notification for dropped spans (#25017)
* Adds icon and tooltip for dropped spans
* Adds callout and style in transaction flyout instead of timeline for dropped spans message
* Review tweaks and linting fixes
* [I18n] Translate Timelion (#23880)
* Add translations for timelion plugin
* Fix bugs
* Fix messages ids, resolve comments
* Update translations
* Refactor links messages
* Fix values bug
* Use template literals to avoid single quote escaping
* [Tools] Validate values in nested ICU messages (#25378)
* [i18n] Translations for Monitoring: Logstash (#24897)
* Translate Monitoring logstash
* Fix a typo
* Update unit tests
* [DOCS] Adds known limitation for exporting a data table (#25561)
* disable flaky test
* handle EuiSearchBar query parse failures (#25235)
* handle EuiSearchBar query parse failures
* I18n parse failure messages
* review updates
* more cleanup on settings search.test
* Fix paths to the i18n enzyme helpers in monitoring tests. (#25593)
* Updated package.json and yarn.lock.
* Fixes index pattern wizard when there are remote clusters but no local indices (#24339)
* don't hide wizard if clusters exist
* catch errors
* add toast notifs if unable to load data
* [kbn-plugin-generator] add reference to es script in Kibana (#25607)
* [kbn-plugin-generator] gitignore app.css if scss used (#25609)
When generating a plugin with the plugin generator and scss is in use, we should add the generated `app.css` file to the .gitignore file.
* [DOCS] Saved object migrations (#25558)
* Add a note about index migrations to the kibana setup docs
* Tewak the migrations asciidocs for clarity
* docs: refine saved object migration details
Breaking down the migration process into sections helps people find
and link to relevant information more easily.
The focus is on ongoing maintenance of Kibana, whereas the initial new
experience in 6.5.0 is treated as a note of clarification.
Error handling should be expanded in the future to include details about
specific known error cases.
* [es-test-cluster] increase start timeout for snapshots (#25600)
* [Bug] Fixing flash of unstyled dashboard content (#25559)
Fixes #25375
* Feature/translate monitoring table (#24973)
* Translate monitoring -> summary_status, table, main.html in directives
* Fix issues
* Fix tests
* Add disable eslint for unused var intl
* Combine common pdf png functions (#25152)
* Create common routines for PDF and PNG report processing
* REmove Blacklisted headers not needed
* Changes for issues with PDF and PNG testing
As per Joel Griffith suggestion I added removal of toast notifications after each click download report. And removed setting of image density to 300.
* removed uneccesary image compare routine
* Moved server from property on job to passed in parameter.
* consolidated PDF and PNG testing
Moved test code from PDF and PNG index.test.js into a common index.test.js that now tests the common functions.
* Typescripted the common functions and broke out tests to individual test files
* Create a common create mock server function that all new tests call
* Removed unnecessary exception check and removed test include from index.ts
* Add href option in addition to onClick (#25233)
* Add href option in addition to onClick
* Small modificationd and adding tests
* Add missing import
* Switch order of tests
* Don't close panel menu again
* Feature/translate monitoring license (#24826)
* Translate monitoring -> license
* Translate monitoring -> page_loading
* Translate monitoring -> no_data
* Fix issues
* Update unit tests
* Fix eslint
* TSVB less to sass - and some UI work (#24250)
Fixes #16483, Fixes #20115, Fixes #17852, Fixes #16768, Fixes #14348, Fixes #17842, closes #15580, closes #14938
* Fix: IE11 compat (#25562)
* fix: switch to new CustomEvent
new Event is not supported in IE11
* fix: skip element.scrollTo when not available
that method doesn't exist on elements in IE11
* Make gulp canvas:test work (#25492)
* Remove experimental flag from TSVB (#25634)
* Revert "Feature/translate canvas plugin src elements (#23755)" (#25662)
This reverts commit f10deb1b8a72aea6dd408d95e17ec74482cce566.
* Some updates to fix context tests.
* Final fixes for context tests.
* Removed some unused imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #25143
PR updates Saved Objects management page and Advanced Settings management page to handle query parse failures
Checklist
- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers