Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended stats Agg #2601

Merged
merged 16 commits into from
Jan 19, 2015
Merged

Extended stats Agg #2601

merged 16 commits into from
Jan 19, 2015

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jan 9, 2015

Added the extended stats agg, which includes the ability to choose which of the extended stats you want (count, min, max, avg, sum, sum_of_squares, variance, std_deviation) Closes #541

image

@rashidkpc rashidkpc modified the milestone: 4.0.0-RC1 Jan 13, 2015
@rashidkpc
Copy link
Contributor

@spenceralger is this ready for review?

@rashidkpc
Copy link
Contributor

When I click to remove a metric it turns black, which doesn't really seem to do anything?

image

Also, it wasn't totally obvious how to get a removed item back. I now see that its a select2 input. Maybe we could add a plus button or something?

@rashidkpc rashidkpc assigned spalger and unassigned rashidkpc Jan 15, 2015
@spalger
Copy link
Contributor Author

spalger commented Jan 15, 2015

@rashidkpc fixed by replacing with checkboxes

@spalger spalger force-pushed the extendedStats branch 2 times, most recently from 1ad1bcb to 4a48fb3 Compare January 16, 2015 02:54
@spalger
Copy link
Contributor Author

spalger commented Jan 16, 2015

@rashidkpc refined UX a bit more.

  • displays error count above the apply button
  • extended FormController, adding form.describeErrors() which returns something like 3 Errors
  • extended NgModelController to force inputs (and in turn forms) to become dirty when the model moves from valid to invalid state.

@spalger spalger assigned rashidkpc and unassigned spalger Jan 16, 2015
@spalger spalger force-pushed the extendedStats branch 2 times, most recently from 52e41e4 to 5e21a29 Compare January 16, 2015 19:43
@spalger spalger assigned spalger and w33ble and unassigned rashidkpc and spalger Jan 16, 2015
@w33ble
Copy link
Contributor

w33ble commented Jan 16, 2015

I'm guessing that, given this cryptic Java error, that this should only work on numeric fields.

ClassCastException[org.elasticsearch.index.fielddata.plain.PagedBytesIndexFieldData cannot be cast to org.elasticsearch.index.fielddata.IndexNumericFieldData]

2015-01-16 13_14_22

@w33ble w33ble assigned spalger and unassigned w33ble Jan 16, 2015
@spalger spalger assigned w33ble and unassigned spalger Jan 16, 2015
w33ble added a commit that referenced this pull request Jan 19, 2015
@w33ble w33ble merged commit bcb6dd9 into elastic:master Jan 19, 2015
@spalger spalger mentioned this pull request Jan 19, 2015
4 tasks
@jwalton
Copy link

jwalton commented Jan 19, 2015

#1536 was closed by this, and #199 was closed by #1536, but I don't understand how this addresses #199.

Let's say I have a node.js process which are all logging out their process.memoryUsage() once a minute. So I have a bunch of log entries that have rss, heapTotal, and heapUsed fields. Can I plot all three of these to a single graph? This is what #199 was asking for.

Or, let's suppose I have a bunch of node.js processes which are all logging {pid, heapUsed} objects - can I plot one series for each PID? This would be amazing.

Since #199 was a pretty popular issue, if this doesn't address these points, #199 should probably be re-opened.

@spalger
Copy link
Contributor Author

spalger commented Jan 21, 2015

@jwalton you can definitely do this the latest master.

Case 1:
to plot rss, heapTotal, and headUsed over time you would probably want to start with a line or bar chart. Then create three metric aggregations calculating the average of each field you are interested in. Then you could create a single bucket aggregation, using a date_histogram on your timestamp field.

Here is what that would look like in the visualize editor:
image

Case 2:
First, setup a chart as described in Case 1. Then, add pid to the mix by adding a sub-aggregation under the date_histogram using the terms aggregation on the pid field.

Hope that helps!

@spalger spalger deleted the extendedStats branch February 9, 2015 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

histogram or terms table with standard deviation
4 participants