Specifying the timeout for the _msearch in the body #26446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobelb
changed the title
Contributor
Author
|
@jasontedor when you determine whether or not this was supported, but deprecated in 6.x, would you mind letting us know so we know how far to backport this? |
Contributor
💔 Build Failed |
cjcenizal
approved these changes
Nov 30, 2018
Contributor
cjcenizal
left a comment
cjcenizal
left a comment
There was a problem hiding this comment.
LGTM, code review only.
Contributor
💔 Build Failed |
Member
This use of |
kobelb
added a commit
to kobelb/kibana
that referenced
this pull request
Dec 3, 2018
* Specifying the timeout for the msearch in the body * Revert "Specifying the timeout for the msearch in the body" This reverts commit 7b07bfa. * Fixing the courier and the index pattern execute script timeouts
kobelb
added a commit
to kobelb/kibana
that referenced
this pull request
Dec 3, 2018
* Specifying the timeout for the msearch in the body * Revert "Specifying the timeout for the msearch in the body" This reverts commit 7b07bfa. * Fixing the courier and the index pattern execute script timeouts
Contributor
💔 Build Failed |
kobelb
added a commit
that referenced
this pull request
Dec 3, 2018
kobelb
added a commit
that referenced
this pull request
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_msearchAPI in ES master is returning a 400/bad-request when specifying the timeout in the header without units. This PR moves this parameter to the search body.At this moment, it's unknown how far this should be backported... it's possible that the parameter that we're specifying in the header on 6.x (and potentially earlier) is simply being ignored.
"Release Note: Resolving issue with the _msearch timeouts being specified incorrectly, which was causing them to be ignored."