Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes page thumbnail sizes #26573

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Fixes page thumbnail sizes #26573

merged 1 commit into from
Dec 4, 2018

Conversation

cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Dec 3, 2018

Closes #26562.

Classes were moved and messed up styles in the page manager. This applies the classes to the correct div to restore the original styling of the page thumbnails.
screen shot 2018-12-03 at 2 12 03 pm

@cqliu1 cqliu1 added v7.0.0 Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v6.6.0 labels Dec 3, 2018
@cqliu1 cqliu1 requested a review from w33ble December 3, 2018 21:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@cqliu1 cqliu1 added the review label Dec 4, 2018
Copy link
Contributor

@w33ble w33ble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, page manager works again, even with the K7 design enabled.

@cqliu1 cqliu1 merged commit 53b8b9a into elastic:master Dec 4, 2018
@cqliu1 cqliu1 deleted the fix/page-preview branch December 4, 2018 21:14
cqliu1 added a commit to cqliu1/kibana that referenced this pull request Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v6.6.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants