Add new "references" attribute to saved objects for relationships #28199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecote
added
WIP
|
Pinging @elastic/kibana-platform |
This comment has been minimized.
This comment has been minimized.
mikecote
force-pushed
the
add-references
branch
from
944bafb to
533fe26
Compare
This comment has been minimized.
This comment has been minimized.
mikecote
force-pushed
the
add-references
branch
from
8cfc569 to
c666d91
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mikecote
force-pushed
the
add-references
branch
from
65a78c1 to
e7c7735
Compare
This comment has been minimized.
This comment has been minimized.
mikecote
force-pushed
the
add-references
branch
from
e7c7735 to
f2cf1e5
Compare
This comment has been minimized.
This comment has been minimized.
mikecote
force-pushed
the
add-references
branch
from
f2cf1e5 to
bf3b9fb
Compare
This comment has been minimized.
This comment has been minimized.
spalger
reviewed
Jan 9, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
spalger
approved these changes
Jan 30, 2019
src/legacy/core_plugins/kibana/public/dashboard/saved_dashboard/saved_dashboard_references.js
Show resolved
Hide resolved
src/legacy/core_plugins/kibana/server/lib/management/saved_objects/relationships.js
Outdated
Show resolved
Hide resolved
src/legacy/core_plugins/kibana/server/routes/api/management/saved_objects/relationships.js
Outdated
Show resolved
Hide resolved
src/legacy/core_plugins/kibana/server/lib/export/collect_references_deep.ts
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💚 Build Succeeded |
|
This is a breaking change, right? Can you add the breaking change label and update the breaking change documentation? |
|
@epixa correct, I will update the documentation 👍 |
💚 Build Succeeded |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #28377
Fixes #27210
This implements the saved object relationships proposed here #27210.
A new attribute is added to the saved objects structure called
references. This is an array of{type, id, name}that will contain all external references a given saved object has.The saved object courier class will add index patterns to the references array and have pre save / post read hooks allow injecting and extracting references for the new array.
Converted apps include: dashboard, visualization, search and graph.
Other changes in this PR
{ searches: [] }becomes{ search: [] })extractReferencesandinjectReferencescapabilities to the saved object UI class.