[CSV export] date values formatted properly #29781
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
requested review from
spalger,
joelgriffith,
stacey-gammon,
Bargs and
lukasolson
💔 Build Failed |
tsullivan
force-pushed
the
fix/reporting-csv-tz
branch
from
2a79f92 to
11bd01a
Compare
joelgriffith
approved these changes
Feb 1, 2019
💔 Build Failed |
|
This broke the date formatting in Discover. It needs a different fix |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #29463
createDateFormatin core_plugins/kibana/common/field_formats/types/date.js was not incorporating time zone when formatting a date withmomentQuestion: was there no other Kibana feature using
createDateFormat?