Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add breaking changes documentation for references PR #29963

Merged
merged 7 commits into from
Feb 6, 2019
Merged

Add breaking changes documentation for references PR #29963

merged 7 commits into from
Feb 6, 2019

Conversation

mikecote
Copy link
Contributor

@mikecote mikecote commented Feb 4, 2019

This adds missing breaking changes documentation for PR #28199.

@mikecote mikecote added WIP Work in progress Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.0.0 labels Feb 4, 2019
@mikecote mikecote self-assigned this Feb 4, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@epixa epixa added the Team:Docs label Feb 4, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@mikecote mikecote added review and removed WIP Work in progress labels Feb 5, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@mikecote mikecote requested a review from spalger February 5, 2019 21:25
spalger
spalger approved these changes Feb 6, 2019
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure the /api/kibana/management/saved_objects/relationships/{type}/{id} is not documented elsewhere, so lets remove it from this doc and just leave the "Saved object structure change" section.

@epixa
Copy link
Contributor

epixa commented Feb 6, 2019

I agree with @spalger

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@mikecote mikecote merged commit 9bee5b1 into elastic:master Feb 6, 2019
mikecote added a commit to mikecote/kibana that referenced this pull request Feb 6, 2019
@mikecote
Add breaking changes documentation for references PR (elastic#29963)
4ea34f1 
* Initial draft of breaking changes

* Add object structure change

* Make id attribute match

* Fix attribute name

* Remove relationships API notes
@mikecote mikecote mentioned this pull request Feb 6, 2019
Merged
@mikecote mikecote mentioned this pull request Feb 6, 2019
Merged
mikecote added a commit that referenced this pull request Feb 6, 2019
@mikecote
Add breaking changes documentation for references PR (#29963) (#30252)
c596740 
* Initial draft of breaking changes

* Add object structure change

* Make id attribute match

* Fix attribute name

* Remove relationships API notes
mikecote added a commit to mikecote/kibana that referenced this pull request Feb 8, 2019
@mikecote
Add breaking changes documentation for references PR (elastic#29963)
7b4f411 
* Initial draft of breaking changes

* Add object structure change

* Make id attribute match

* Fix attribute name

* Remove relationships API notes
mikecote added a commit that referenced this pull request Feb 10, 2019
@mikecote
Add breaking changes documentation for references PR (#29963) (#30257)
86d7235 
* Initial draft of breaking changes

* Add object structure change

* Make id attribute match

* Fix attribute name

* Remove relationships API notes
@mikecote mikecote added the non-issue Indicates to automation that a pull request should not appear in the release notes label Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger Awaiting requested review from spalger

Assignees

@mikecote mikecote

Labels
non-issue Indicates to automation that a pull request should not appear in the release notes review Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Docs v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikecote @elasticmachine @epixa @spalger