Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jest/integration] set default test timeout to 30 seconds #33718

Merged
merged 2 commits into from
Mar 22, 2019
Merged

[jest/integration] set default test timeout to 30 seconds #33718

merged 2 commits into from
Mar 22, 2019

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Mar 22, 2019

We introduced the jest integration test suite in #16735, which is intended for tests that integrate with different components and are likely to take a little longer than other tests. We didn't change the default timeout, which is 5 seconds, probably because there isn't a simple option for this, but the jest docs at https://jestjs.io/docs/en/jest-object#jestsettimeouttimeout recommend putting this in in a setup file:

Note: The method must be called after the test framework is installed in the environment and before the test runs. A good place to do this is in the setupTestFrameworkScriptFile.

From https://jestjs.io/docs/en/configuration#setupfilesafterenv-array:

Note: setupTestFrameworkScriptFile is deprecated in favor of setupFilesAfterEnv.

@spalger spalger requested a review from azasypkin March 22, 2019 16:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@spalger spalger added the review label Mar 22, 2019
azasypkin
azasypkin approved these changes Mar 22, 2019
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

src/dev/jest/setup_after_env.integration.js Outdated Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger spalger merged commit 96c39b6 into elastic:master Mar 22, 2019
spalger pushed a commit to spalger/kibana that referenced this pull request Mar 22, 2019
[jest/integration] set default test timeout to 30 seconds (elastic#33718
50a3bcf 
)

* [jest/integration] set default test timeout to 30 seconds

* move into dev/jest/setup directory
This was referenced Mar 22, 2019
Merged
Merged
spalger pushed a commit to spalger/kibana that referenced this pull request Mar 22, 2019
[jest/integration] set default test timeout to 30 seconds (elastic#33718
c3f0b68 
)

* [jest/integration] set default test timeout to 30 seconds

* move into dev/jest/setup directory
spalger pushed a commit that referenced this pull request Mar 22, 2019
[7.0] [jest/integration] set default test timeout to 30 seconds (#33718…
3378a53 
…) (#33749)

Backports the following commits to 7.0:
 - [jest/integration] set default test timeout to 30 seconds  (#33718)
spalger pushed a commit that referenced this pull request Mar 22, 2019
[jest/integration] set default test timeout to 30 seconds (#33718) (#…
0b83d02 
…33748)

* [jest/integration] set default test timeout to 30 seconds

* move into dev/jest/setup directory
@spalger
Copy link
Contributor Author

spalger commented Mar 22, 2019

7.x/7.1: 0b83d02
7.0: 3378a53

@spalger spalger deleted the implement/jest-integration-default-timeout branch March 22, 2019 23:11
joelgriffith pushed a commit that referenced this pull request Mar 27, 2019
[jest/integration] set default test timeout to 30 seconds (#33718)
2d3f443 
* [jest/integration] set default test timeout to 30 seconds

* move into dev/jest/setup directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

@azasypkin azasypkin azasypkin approved these changes

Assignees
No one assigned
Labels
review Team:Operations Team label for Operations Team test-jest-integration v7.0.0 v7.2.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spalger @elasticmachine @azasypkin @jbudz