Add Data UI for CoreDNS Metricbeat Module #33845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Mark <chrismarkou92@gmail.com>
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
Screenshot: |
|
jenkins, test this |
💚 Build Succeeded |
|
@ChrsMark Do you want to open an issue in https://github.com/elastic/eui to get the logo added? |
|
@ruflin, issue opened! |
ruflin
approved these changes
Mar 27, 2019
| } | ||
| }, | ||
| completionTimeMinutes: 10, | ||
| // previewImagePath: '/plugins/kibana/home/tutorial_resources/coredns_metrics/screenshot.png', |
There was a problem hiding this comment.
we need to update this as soon as we have the dashboard in.
joelgriffith
pushed a commit
that referenced
this pull request
Mar 27, 2019
Signed-off-by: Chris Mark <chrismarkou92@gmail.com>
ruflin
added a commit
that referenced
this pull request
Mar 28, 2019
Backports the following commits to 7.x: - Add Data UI for CoreDNS Metricbeat Module (#33845)
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add Data UI PR for CoreDNS Metricbeat module. It misses the logo, however it's configured using a name that seems to follow other icon conventions
logoCoreDNS.This PR is part of elastic/beats#10432.
cc: @ruflin