Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create filter from table if a link is clicked #3799

Merged
merged 2 commits into from
May 12, 2015

Conversation

lukasolson
Copy link
Member

Prior to this PR, clicking on a link inside of a data table would have two results: The link would be opened in a new tab, and a filter would be added.

This PR checks if the target is a link, and only creates a filter if it is not a link. Filters can still be added for rows with links by clicking elsewhere in the row outside of the link.

Closes #3781.

@rashidkpc
Copy link
Contributor

I'm thinking 4.1 on this one. I think the issue was marked 4.2 because we didn't think we'd be able to get to it.

@rashidkpc
Copy link
Contributor

We should probably discuss if we should stick filter buttons or something in the blank space, it feels a bit weird to click somewhere off of the text to get a filter

@w33ble
Copy link
Contributor

w33ble commented May 11, 2015

Functional, looks good. I'm wondering if it would be better to test for an href instead of just an anchor tag. Probably rare, but there could be a case where we have an anchor without an href that we still want to apply a filter with. If that sounds silly though, then this is GTG! 🐾

@w33ble w33ble assigned rashidkpc and unassigned w33ble May 11, 2015
@w33ble
Copy link
Contributor

w33ble commented May 11, 2015

@lukasolson as discussed, we want to distinguish what's going on with different cursors. Can you slap a cursor: cell or similar on the filterable cell - I think cell-hover is the class you want.

2015-05-11 15_48_45

@w33ble w33ble assigned lukasolson and unassigned rashidkpc May 11, 2015
@lukasolson lukasolson assigned w33ble and unassigned lukasolson May 12, 2015
@w33ble
Copy link
Contributor

w33ble commented May 12, 2015

Let's take this PR down to merge town! 🐳

w33ble added a commit that referenced this pull request May 12, 2015
Don't create filter from table if a link is clicked
@w33ble w33ble merged commit c068f3f into elastic:master May 12, 2015
@lukasolson lukasolson deleted the issues/3781 branch February 11, 2016 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hyperlinks in Data Tables
3 participants