From c2b00cf66e1d8fd8962bd00fc199a2f66cb6bcaf Mon Sep 17 00:00:00 2001 From: Joe Reuter Date: Tue, 25 Jun 2019 17:12:32 +0200 Subject: [PATCH 1/7] add basic layout --- .../plugins/lens/public/app_plugin/app.tsx | 6 +- .../editor_frame/editor_frame.scss | 1 + .../editor_frame/frame_layout.scss | 73 +++++++++++++++++++ .../editor_frame/frame_layout.tsx | 17 +++-- .../editor_frame/workspace_panel.tsx | 27 ++++++- x-pack/legacy/plugins/lens/public/index.scss | 3 +- .../native_renderer/native_renderer.tsx | 7 +- 7 files changed, 113 insertions(+), 21 deletions(-) create mode 100644 x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/editor_frame.scss create mode 100644 x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/frame_layout.scss diff --git a/x-pack/legacy/plugins/lens/public/app_plugin/app.tsx b/x-pack/legacy/plugins/lens/public/app_plugin/app.tsx index 16860142e28d0..0e469dbeb5634 100644 --- a/x-pack/legacy/plugins/lens/public/app_plugin/app.tsx +++ b/x-pack/legacy/plugins/lens/public/app_plugin/app.tsx @@ -13,11 +13,7 @@ import { NativeRenderer } from '../native_renderer'; export function App({ editorFrame }: { editorFrame: EditorFrameInstance }) { return ( -
-

Lens

- - -
+ ); } diff --git a/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/editor_frame.scss b/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/editor_frame.scss new file mode 100644 index 0000000000000..8165e40810ec2 --- /dev/null +++ b/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/editor_frame.scss @@ -0,0 +1 @@ +@import './frame_layout.scss'; \ No newline at end of file diff --git a/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/frame_layout.scss b/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/frame_layout.scss new file mode 100644 index 0000000000000..3c84227ab45f0 --- /dev/null +++ b/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/frame_layout.scss @@ -0,0 +1,73 @@ +.lnsPage { + padding: 0; + position: absolute; + top: 0; + left: 0; + right: 0; + bottom: 0; + overflow: hidden; +} + +.lnsSidebar { + margin: 0; + flex: 1 0 18%; + min-width: ($euiSize * 16); + height: 100%; + display: flex; + flex-direction: column; + overflow: hidden; + + > .lnsSidebar__padding { + padding: $euiSize; + + + .lnsSidebar__padding { + padding-top: 0; + } + } +} + +.lnsSidebar--right { + @include euiScrollBar; + overflow: hidden auto; + padding: $euiSize; + min-width: ($euiSize * 18); +} + +.lnsPageBody { + @include euiScrollBar; + padding-top: $euiSize; + padding-bottom: $euiSize; + overflow: hidden auto; + + &:first-child { + padding-left: $euiSize; + } + + .lnsPageContent { + padding: 0 !important; + display: flex; + flex-direction: column; + + .lnsPageContentHeader { + padding: $euiSize; + border-bottom: $euiBorderThin; + margin-bottom: 0 !important; + } + + .lnsPageContentBody { + flex-grow: 1; + padding: $euiSizeXL; + display: flex; + align-items: stretch; + justify-content: stretch; + + > * { + flex: 1 1 100%; + display: flex; + align-items: center; + justify-content: center; + overflow-x: hidden; + } + } + } +} \ No newline at end of file diff --git a/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/frame_layout.tsx b/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/frame_layout.tsx index cae1b6b90ccd9..c886e86f42004 100644 --- a/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/frame_layout.tsx +++ b/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/frame_layout.tsx @@ -5,7 +5,7 @@ */ import React from 'react'; -import { EuiFlexGroup, EuiFlexItem } from '@elastic/eui'; +import { EuiPage, EuiPageSideBar, EuiPageBody, EuiPageContent } from '@elastic/eui'; import { RootDragDropProvider } from '../../drag_drop'; export interface FrameLayoutProps { @@ -18,15 +18,16 @@ export interface FrameLayoutProps { export function FrameLayout(props: FrameLayoutProps) { return ( - - {/* TODO style this and add workspace prop and loading flags */} - {props.dataPanel} - {props.workspacePanel} - + + {props.dataPanel} + + {props.workspacePanel} + + {props.configPanel} {props.suggestionsPanel} - - + + ); } diff --git a/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/workspace_panel.tsx b/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/workspace_panel.tsx index dc9b5ffce6b49..777cf2dc6ebfc 100644 --- a/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/workspace_panel.tsx +++ b/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/workspace_panel.tsx @@ -6,7 +6,15 @@ import React, { useState, useEffect, useMemo } from 'react'; import { FormattedMessage } from '@kbn/i18n/react'; -import { EuiCodeBlock, EuiSpacer } from '@elastic/eui'; +import { + EuiCodeBlock, + EuiSpacer, + EuiPageContent, + EuiPageContentHeader, + EuiPageContentHeaderSection, + EuiTitle, + EuiPageContentBody, +} from '@elastic/eui'; import { toExpression } from '@kbn/interpreter/common'; import { ExpressionRenderer } from '../../../../../../../src/legacy/core_plugins/data/public'; @@ -147,8 +155,19 @@ export function WorkspacePanel({ } return ( - - {renderVisualization()} - + + + + +

New Visualization

+ + + + + + {renderVisualization()} + + + ); } diff --git a/x-pack/legacy/plugins/lens/public/index.scss b/x-pack/legacy/plugins/lens/public/index.scss index 6e5372e233a0d..4992b9a150493 100644 --- a/x-pack/legacy/plugins/lens/public/index.scss +++ b/x-pack/legacy/plugins/lens/public/index.scss @@ -3,4 +3,5 @@ @import './drag_drop/drag_drop.scss'; @import './xy_visualization_plugin/xy_expression.scss'; -@import './indexpattern_plugin/indexpattern'; \ No newline at end of file +@import './indexpattern_plugin/indexpattern'; +@import './editor_frame_plugin/editor_frame/editor_frame.scss'; \ No newline at end of file diff --git a/x-pack/legacy/plugins/lens/public/native_renderer/native_renderer.tsx b/x-pack/legacy/plugins/lens/public/native_renderer/native_renderer.tsx index 3bc042660e646..08464dd65f67e 100644 --- a/x-pack/legacy/plugins/lens/public/native_renderer/native_renderer.tsx +++ b/x-pack/legacy/plugins/lens/public/native_renderer/native_renderer.tsx @@ -4,9 +4,9 @@ * you may not use this file except in compliance with the Elastic License. */ -import React from 'react'; +import React, { HTMLAttributes } from 'react'; -export interface NativeRendererProps { +export interface NativeRendererProps extends HTMLAttributes { render: (domElement: Element, props: T) => void; nativeProps: T; tag?: string; @@ -20,8 +20,9 @@ export interface NativeRendererProps { * * @param props */ -export function NativeRenderer({ render, nativeProps, tag }: NativeRendererProps) { +export function NativeRenderer({ render, nativeProps, tag, ...rest }: NativeRendererProps) { return React.createElement(tag || 'div', { + ...rest, ref: el => el && render(el, nativeProps), }); } From 754b29f7ac432c7e5d85ef79e0faf04f4ec7ffab Mon Sep 17 00:00:00 2001 From: Joe Reuter Date: Tue, 25 Jun 2019 17:37:33 +0200 Subject: [PATCH 2/7] fix basic styling issues --- .../expressions/expression_renderer.tsx | 3 + .../editor_frame/editor_frame.scss | 75 ++++++++++++++++++- .../editor_frame/frame_layout.scss | 73 ------------------ .../editor_frame/workspace_panel.tsx | 8 +- .../xy_expression.scss | 3 +- 5 files changed, 83 insertions(+), 79 deletions(-) delete mode 100644 x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/frame_layout.scss diff --git a/src/legacy/core_plugins/data/public/expressions/expression_renderer.tsx b/src/legacy/core_plugins/data/public/expressions/expression_renderer.tsx index 78fb43772504c..9c6443e8a254d 100644 --- a/src/legacy/core_plugins/data/public/expressions/expression_renderer.tsx +++ b/src/legacy/core_plugins/data/public/expressions/expression_renderer.tsx @@ -37,6 +37,7 @@ export type ExpressionRendererProps = Pick< * this callback is called with the given result. */ onRenderFailure?: (result: Result) => void; + className?: string; }; export type ExpressionRenderer = React.FC; @@ -44,6 +45,7 @@ export type ExpressionRenderer = React.FC; export const createRenderer = (run: ExpressionRunner): ExpressionRenderer => ({ expression, onRenderFailure, + className, ...options }: ExpressionRendererProps) => { const mountpoint: React.MutableRefObject = useRef(null); @@ -63,6 +65,7 @@ export const createRenderer = (run: ExpressionRunner): ExpressionRenderer => ({ return (
{ mountpoint.current = el; }} diff --git a/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/editor_frame.scss b/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/editor_frame.scss index 8165e40810ec2..7be94d3a68545 100644 --- a/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/editor_frame.scss +++ b/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/editor_frame.scss @@ -1 +1,74 @@ -@import './frame_layout.scss'; \ No newline at end of file +.lnsPage { + padding: 0; + position: absolute; + top: 0; + left: 0; + right: 0; + bottom: 0; + overflow: hidden; +} + +.lnsSidebar { + margin: 0; + flex: 1 0 18%; + min-width: ($euiSize * 16); + height: 100%; + display: flex; + flex-direction: column; + overflow: hidden; +} + +.lnsSidebar--right { + @include euiScrollBar; + overflow: hidden auto; + padding: $euiSize; + min-width: ($euiSize * 18); +} + +.lnsPageBody { + @include euiScrollBar; + padding-top: $euiSize; + padding-bottom: $euiSize; + overflow: hidden auto; + + &:first-child { + padding-left: $euiSize; + } + + .lnsPageContent { + padding: 0 !important; + display: flex; + flex-direction: column; + + .lnsPageContentHeader { + padding: $euiSize; + border-bottom: $euiBorderThin; + margin-bottom: 0 !important; + } + + .lnsPageContentBody { + flex-grow: 1; + padding: $euiSizeXL; + display: flex; + align-items: stretch; + justify-content: stretch; + + > * { + flex: 1 1 100%; + display: flex; + align-items: center; + justify-content: center; + overflow-x: hidden; + } + } + } +} + +.lnsExpressionOutput { + width: 100%; + height: 100%; + display: flex; + align-items: center; + justify-content: center; + overflow-x: hidden; +} diff --git a/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/frame_layout.scss b/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/frame_layout.scss deleted file mode 100644 index 3c84227ab45f0..0000000000000 --- a/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/frame_layout.scss +++ /dev/null @@ -1,73 +0,0 @@ -.lnsPage { - padding: 0; - position: absolute; - top: 0; - left: 0; - right: 0; - bottom: 0; - overflow: hidden; -} - -.lnsSidebar { - margin: 0; - flex: 1 0 18%; - min-width: ($euiSize * 16); - height: 100%; - display: flex; - flex-direction: column; - overflow: hidden; - - > .lnsSidebar__padding { - padding: $euiSize; - - + .lnsSidebar__padding { - padding-top: 0; - } - } -} - -.lnsSidebar--right { - @include euiScrollBar; - overflow: hidden auto; - padding: $euiSize; - min-width: ($euiSize * 18); -} - -.lnsPageBody { - @include euiScrollBar; - padding-top: $euiSize; - padding-bottom: $euiSize; - overflow: hidden auto; - - &:first-child { - padding-left: $euiSize; - } - - .lnsPageContent { - padding: 0 !important; - display: flex; - flex-direction: column; - - .lnsPageContentHeader { - padding: $euiSize; - border-bottom: $euiBorderThin; - margin-bottom: 0 !important; - } - - .lnsPageContentBody { - flex-grow: 1; - padding: $euiSizeXL; - display: flex; - align-items: stretch; - justify-content: stretch; - - > * { - flex: 1 1 100%; - display: flex; - align-items: center; - justify-content: center; - overflow-x: hidden; - } - } - } -} \ No newline at end of file diff --git a/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/workspace_panel.tsx b/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/workspace_panel.tsx index 777cf2dc6ebfc..7a0017d83ad3a 100644 --- a/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/workspace_panel.tsx +++ b/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/workspace_panel.tsx @@ -4,7 +4,7 @@ * you may not use this file except in compliance with the Elastic License. */ -import React, { useState, useEffect, useMemo } from 'react'; +import React, { useState, useEffect, useMemo, useContext } from 'react'; import { FormattedMessage } from '@kbn/i18n/react'; import { EuiCodeBlock, @@ -20,7 +20,7 @@ import { toExpression } from '@kbn/interpreter/common'; import { ExpressionRenderer } from '../../../../../../../src/legacy/core_plugins/data/public'; import { Action } from './state_management'; import { Datasource, Visualization, DatasourcePublicAPI } from '../../types'; -import { DragDrop } from '../../drag_drop'; +import { DragDrop, DragContext } from '../../drag_drop'; import { getSuggestions, toSwitchAction } from './suggestion_helpers'; import { buildExpression } from './expression_helpers'; @@ -45,6 +45,7 @@ export function WorkspacePanel({ dispatch, ExpressionRenderer: ExpressionRendererComponent, }: WorkspacePanelProps) { + const dragDropContext = useContext(DragContext); function onDrop(item: unknown) { const datasourceSuggestions = activeDatasource.getDatasourceSuggestionsForField( datasourceState, @@ -145,6 +146,7 @@ export function WorkspacePanel({ } else { return ( { setExpressionError(e); @@ -164,7 +166,7 @@ export function WorkspacePanel({ - + {renderVisualization()} diff --git a/x-pack/legacy/plugins/lens/public/xy_visualization_plugin/xy_expression.scss b/x-pack/legacy/plugins/lens/public/xy_visualization_plugin/xy_expression.scss index 93986078f68b1..9ba7326af6a56 100644 --- a/x-pack/legacy/plugins/lens/public/xy_visualization_plugin/xy_expression.scss +++ b/x-pack/legacy/plugins/lens/public/xy_visualization_plugin/xy_expression.scss @@ -1,4 +1,3 @@ .lnsChart { - // TODO style this dependent on the screen height (see POC) - height: 500px; + height: 100%; } \ No newline at end of file From b87f18efc3b848843fdf91cf163175ab24a7111b Mon Sep 17 00:00:00 2001 From: Joe Reuter Date: Tue, 25 Jun 2019 17:44:54 +0200 Subject: [PATCH 3/7] fix tests --- .../editor_frame/workspace_panel.test.tsx | 7 ++++--- .../native_renderer/native_renderer.test.tsx | 18 ++++++++++++++++++ 2 files changed, 22 insertions(+), 3 deletions(-) diff --git a/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/workspace_panel.test.tsx b/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/workspace_panel.test.tsx index 1294cbb2aa498..6eba080d6f823 100644 --- a/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/workspace_panel.test.tsx +++ b/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/workspace_panel.test.tsx @@ -17,6 +17,7 @@ import { import { WorkspacePanel, WorkspacePanelProps } from './workspace_panel'; import { mountWithIntl as mount } from 'test_utils/enzyme_helpers'; import { ReactWrapper } from 'enzyme'; +import { DragDrop } from '../../drag_drop'; const waitForPromises = () => new Promise(resolve => setTimeout(resolve)); @@ -317,7 +318,7 @@ Object { }, ]); - instance.childAt(0).prop('onDrop')({ + instance.find(DragDrop).prop('onDrop')!({ name: '@timestamp', type: 'date', searchable: false, @@ -374,7 +375,7 @@ Object { }, ]); - instance.childAt(0).prop('onDrop')({ + instance.find(DragDrop).prop('onDrop')!({ name: '@timestamp', type: 'date', searchable: false, @@ -392,7 +393,7 @@ Object { }); it("should do nothing when the visualization can't use the suggestions", () => { - instance.childAt(0).prop('onDrop')({ + instance.find(DragDrop).prop('onDrop')!({ name: '@timestamp', type: 'date', searchable: false, diff --git a/x-pack/legacy/plugins/lens/public/native_renderer/native_renderer.test.tsx b/x-pack/legacy/plugins/lens/public/native_renderer/native_renderer.test.tsx index 9b29174a06d69..07642e7936d25 100644 --- a/x-pack/legacy/plugins/lens/public/native_renderer/native_renderer.test.tsx +++ b/x-pack/legacy/plugins/lens/public/native_renderer/native_renderer.test.tsx @@ -121,6 +121,24 @@ describe('native_renderer', () => { expect(containerElement.nodeName).toBe('DIV'); }); + it('should pass regular html attributes to the wrapping element', () => { + const renderSpy = jest.fn(); + const testProps = { a: 'abc' }; + + renderAndTriggerHooks( + , + mountpoint + ); + const containerElement: HTMLElement = mountpoint.firstElementChild! as HTMLElement; + expect(containerElement.className).toBe('testClass'); + expect(containerElement.dataset.testSubj).toBe('container'); + }); + it('should render a specified element as container', () => { const renderSpy = jest.fn(); const testProps = { a: 'abc' }; From ed3cf7541cc9f10d08ccf1e56be79169d8f79eef Mon Sep 17 00:00:00 2001 From: Joe Reuter Date: Tue, 25 Jun 2019 18:16:44 +0200 Subject: [PATCH 4/7] remove unused import --- .../public/editor_frame_plugin/editor_frame/frame_layout.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/frame_layout.tsx b/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/frame_layout.tsx index c886e86f42004..f7cb3aaf086a7 100644 --- a/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/frame_layout.tsx +++ b/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/frame_layout.tsx @@ -5,7 +5,7 @@ */ import React from 'react'; -import { EuiPage, EuiPageSideBar, EuiPageBody, EuiPageContent } from '@elastic/eui'; +import { EuiPage, EuiPageSideBar, EuiPageBody } from '@elastic/eui'; import { RootDragDropProvider } from '../../drag_drop'; export interface FrameLayoutProps { From 0dcc1f4a39df9a0f30bd6d1a61bf4c509e4d5d39 Mon Sep 17 00:00:00 2001 From: Joe Reuter Date: Wed, 26 Jun 2019 11:02:13 +0200 Subject: [PATCH 5/7] PR review fixes --- .../editor_frame_plugin/editor_frame/editor_frame.scss | 10 +++++----- .../editor_frame_plugin/editor_frame/frame_layout.tsx | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/editor_frame.scss b/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/editor_frame.scss index 7be94d3a68545..b18c3bfb877fb 100644 --- a/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/editor_frame.scss +++ b/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/editor_frame.scss @@ -9,19 +9,19 @@ } .lnsSidebar { + @include euiScrollBar; + overflow: hidden auto; + padding: $euiSize; margin: 0; flex: 1 0 18%; min-width: ($euiSize * 16); height: 100%; display: flex; flex-direction: column; - overflow: hidden; } .lnsSidebar--right { - @include euiScrollBar; - overflow: hidden auto; - padding: $euiSize; + flex: 1 0 0; min-width: ($euiSize * 18); } @@ -36,7 +36,7 @@ } .lnsPageContent { - padding: 0 !important; + padding: 0; display: flex; flex-direction: column; diff --git a/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/frame_layout.tsx b/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/frame_layout.tsx index f7cb3aaf086a7..18f619f9d54db 100644 --- a/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/frame_layout.tsx +++ b/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/frame_layout.tsx @@ -23,7 +23,7 @@ export function FrameLayout(props: FrameLayoutProps) { {props.workspacePanel} - + {props.configPanel} {props.suggestionsPanel} From e10488de0d60d4535e410fa9d5e6fd65f289d8b7 Mon Sep 17 00:00:00 2001 From: Joe Reuter Date: Wed, 26 Jun 2019 11:05:27 +0200 Subject: [PATCH 6/7] remove important marker --- .../public/editor_frame_plugin/editor_frame/editor_frame.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/editor_frame.scss b/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/editor_frame.scss index b18c3bfb877fb..e7f198ce7fdaf 100644 --- a/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/editor_frame.scss +++ b/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/editor_frame.scss @@ -43,7 +43,7 @@ .lnsPageContentHeader { padding: $euiSize; border-bottom: $euiBorderThin; - margin-bottom: 0 !important; + margin-bottom: 0; } .lnsPageContentBody { From 68d50cad7dd16d7e3cc55e28f042c3c901483f84 Mon Sep 17 00:00:00 2001 From: Joe Reuter Date: Wed, 26 Jun 2019 11:06:47 +0200 Subject: [PATCH 7/7] size right side bar correctly --- .../public/editor_frame_plugin/editor_frame/editor_frame.scss | 1 - 1 file changed, 1 deletion(-) diff --git a/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/editor_frame.scss b/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/editor_frame.scss index e7f198ce7fdaf..2774963c162b9 100644 --- a/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/editor_frame.scss +++ b/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/editor_frame.scss @@ -21,7 +21,6 @@ } .lnsSidebar--right { - flex: 1 0 0; min-width: ($euiSize * 18); }