Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endzone Tooltips fix for FF. #3980

Merged
merged 1 commit into from
May 27, 2015

Conversation

panda01
Copy link
Contributor

@panda01 panda01 commented May 26, 2015

Closes #3930.

Touches all of the tooltips.

[Tooltip] Changed the way the tooltip functions to make up for the fact firefox doesn't have certain properties on the event and event target.

firefox's event is missing the offsetX which gives based on the nearest relative positioned element.

@panda01 panda01 added bug Fixes for quality problems that affect the customer experience blocker review v4.1.0 labels May 26, 2015
var xLeft = event.offsetX;
var xRight = event.offsetX;
if (wholeBucket) {
xLeft = xScale(boundData.x);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to get rid of the xScale() stuff here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did. It doesn't seem to do anything. especially considering the xLeft and such seems to just be used to determine the position of the mouse.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That code is what's responsible for showing the warning anytime you hover on a bucket that goes out of bounds.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk man it does that now. It seemed to me this is what the function was
really trying to accomplish
On May 26, 2015 4:43 PM, "Spencer" notifications@github.com wrote:

In src/kibana/components/vislib/visualizations/_point_series_chart.js
#3980 (comment):

     var min = leftEndzone.w;
     var max = rightEndzone.x;

     // bounds of the cursor to consider
  •    var xLeft = event.offsetX;
    
  •    var xRight = event.offsetX;
    
  •    if (wholeBucket) {
    
  •      xLeft = xScale(boundData.x);
    

That code is what's responsible for showing the warning anytime you hover
on a bucket that goes out of bounds.


Reply to this email directly or view it on GitHub
https://github.com/elastic/kibana/pull/3980/files#r31077611.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I'm talking about:
2015-05-26 14_00_03

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and on master:

2015-05-26 14_01_54

@spalger spalger assigned panda01 and unassigned spalger May 26, 2015
@panda01 panda01 assigned spalger and unassigned panda01 May 26, 2015
@spalger spalger assigned panda01 and unassigned spalger May 26, 2015
@panda01 panda01 force-pushed the fix/3930/endzoneTooltipFixForFF branch from 0a5fbde to 5646d17 Compare May 27, 2015 12:38
@panda01 panda01 assigned spalger and unassigned panda01 May 27, 2015
@panda01
Copy link
Contributor Author

panda01 commented May 27, 2015

Addressed @spalger's concerns.

@panda01 panda01 force-pushed the fix/3930/endzoneTooltipFixForFF branch 2 times, most recently from 0b54381 to 0bd6a59 Compare May 27, 2015 19:34
…ct firefox doesn't have certain properties on the event and event target
@spalger
Copy link
Contributor

spalger commented May 27, 2015

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker bug Fixes for quality problems that affect the customer experience review v4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Partial bucket tooltip missing in Firefox
2 participants