-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Endzone Tooltips fix for FF. #3980
Endzone Tooltips fix for FF. #3980
Conversation
var xLeft = event.offsetX; | ||
var xRight = event.offsetX; | ||
if (wholeBucket) { | ||
xLeft = xScale(boundData.x); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to get rid of the xScale()
stuff here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did. It doesn't seem to do anything. especially considering the xLeft and such seems to just be used to determine the position of the mouse.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idk man it does that now. It seemed to me this is what the function was
really trying to accomplish
On May 26, 2015 4:43 PM, "Spencer" notifications@github.com wrote:
In src/kibana/components/vislib/visualizations/_point_series_chart.js
#3980 (comment):var min = leftEndzone.w; var max = rightEndzone.x; // bounds of the cursor to consider
var xLeft = event.offsetX;
var xRight = event.offsetX;
if (wholeBucket) {
xLeft = xScale(boundData.x);
That code is what's responsible for showing the warning anytime you hover
on a bucket that goes out of bounds.—
Reply to this email directly or view it on GitHub
https://github.com/elastic/kibana/pull/3980/files#r31077611.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0a5fbde
to
5646d17
Compare
Addressed @spalger's concerns. |
0b54381
to
0bd6a59
Compare
…ct firefox doesn't have certain properties on the event and event target
LGTM! |
Closes #3930.
Touches all of the tooltips.
[Tooltip] Changed the way the tooltip functions to make up for the fact firefox doesn't have certain properties on the event and event target.
firefox's event is missing the offsetX which gives based on the nearest relative positioned element.