Skip to content

[ML] Adding datafeed timing stats to Job Management list #40993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 25, 2019
Merged

[ML] Adding datafeed timing stats to Job Management list #40993

merged 4 commits into from
Jul 25, 2019

Conversation

@jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Jul 12, 2019 •
edited
Loading

Datafeed timing stats added to expanded job in job management page

image

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

- [ ] This was checked for breaking API changes and was labeled appropriately
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately

@jgowdyelastic jgowdyelastic requested a review from a team as a code owner July 12, 2019 12:52
@jgowdyelastic jgowdyelastic self-assigned this Jul 12, 2019
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 12, 2019

Pinging @elastic/ml-ui

alvarezmelissa87
alvarezmelissa87 approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@droberts195
Copy link

droberts195 commented Jul 12, 2019

It might be better to wait until average_search_time_per_bucket_ms is available (also planned for 7.4 but still being implemented - see elastic/elasticsearch#44125) and display that instead of total_search_time_ms. average_search_time_per_bucket_ms will be commensurate with average_bucket_processing_time_ms and it will be possible to get an impression of whether the search or analysis is more time consuming for a given job. But total_search_time_ms requires a manual calculation before it's comparable.

/cc @sophiec20

walterra
walterra reviewed Jul 12, 2019
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added a questions about the object structure checks.

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 12, 2019

💚 Build Succeeded

peteharverson
peteharverson approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 12, 2019

💚 Build Succeeded

@jgowdyelastic
Copy link
Member Author

jgowdyelastic commented Jul 15, 2019

to confirm @droberts195 , do we want to filter out total_search_time_ms?
This can happen now in preparation for average_search_time_per_bucket_ms being available which will be displayed automatically when it's in.

@jgowdyelastic jgowdyelastic force-pushed the adding-datafeed-timing-stats-to-jobs-list branch from 70219a0 to 387d81f Compare July 25, 2019 11:26
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 25, 2019

💚 Build Succeeded

droberts195
droberts195 approved these changes Jul 25, 2019
View reviewed changes
Copy link

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic jgowdyelastic merged commit 5d9ef2a into elastic:master Jul 25, 2019
@jgowdyelastic jgowdyelastic deleted the adding-datafeed-timing-stats-to-jobs-list branch July 25, 2019 13:25
@jgowdyelastic jgowdyelastic mentioned this pull request Jul 25, 2019
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Jul 26, 2019
@jgowdyelastic
[ML] Adding datafeed timing stats to Job Management list (elastic#40993)
ab64da1 
* [ML] Adding datafeed timing stats to Job Management list

* renaming section title

* adding extra datafeed_config check

* filtering out total_search_time_ms
jgowdyelastic added a commit that referenced this pull request Jul 26, 2019
@jgowdyelastic
[ML] Adding datafeed timing stats to Job Management list (#40993) (#4…
ef31ced 
…1975)

* [ML] Adding datafeed timing stats to Job Management list

* renaming section title

* adding extra datafeed_config check

* filtering out total_search_time_ms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@walterra walterra walterra left review comments

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@peteharverson peteharverson peteharverson approved these changes

+1 more reviewer

@droberts195 droberts195 droberts195 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jgowdyelastic jgowdyelastic

Labels

:ml release_note:enhancement review v7.4.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jgowdyelastic @elasticmachine @droberts195 @walterra @alvarezmelissa87 @peteharverson