Skip to content

[ML] Adding datafeed timing stats to Job Management list #40993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 25, 2019
Merged

[ML] Adding datafeed timing stats to Job Management list #40993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
47374a4
[ML] Adding datafeed timing stats to Job Management list
jgowdyelastic Jul 12, 2019
762b882
renaming section title
jgowdyelastic Jul 12, 2019
387d81f
adding extra datafeed_config check
jgowdyelastic Jul 12, 2019
70c9018
filtering out total_search_time_ms
jgowdyelastic Jul 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion x-pack/legacy/plugins/ml/public/jobs/jobs_list/components/job_details/extract_job_details.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,14 @@ export function extractJobDetails(job) {
if (job.node) {
datafeed.items.push(['node', JSON.stringify(job.node)]);
}
if (job.datafeed_config && job.datafeed_config.timing_stats) {
// remove the timing_stats list from the datafeed section
// so not to show it twice.
const i = datafeed.items.findIndex(item => item[0] === 'timing_stats');
if (i >= 0) {
datafeed.items.splice(i, 1);
}
}

const counts = {
title: i18n.translate('xpack.ml.jobsList.jobDetails.countsTitle', {
Expand All @@ -139,6 +147,17 @@ export function extractJobDetails(job) {
items: filterObjects(job.model_size_stats).map(formatValues)
};

const datafeedTimingStats = {
title: i18n.translate('xpack.ml.jobsList.jobDetails.datafeedTimingStatsTitle', {
defaultMessage: 'Timing stats'
}),
position: 'right',
items: (job.datafeed_config && job.datafeed_config.timing_stats) ?
filterObjects(job.datafeed_config.timing_stats)
.filter(o => o[0] !== 'total_search_time_ms') // remove total_search_time_ms as average_search_time_per_bucket_ms is better
.map(formatValues) : []
};

return {
general,
customUrl,
Expand All @@ -151,6 +170,7 @@ export function extractJobDetails(job) {
dataDescription,
datafeed,
counts,
modelSizeStats
modelSizeStats,
datafeedTimingStats
};
}
5 changes: 3 additions & 2 deletions x-pack/legacy/plugins/ml/public/jobs/jobs_list/components/job_details/job_details.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ class JobDetailsUI extends Component {
dataDescription,
datafeed,
counts,
modelSizeStats
modelSizeStats,
datafeedTimingStats
} = extractJobDetails(job);

const { intl } = this.props;
Expand All @@ -93,7 +94,7 @@ class JobDetailsUI extends Component {
id: 'xpack.ml.jobsList.jobDetails.tabs.datafeedLabel',
defaultMessage: 'Datafeed'
}),
content: <JobDetailsPane sections={[datafeed]} />,
content: <JobDetailsPane sections={[datafeed, datafeedTimingStats]} />,
}, {
id: 'counts',
name: intl.formatMessage({
Expand Down
1 change: 1 addition & 0 deletions x-pack/legacy/plugins/ml/public/services/job_service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,7 @@ class JobService {
delete tempJob.datafeed_config.job_id;
delete tempJob.datafeed_config.state;
delete tempJob.datafeed_config.node;
delete tempJob.datafeed_config.timing_stats;

// remove query_delay if it's between 60s and 120s
// the back-end produces a random value between 60 and 120 and so
Expand Down
1 change: 1 addition & 0 deletions x-pack/legacy/plugins/ml/server/models/job_service/jobs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ export function jobsProvider(callWithRequest) {
const datafeedStats = results[DATAFEED_STATS].datafeeds.find(ds => (ds.datafeed_id === datafeed.datafeed_id));
if (datafeedStats) {
datafeed.state = datafeedStats.state;
datafeed.timing_stats = datafeedStats.timing_stats;
}
}
datafeeds[datafeed.job_id] = datafeed;
Expand Down