Only provide obsoleteIndexTemplatePattern to the default index migrator to avoid race conditions #42016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or to avoid race conditions
|
Pinging @elastic/kibana-operations |
joshdover
reviewed
Jul 25, 2019
|
@joshdover done, just pushed a commit with a test 👍 |
joshdover
approved these changes
Jul 25, 2019
…solete-index-template
💔 Build Failed |
src/core/server/saved_objects/migrations/kibana/kibana_migrator.ts
Outdated
Show resolved
Hide resolved
src/core/server/saved_objects/migrations/kibana/kibana_migrator.ts
Outdated
Show resolved
Hide resolved
|
@tylersmalley thanks for reviewing, I applied the suggestion in the latest commit. |
💚 Build Succeeded |
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Jul 25, 2019
…or to avoid race conditions (elastic#42016) * Only provide obsoleteIndexTemplatePattern to the default index migrator to avoid race conditions * Add test * Apply PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed my backport PR getting conflicts / race conditions to delete index templates when running migrations. (PR: #42004, Failure: https://kibana-ci.elastic.co/job/elastic+kibana+pull-request/9392/JOB=x-pack-ciGroup6,node=linux-immutable/console).
The PR mentioned above introduces a secondary saved objects index which causes two index migrators to exist. Both are trying to delete any index template following the pattern
'kibana_index_template*'. This would cause missing index_template errors.What I'm doing to avoid this is to let the default index migrator delete templates following the same pattern and to not provide a
obsoleteIndexTemplatePatternto all the other index migrators.