Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra UI] Display non-metric details on Node Detail page #43551

Merged
merged 14 commits into from
Sep 9, 2019
Merged

[Infra UI] Display non-metric details on Node Detail page #43551

merged 14 commits into from
Sep 9, 2019

Conversation

simianhacker
Copy link
Member

@simianhacker simianhacker commented Aug 19, 2019 •
edited
Loading

Summary

This PR closes #42689 by adding a metadata section to the top of the node details page.

Collapsed details

image

Expanded details

image

Collapsed details with missing data

image

Expanded details with missing data

image

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

@simianhacker simianhacker added release_note:enhancement Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.5.0 labels Aug 19, 2019
@simianhacker simianhacker self-assigned this Aug 19, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-logs-ui

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@simianhacker simianhacker marked this pull request as ready for review August 19, 2019 22:41
@simianhacker simianhacker requested a review from a team as a code owner August 19, 2019 22:41
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Titch990
Titch990 reviewed Aug 20, 2019
View reviewed changes
Copy link
Contributor

@Titch990 Titch990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need a small update to the docs (this affects one of the few topics I've worked on so far, and got up-to-date). There is a screenshot to redo, and probably a few words to update. It's probably easiest if I do it and you review my changes to save the back and forth.

What's the best way to approach this? Can I make the changes as part of this PR, or give you the required changes so you can add them to this PR, or should I raise a separate issue? In this particular case, my personal preference is to get the docs changes in as part of this PR, because the changes are necessary but tiny. By the time we've gone to the overhead of raising another issue, planning and scheduling it, remembering what the issue was about and what needs to change, dealing with the review and processing, I could have done this change ten times over. :-)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Titch990
Copy link
Contributor

@hbharding I've just sneaked in and done a tiny update to the docs to reflect this change. While redoing the screenshot, I wondered if it the time filter would be better moved below the metadata section? Currently, the time filter is above the metadata, but when the metadata is expanded, the time filter is quite a long way below the items it controls. I wonder whether a more intuitive position would be below the metadata section?

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@simianhacker
Copy link
Member Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@simianhacker simianhacker requested a review from a team September 3, 2019 18:10
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

phillipb
phillipb approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@phillipb phillipb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@simianhacker simianhacker merged commit 6575239 into elastic:master Sep 9, 2019
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 10, 2019
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into chore/console…
d1824b3 
…-to-np-ready

* 'master' of github.com:elastic/kibana: (138 commits)
  [Canvas] i18n work on workpad header (and a few header CTAs) and convert to typescript (elastic#44943)
  update close/delete system index modals (elastic#45037)
  TS return type of createIndexPatternSelect (elastic#45107)
  [ML] Fix focus chart updating. (elastic#45146)
  [ML] Data frame transform: Fix progress in wizard create step. (elastic#45116)
  [Graph] Re-enable functional test (elastic#44683)
  [SIEM] unique table id for each top talkers table (elastic#45014)
  [SIEM] ip details heading draggable (elastic#45179)
  [Maps][File upload] Set complete on index pattern creation (elastic#44423)
  [Maps] unmount map embeddable component on destroy (elastic#45183)
  [SIEM] Adds error toasts to MapEmbeddable component (elastic#45088)
  fix redirect to maintain search query string (elastic#45184)
  [APM] One-line trace summary (elastic#44842)
  [Infra UI] Display non-metric details on Node Detail page (elastic#43551)
  [Maps][File upload] Removing bbox from parsed file pending upstream lib fix (elastic#45194)
  [Logs UI] Improve live streaming behavior when scrolling (elastic#44923)
  [APM] Fix indefinite loading state in agent settings for unauthorized user roles (elastic#44970)
  [Reporting] Rewrite addForceNowQuerystring to getFullUrls (elastic#44851)
  [Reporting/ESQueue] Improve logging of doc-update events (elastic#45077)
  [Reporting] Make screenshot capture less noisy by default (elastic#45185)
  ...
simianhacker added a commit to simianhacker/kibana that referenced this pull request Sep 18, 2019
@simianhacker
[Infra UI] Display non-metric details on Node Detail page (elastic#43551
40e01aa 
)

* [Infra UI] Display non-metric details on Node Detail page

- Closes elastic#42689
- Adds NodeDetails component

* clean things up a bit

* Change hook order

* Start of docs changes

* Making expand button more consitent

* Update docs for this minor change

* Changing handleClick to toggleIsOpen

* Optimizing fields slice
@simianhacker simianhacker mentioned this pull request Sep 18, 2019
Merged
simianhacker added a commit that referenced this pull request Sep 18, 2019
@simianhacker
[Infra UI] Display non-metric details on Node Detail page (#43551) (#…
d226c8c 
…46049)

* [Infra UI] Display non-metric details on Node Detail page

- Closes #42689
- Adds NodeDetails component

* clean things up a bit

* Change hook order

* Start of docs changes

* Making expand button more consitent

* Update docs for this minor change

* Changing handleClick to toggleIsOpen

* Optimizing fields slice
@simianhacker simianhacker deleted the fixes-42689 branch April 17, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Titch990 Titch990 Titch990 left review comments

@phillipb phillipb phillipb approved these changes

Assignees

@simianhacker simianhacker

Labels
Feature:Metrics UI Metrics UI feature release_note:enhancement Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Infra UI] Show non-metric details on node detail page
4 participants
@simianhacker @elasticmachine @Titch990 @phillipb