-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Adding error reporting to new job wizard charts #43857
Merged
jgowdyelastic
merged 1 commit into
elastic:master
from
jgowdyelastic:adding-error-reporting-to-wizard-charts
Aug 27, 2019
Merged
[ML] Adding error reporting to new job wizard charts #43857
jgowdyelastic
merged 1 commit into
elastic:master
from
jgowdyelastic:adding-error-reporting-to-wizard-charts
Aug 27, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
requested review from
peteharverson,
walterra and
alvarezmelissa87
August 23, 2019 13:06
jgowdyelastic
added
:ml
bug
Fixes for quality problems that affect the customer experience
non-issue
Indicates to automation that a pull request should not appear in the release notes
release_note:skip
Skip the PR/issue when compiling release notes
review
v7.4.0
v8.0.0
labels
Aug 23, 2019
Pinging @elastic/ml-ui |
💚 Build Succeeded |
alvarezmelissa87
approved these changes
Aug 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
walterra
approved these changes
Aug 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jgowdyelastic
force-pushed
the
adding-error-reporting-to-wizard-charts
branch
from
August 27, 2019 07:02
04db65a
to
a81c28f
Compare
💚 Build Succeeded |
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Aug 27, 2019
jgowdyelastic
added a commit
that referenced
this pull request
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors thrown when loading chart data are now caught and displayed in toasts.
Also adds a ts definition file for our messagebar error lib (which needs replacing) and changes the way the bucket span estimator was logging errors to the console.