Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Adding error reporting to new job wizard charts #43857

Conversation

jgowdyelastic
Copy link
Member

Errors thrown when loading chart data are now caught and displayed in toasts.
Also adds a ts definition file for our messagebar error lib (which needs replacing) and changes the way the bucket span estimator was logging errors to the console.

@jgowdyelastic jgowdyelastic requested a review from a team as a code owner August 23, 2019 13:06
@jgowdyelastic jgowdyelastic self-assigned this Aug 23, 2019
@jgowdyelastic jgowdyelastic added :ml bug Fixes for quality problems that affect the customer experience non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.4.0 v8.0.0 labels Aug 23, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic jgowdyelastic force-pushed the adding-error-reporting-to-wizard-charts branch from 04db65a to a81c28f Compare August 27, 2019 07:02
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jgowdyelastic jgowdyelastic merged commit dce041c into elastic:master Aug 27, 2019
@jgowdyelastic jgowdyelastic deleted the adding-error-reporting-to-wizard-charts branch August 27, 2019 09:44
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.4.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants