[Reporting] Fix TypeError with pending job info #43924
Conversation
tsullivan
added
review
release_note:fix
(Deprecated) Feature:Reporting
|
Pinging @elastic/kibana-stack-services |
💚 Build Succeeded |
💚 Build Succeeded |
| @@ -77,8 +73,21 @@ export class ReportInfoButton extends Component<Props, State> { | |||
|
|
|||
| const jobType = info.jobtype || NA; | |||
|
|
|||
| // TODO queue method (clicked UI, watcher, etc) | |||
There was a problem hiding this comment.
I removed this TODO because it's been talked about before, but never seemed essential
💚 Build Succeeded |
There was a problem hiding this comment.
Changes look good. Thanks for adding tests.
Only thing I noticed is that ReportInfoButton component contains several strings that are not wrapped in i18n translations like "unknown", "n/a", "Width: ${width} x Height: ${height}", "Job Info", all JobInfoMap titles, and "Unable to fetch report info".
lgtm
code review
Good call @nreese! This has come up before in Reporting code: #42873 That issue has come up once in a Stack Services sync as something that could be tackled by a non-expert in Reporting code. Things move fast! |
* fix typeerror and typescript warnings * add test for report listing * get a relevant snapshot to test with * fix debug diff * remove unnecessary change
* fix typeerror and typescript warnings * add test for report listing * get a relevant snapshot to test with * fix debug diff * remove unnecessary change
Closes #42484 #42895