[Canvas] i18n work on workpad header (and a few header CTAs) and convert to typescript #44943

poffdeluxe · 2019-09-05T20:57:48Z

Summary

Converted WorkpadHeader to Typescript (with some adjustments to a few related components)

Adding i18n strings for the following components:

WorkpadHeader (subcomponents not yet complete)
Asset
AssetManager
AssetModal

slight modification to the embeddable flyout

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, including a check against IE11~~
~~- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~- [ ] Documentation was added for features that require explanation or tutorials~~
~~- [ ] Unit or functional tests were updated or added to match the most common scenarios~~
~~- [ ] This was checked for keyboard-only and screenreader accessibility~~

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-09-05T20:57:50Z

Pinging @elastic/kibana-canvas

clintandrewhall

Nice work! Approving to unblock, but resolve the comments below before merging.

clintandrewhall · 2019-09-05T21:31:02Z

x-pack/legacy/plugins/canvas/public/components/workpad_header/index.tsx

@@ -5,22 +5,40 @@
 */

 import { connect } from 'react-redux';
+import { Dispatch } from 'redux';
+// @ts-ignore: Local Untyped


nit: "Untyped local" - just so we can find them all later

clintandrewhall · 2019-09-05T21:31:40Z

x-pack/legacy/plugins/canvas/public/components/workpad_header/index.tsx

+  setWriteable: (isWorkpadWriteable: boolean) => void;
+}
+
+const mapStateToProps = (state: any) => ({


State should be defined.

clintandrewhall · 2019-09-05T21:34:49Z

x-pack/legacy/plugins/canvas/public/components/workpad_header/workpad_header.tsx

@@ -53,7 +76,7 @@ export class WorkpadHeader extends React.PureComponent {
    </EuiToolTip>
  );

-  _keyHandler = action => {
+  _keyHandler = (action: string) => {


action appears to be a predictable type.

type Action = 'EDITING' | 'FULLSCREEN' | ...? _keyHandler = (action: Action) => {

Might chat with @cqliu1 about where these are defined, then enumerate them there as a type. Otherwise, for now, just create a type here that matches what we're expecting.

Spoke with @cqliu1 about it.. seems like there's not a good way right now to grab all the actions. I looked briefly at defining them as a big union type but Catherine and I agreed it might be better to have them all listed as an enum that way you can reference them when adding to the keymap (not just referencing a magic string). Problem with doing that enum is that it might be a really not-fun refactor and I'm not sure we wanna block i18n work for it.

I went ahead and created this issue for it though: #45073

clintandrewhall · 2019-09-05T21:39:53Z

x-pack/legacy/plugins/canvas/public/components/workpad_header/workpad_header.tsx

@@ -18,30 +19,52 @@ import {
  EuiModalFooter,
  EuiToolTip,
 } from '@elastic/eui';
+
+import { ComponentStrings } from '../../../i18n';
+const { WorkpadHeader: strings } = ComponentStrings;


nit: place const after all imports.

clintandrewhall · 2019-09-05T21:42:38Z

x-pack/legacy/plugins/canvas/i18n/components.ts

+      }),
+    getSpaceUsedText: (percentageUsed: number) =>
+      i18n.translate('xpack.canvas.assetModal.spacedUsedText', {
+        defaultMessage: `${percentageUsed}% space used`,


This should have a value, not use template strings:

defaultMessage: '{percentageUsed} space used', values: { percentageUsed }

https://github.com/elastic/kibana/blob/master/src/dev/i18n/README.md

elasticmachine · 2019-09-05T22:15:38Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-05T23:54:28Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-06T16:56:14Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-06T21:40:45Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-06T22:24:51Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

This reverts commit d00e48853bcb16fdb14f9bca8b2536c920e8d650.

elasticmachine · 2019-09-09T19:57:25Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

poffdeluxe · 2019-09-09T22:40:05Z

retest

elasticmachine · 2019-09-10T00:22:44Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-10T03:00:16Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…-to-np-ready * 'master' of github.com:elastic/kibana: (138 commits) [Canvas] i18n work on workpad header (and a few header CTAs) and convert to typescript (elastic#44943) update close/delete system index modals (elastic#45037) TS return type of createIndexPatternSelect (elastic#45107) [ML] Fix focus chart updating. (elastic#45146) [ML] Data frame transform: Fix progress in wizard create step. (elastic#45116) [Graph] Re-enable functional test (elastic#44683) [SIEM] unique table id for each top talkers table (elastic#45014) [SIEM] ip details heading draggable (elastic#45179) [Maps][File upload] Set complete on index pattern creation (elastic#44423) [Maps] unmount map embeddable component on destroy (elastic#45183) [SIEM] Adds error toasts to MapEmbeddable component (elastic#45088) fix redirect to maintain search query string (elastic#45184) [APM] One-line trace summary (elastic#44842) [Infra UI] Display non-metric details on Node Detail page (elastic#43551) [Maps][File upload] Removing bbox from parsed file pending upstream lib fix (elastic#45194) [Logs UI] Improve live streaming behavior when scrolling (elastic#44923) [APM] Fix indefinite loading state in agent settings for unauthorized user roles (elastic#44970) [Reporting] Rewrite addForceNowQuerystring to getFullUrls (elastic#44851) [Reporting/ESQueue] Improve logging of doc-update events (elastic#45077) [Reporting] Make screenshot capture less noisy by default (elastic#45185) ...

…ert to typescript (elastic#44943) * i18n work on workpad header and a few header ctas * Convert WorkpadHeader to typescript * String ordering cleanup * Addressing some feedback * Adding state * lint * Shortcut type refactor * Revert "Shortcut type refactor" This reverts commit d00e48853bcb16fdb14f9bca8b2536c920e8d650. * Using new State type * Removing unused type * Updating state type

…ert to typescript (#44943) (#45405) * i18n work on workpad header and a few header ctas * Convert WorkpadHeader to typescript * String ordering cleanup * Addressing some feedback * Adding state * lint * Shortcut type refactor * Revert "Shortcut type refactor" This reverts commit d00e48853bcb16fdb14f9bca8b2536c920e8d650. * Using new State type * Removing unused type * Updating state type

poffdeluxe requested a review from a team as a code owner September 5, 2019 20:57

clintandrewhall approved these changes Sep 5, 2019

View reviewed changes

poffdeluxe added 9 commits September 9, 2019 13:19

i18n work on workpad header and a few header ctas

b6ed375

Convert WorkpadHeader to typescript

59d8c52

String ordering cleanup

7d8b603

Addressing some feedback

5ed1bca

Adding state

8732870

lint

80aeff2

Shortcut type refactor

2f2a2af

Revert "Shortcut type refactor"

49de05d

This reverts commit d00e48853bcb16fdb14f9bca8b2536c920e8d650.

Using new State type

27eb09a

poffdeluxe force-pushed the i18n-canvas-workpad-header branch from 2747510 to 27eb09a Compare September 9, 2019 18:45

Removing unused type

8668f28

Updating state type

1680523

poffdeluxe merged commit b57824f into elastic:master Sep 10, 2019

poffdeluxe deleted the i18n-canvas-workpad-header branch September 10, 2019 14:30

poffdeluxe mentioned this pull request Sep 11, 2019

[7.x] [Canvas] i18n work on workpad header (and a few header CTAs) and convert to typescript (#44943) #45405

Merged

poffdeluxe restored the i18n-canvas-workpad-header branch September 12, 2019 15:36

poffdeluxe mentioned this pull request Sep 13, 2019

[Canvas] Converting workpad header components to typescript and adding i18n #45274

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Canvas] i18n work on workpad header (and a few header CTAs) and convert to typescript #44943

[Canvas] i18n work on workpad header (and a few header CTAs) and convert to typescript #44943

poffdeluxe commented Sep 5, 2019 •

edited

Loading

elasticmachine commented Sep 5, 2019

clintandrewhall left a comment

clintandrewhall Sep 5, 2019

clintandrewhall Sep 5, 2019

clintandrewhall Sep 5, 2019

poffdeluxe Sep 6, 2019

clintandrewhall Sep 5, 2019

clintandrewhall Sep 5, 2019

elasticmachine commented Sep 5, 2019

elasticmachine commented Sep 5, 2019

elasticmachine commented Sep 6, 2019

elasticmachine commented Sep 6, 2019

elasticmachine commented Sep 6, 2019

elasticmachine commented Sep 9, 2019

poffdeluxe commented Sep 9, 2019

elasticmachine commented Sep 10, 2019

elasticmachine commented Sep 10, 2019

[Canvas] i18n work on workpad header (and a few header CTAs) and convert to typescript #44943

[Canvas] i18n work on workpad header (and a few header CTAs) and convert to typescript #44943

Conversation

poffdeluxe commented Sep 5, 2019 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Sep 5, 2019

clintandrewhall left a comment

Choose a reason for hiding this comment

clintandrewhall Sep 5, 2019

Choose a reason for hiding this comment

clintandrewhall Sep 5, 2019

Choose a reason for hiding this comment

clintandrewhall Sep 5, 2019

Choose a reason for hiding this comment

poffdeluxe Sep 6, 2019

Choose a reason for hiding this comment

clintandrewhall Sep 5, 2019

Choose a reason for hiding this comment

clintandrewhall Sep 5, 2019

Choose a reason for hiding this comment

elasticmachine commented Sep 5, 2019

💔 Build Failed

elasticmachine commented Sep 5, 2019

💚 Build Succeeded

elasticmachine commented Sep 6, 2019

💚 Build Succeeded

elasticmachine commented Sep 6, 2019

💔 Build Failed

elasticmachine commented Sep 6, 2019

💚 Build Succeeded

elasticmachine commented Sep 9, 2019

💔 Build Failed

poffdeluxe commented Sep 9, 2019

elasticmachine commented Sep 10, 2019

💔 Build Failed

elasticmachine commented Sep 10, 2019

💚 Build Succeeded

poffdeluxe commented Sep 5, 2019 •

edited

Loading