Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eslint #49595

Merged
merged 14 commits into from
Oct 30, 2019
Merged

Fix eslint #49595

merged 14 commits into from
Oct 30, 2019

Conversation

streamich
Copy link
Contributor

Fixes App Architecture linter errors reported here.

@streamich streamich requested a review from a team as a code owner October 29, 2019 08:34
@streamich streamich added release_note:skip Skip the PR/issue when compiling release notes review Team:AppArch v7.5.0 labels Oct 29, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@streamich streamich added v7.6.0 and removed v7.5.0 labels Oct 29, 2019
lizozom
lizozom approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@lizozom lizozom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when green

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@streamich streamich merged commit a10cf38 into elastic:master Oct 30, 2019
@streamich streamich mentioned this pull request Oct 30, 2019
Merged
streamich added a commit that referenced this pull request Oct 30, 2019
@streamich
Fix eslint (#49595) (#49725)
af7e9fa 
* fix: 🐛 fix unused persistedLog object

* chore: 🤖 ignore ESLint rule

* fix: 🐛 correct dependencies in useUnmount() hook

* fix: 🐛 fix ESLint errors

* chore: 🤖 disable ESLint rule

* fix: 🐛 add savedQueryService to dependency list

* fix: 🐛 fix ESLint errors in data plugin

* chore: 🤖 fix self-closing ESLint rule

* test: 💍 update Jest snapshot

* refactor: 💡 memoize persistedLog in more idiomatic way

* chore: 🤖 remomve unused import

* chore: 🤖 revert possible test breaker

* fix: 🐛 fix query bar merge errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizozom lizozom lizozom approved these changes

@ppisljar ppisljar Awaiting requested review from ppisljar

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes review v7.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@streamich @elasticmachine @lizozom