-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Categorization wizard #53009
[ML] Categorization wizard #53009
Conversation
651d7db
to
4753401
Compare
💔 Build Failed
History
To update your PR or re-run it, just comment with: |
076162f
to
f8a975e
Compare
Pinging @elastic/ml-ui (:ml) |
x-pack/legacy/plugins/ml/server/models/job_service/new_job/categorization.ts
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/ml/public/application/jobs/new_job/common/job_validator/job_validator.ts
Outdated
Show resolved
Hide resolved
...omponents/common/edit_categorization_analyzer_flyout/edit_categorization_analyzer_flyout.tsx
Outdated
Show resolved
Hide resolved
.../pages/components/pick_fields_step/components/categorization_view/examples_valid_callout.tsx
Outdated
Show resolved
Hide resolved
.../new_job/pages/components/pick_fields_step/components/categorization_view/field_examples.tsx
Outdated
Show resolved
Hide resolved
...ew_job/pages/components/pick_fields_step/components/categorization_view/metric_selection.tsx
Outdated
Show resolved
Hide resolved
01a4b21
to
f6fbc8f
Compare
...omponents/common/edit_categorization_analyzer_flyout/edit_categorization_analyzer_flyout.tsx
Outdated
Show resolved
Hide resolved
</h3> | ||
</EuiTitle> | ||
<EuiSpacer size="s" /> | ||
<EuiFlexGroup gutterSize="l" style={{ maxWidth: '824px' }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we replace this inline style?
..._job/pages/components/pick_fields_step/components/categorization_detector/detector_cards.tsx
Show resolved
Hide resolved
..._job/pages/components/pick_fields_step/components/categorization_detector/detector_cards.tsx
Outdated
Show resolved
Hide resolved
.../pages/components/pick_fields_step/components/categorization_view/examples_valid_callout.tsx
Outdated
Show resolved
Hide resolved
.../new_job/pages/components/pick_fields_step/components/categorization_view/field_examples.tsx
Outdated
Show resolved
Hide resolved
.../new_job/pages/components/pick_fields_step/components/categorization_view/field_examples.tsx
Outdated
Show resolved
Hide resolved
...ages/components/pick_fields_step/components/categorization_view/metric_selection_summary.tsx
Show resolved
Hide resolved
x-pack/legacy/plugins/ml/server/models/job_service/new_job/categorization.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
..._job/pages/components/pick_fields_step/components/categorization_detector/detector_cards.tsx
Outdated
Show resolved
Hide resolved
08054ef
to
80b802f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest edits LGTM
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
* [ML] Categorization wizard * fixing js prettier issues * adding basic category field validation * adding rare or count selection * fixing types * category examples changes * improving results search * adding analyzer editing * improving callout * updating callout text * fixing import path * resetting cat analyser json on flyout open * disabling model plot by default * minor refactoring * fixing types * hide estimate bucket span * setting default bucket span * removing ml_classic workaround * changing style of detector selection * fixing convert to advanced issue * removing sparse data checkbox * changes based on review * use default mml * fixing job cloning * changes based on review * removing categorization_analyzer from job if it is same as default * fixing translations * disabling model plot for rare jobs * removing console.error in useResolver
* [ML] Categorization wizard * fixing js prettier issues * adding basic category field validation * adding rare or count selection * fixing types * category examples changes * improving results search * adding analyzer editing * improving callout * updating callout text * fixing import path * resetting cat analyser json on flyout open * disabling model plot by default * minor refactoring * fixing types * hide estimate bucket span * setting default bucket span * removing ml_classic workaround * changing style of detector selection * fixing convert to advanced issue * removing sparse data checkbox * changes based on review * use default mml * fixing job cloning * changes based on review * removing categorization_analyzer from job if it is same as default * fixing translations * disabling model plot for rare jobs * removing console.error in useResolver
Adds a wizard for creating categorization jobs.
User can select a Count or Rare detector and the categorization field from a list text and keyword fields.
When a field is selected, a list of example field values is shown with highlighted tokens based on the default analyser.
The analyzer can be edited by the user which will reload these examples.
A validation message is also displayed to show the results of the token counts per field value.
100 values are checked and a percentage show based on how many have more than one token.
If this percentage is less than 75%, the user is warned that field might not be good for categorization.
If the percentage is less than 2%, the use of that field is not allowed.
When running the job, an event rate chart is shown with anomalies.
Along with a list of example categories. If model plot is enabled, this list will also have a count per category and be sorted by the most popular category.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers