Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Unskip flaky tests (#57715) #57947

Merged
merged 1 commit into from
Feb 19, 2020
Merged

[7.x] Unskip flaky tests (#57715) #57947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/functional/page_objects/common_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export function CommonPageProvider({ getService, getPageObjects }: FtrProviderCo
);
await find.byCssSelector(
'[data-test-subj="kibanaChrome"] nav:not(.ng-hide)',
2 * defaultFindTimeout
6 * defaultFindTimeout
);
await browser.get(appUrl);
currentUrl = await browser.getCurrentUrl();
Expand Down
6 changes: 3 additions & 3 deletions x-pack/test/functional/apps/advanced_settings/feature_controls/advanced_settings_security.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
const esArchiver = getService('esArchiver');
const kibanaServer = getService('kibanaServer');
const security = getService('security');
const config = getService('config');
const PageObjects = getPageObjects(['common', 'settings', 'security', 'spaceSelector']);
const appsMenu = getService('appsMenu');
const testSubjects = getService('testSubjects');
Expand Down Expand Up @@ -178,14 +179,13 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
expect(navLinks).to.eql(['Discover', 'Stack Management']);
});

// https://github.com/elastic/kibana/issues/57377
it.skip(`does not allow navigation to advanced settings; redirects to management home`, async () => {
it(`does not allow navigation to advanced settings; redirects to management home`, async () => {
await PageObjects.common.navigateToActualUrl('kibana', 'management/kibana/settings', {
ensureCurrentUrl: false,
shouldLoginIfPrompted: false,
});
await testSubjects.existOrFail('managementHome', {
timeout: 10000,
timeout: config.get('timeouts.waitFor'),
});
});
});
Expand Down
11 changes: 6 additions & 5 deletions x-pack/test/functional/apps/advanced_settings/feature_controls/advanced_settings_spaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
const PageObjects = getPageObjects(['common', 'settings', 'security', 'spaceSelector']);
const testSubjects = getService('testSubjects');
const appsMenu = getService('appsMenu');
const config = getService('config');

// FLAKY: https://github.com/elastic/kibana/issues/57377
describe.skip('spaces feature controls', () => {
describe('spaces feature controls', () => {
before(async () => {
await esArchiver.loadIfNeeded('logstash_functional');
});
Expand Down Expand Up @@ -58,8 +58,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
});
});

// https://github.com/elastic/kibana/issues/57413
describe.skip('space with Advanced Settings disabled', () => {
describe('space with Advanced Settings disabled', () => {
before(async () => {
// we need to load the following in every situation as deleting
// a space deletes all of the associated saved objects
Expand All @@ -82,7 +81,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
ensureCurrentUrl: false,
shouldLoginIfPrompted: false,
});
await testSubjects.existOrFail('managementHome');
await testSubjects.existOrFail('managementHome', {
timeout: config.get('timeouts.waitFor'),
});
});
});
});
Expand Down
30 changes: 20 additions & 10 deletions x-pack/test/functional/apps/dashboard/feature_controls/dashboard_security.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { FtrProviderContext } from '../../../ftr_provider_context';
export default function({ getPageObjects, getService }: FtrProviderContext) {
const esArchiver = getService('esArchiver');
const security = getService('security');
const config = getService('config');
const PageObjects = getPageObjects(['common', 'dashboard', 'security', 'spaceSelector', 'share']);
const appsMenu = getService('appsMenu');
const panelActions = getService('dashboardPanelActions');
Expand All @@ -21,8 +22,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
const queryBar = getService('queryBar');
const savedQueryManagementComponent = getService('savedQueryManagementComponent');

// FLAKY: https://github.com/elastic/kibana/issues/44631
describe.skip('dashboard security', () => {
describe('dashboard security', () => {
before(async () => {
await esArchiver.load('dashboard/feature_controls/security');
await esArchiver.loadIfNeeded('logstash_functional');
Expand Down Expand Up @@ -88,7 +88,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
shouldLoginIfPrompted: false,
}
);
await testSubjects.existOrFail('dashboardLandingPage', { timeout: 10000 });
await testSubjects.existOrFail('dashboardLandingPage', {
timeout: config.get('timeouts.waitFor'),
});
await testSubjects.existOrFail('newItemButton');
});

Expand All @@ -105,15 +107,19 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
shouldLoginIfPrompted: false,
}
);
await testSubjects.existOrFail('emptyDashboardWidget', { timeout: 10000 });
await testSubjects.existOrFail('emptyDashboardWidget', {
timeout: config.get('timeouts.waitFor'),
});
});

it(`can view existing Dashboard`, async () => {
await PageObjects.common.navigateToActualUrl('kibana', createDashboardEditUrl('i-exist'), {
ensureCurrentUrl: false,
shouldLoginIfPrompted: false,
});
await testSubjects.existOrFail('embeddablePanelHeading-APie', { timeout: 10000 });
await testSubjects.existOrFail('embeddablePanelHeading-APie', {
timeout: config.get('timeouts.waitFor'),
});
});

it(`does not allow a visualization to be edited`, async () => {
Expand Down Expand Up @@ -266,7 +272,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
shouldLoginIfPrompted: false,
}
);
await testSubjects.existOrFail('dashboardLandingPage', { timeout: 10000 });
await testSubjects.existOrFail('dashboardLandingPage', {
timeout: config.get('timeouts.waitFor'),
});
await testSubjects.missingOrFail('newItemButton');
});

Expand All @@ -291,7 +299,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
ensureCurrentUrl: false,
shouldLoginIfPrompted: false,
});
await testSubjects.existOrFail('embeddablePanelHeading-APie', { timeout: 10000 });
await testSubjects.existOrFail('embeddablePanelHeading-APie', {
timeout: config.get('timeouts.waitFor'),
});
});

it(`Permalinks doesn't show create short-url button`, async () => {
Expand Down Expand Up @@ -377,7 +387,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
shouldLoginIfPrompted: false,
}
);
await testSubjects.existOrFail('homeApp', { timeout: 10000 });
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
});

it(`create new dashboard redirects to the home page`, async () => {
Expand All @@ -401,15 +411,15 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
shouldLoginIfPrompted: false,
}
);
await testSubjects.existOrFail('homeApp', { timeout: 10000 });
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
});

it(`edit dashboard for object which exists redirects to the home page`, async () => {
await PageObjects.common.navigateToActualUrl('kibana', createDashboardEditUrl('i-exist'), {
ensureCurrentUrl: false,
shouldLoginIfPrompted: false,
});
await testSubjects.existOrFail('homeApp', { timeout: 10000 });
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
});
});
});
Expand Down
19 changes: 13 additions & 6 deletions x-pack/test/functional/apps/dashboard/feature_controls/dashboard_spaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { FtrProviderContext } from '../../../ftr_provider_context';

export default function({ getPageObjects, getService }: FtrProviderContext) {
const esArchiver = getService('esArchiver');
const config = getService('config');
const spacesService = getService('spaces');
const PageObjects = getPageObjects([
'common',
Expand Down Expand Up @@ -64,7 +65,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
shouldLoginIfPrompted: false,
}
);
await testSubjects.existOrFail('dashboardLandingPage', { timeout: 10000 });
await testSubjects.existOrFail('dashboardLandingPage', {
timeout: config.get('timeouts.waitFor'),
});
await testSubjects.existOrFail('newItemButton');
});

Expand All @@ -78,7 +81,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
shouldLoginIfPrompted: false,
}
);
await testSubjects.existOrFail('emptyDashboardWidget', { timeout: 10000 });
await testSubjects.existOrFail('emptyDashboardWidget', {
timeout: config.get('timeouts.waitFor'),
});
});

it(`can view existing Dashboard`, async () => {
Expand All @@ -87,7 +92,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
ensureCurrentUrl: false,
shouldLoginIfPrompted: false,
});
await testSubjects.existOrFail('embeddablePanelHeading-APie', { timeout: 10000 });
await testSubjects.existOrFail('embeddablePanelHeading-APie', {
timeout: config.get('timeouts.waitFor'),
});
});
});

Expand Down Expand Up @@ -126,7 +133,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
shouldLoginIfPrompted: false,
}
);
await testSubjects.existOrFail('homeApp', { timeout: 10000 });
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
});

it(`edit dashboard for object which doesn't exist redirects to the home page`, async () => {
Expand All @@ -139,7 +146,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
shouldLoginIfPrompted: false,
}
);
await testSubjects.existOrFail('homeApp', { timeout: 10000 });
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
});

it(`edit dashboard for object which exists redirects to the home page`, async () => {
Expand All @@ -148,7 +155,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
ensureCurrentUrl: false,
shouldLoginIfPrompted: false,
});
await testSubjects.existOrFail('homeApp', { timeout: 10000 });
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
});
});
});
Expand Down
7 changes: 4 additions & 3 deletions x-pack/test/functional/apps/dev_tools/feature_controls/dev_tools_security.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
const esArchiver = getService('esArchiver');
const security = getService('security');
const PageObjects = getPageObjects(['common', 'console', 'security']);
const config = getService('config');
const appsMenu = getService('appsMenu');
const testSubjects = getService('testSubjects');
const grokDebugger = getService('grokDebugger');
Expand Down Expand Up @@ -232,21 +233,21 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
await PageObjects.common.navigateToUrl('console', '', {
ensureCurrentUrl: false,
});
await testSubjects.existOrFail('homeApp', { timeout: 10000 });
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
});

it(`navigating to search profiler redirect to homepage`, async () => {
await PageObjects.common.navigateToUrl('searchProfiler', '', {
ensureCurrentUrl: false,
});
await testSubjects.existOrFail('homeApp', { timeout: 10000 });
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
});

it(`navigating to grok debugger redirect to homepage`, async () => {
await PageObjects.common.navigateToUrl('grokDebugger', '', {
ensureCurrentUrl: false,
});
await testSubjects.existOrFail('homeApp', { timeout: 10000 });
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
});
});
});
Expand Down
7 changes: 4 additions & 3 deletions x-pack/test/functional/apps/dev_tools/feature_controls/dev_tools_spaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { FtrProviderContext } from '../../../ftr_provider_context';

export default function({ getPageObjects, getService }: FtrProviderContext) {
const esArchiver = getService('esArchiver');
const config = getService('config');
const spacesService = getService('spaces');
const PageObjects = getPageObjects([
'common',
Expand Down Expand Up @@ -92,21 +93,21 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
await PageObjects.common.navigateToUrl('console', '', {
ensureCurrentUrl: false,
});
await testSubjects.existOrFail('homeApp', { timeout: 10000 });
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
});

it(`navigating to search profiler redirect to homepage`, async () => {
await PageObjects.common.navigateToUrl('searchProfiler', '', {
ensureCurrentUrl: false,
});
await testSubjects.existOrFail('homeApp', { timeout: 10000 });
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
});

it(`navigating to grok debugger redirect to homepage`, async () => {
await PageObjects.common.navigateToUrl('grokDebugger', '', {
ensureCurrentUrl: false,
});
await testSubjects.existOrFail('homeApp', { timeout: 10000 });
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
});
});
});
Expand Down
6 changes: 3 additions & 3 deletions x-pack/test/functional/apps/discover/feature_controls/discover_security.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
const esArchiver = getService('esArchiver');
const security = getService('security');
const globalNav = getService('globalNav');
const config = getService('config');
const PageObjects = getPageObjects([
'common',
'discover',
Expand All @@ -27,8 +28,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
await PageObjects.timePicker.setDefaultAbsoluteRange();
}

// FLAKY: https://github.com/elastic/kibana/issues/45348
describe.skip('security', () => {
describe('security', () => {
before(async () => {
await esArchiver.load('discover/feature_controls/security');
await esArchiver.loadIfNeeded('logstash_functional');
Expand Down Expand Up @@ -305,7 +305,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
await PageObjects.common.navigateToUrl('discover', '', {
ensureCurrentUrl: false,
});
await testSubjects.existOrFail('homeApp', { timeout: 10000 });
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
});
});
});
Expand Down
7 changes: 5 additions & 2 deletions x-pack/test/functional/apps/discover/feature_controls/discover_spaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { FtrProviderContext } from '../../../ftr_provider_context';

export default function({ getPageObjects, getService }: FtrProviderContext) {
const esArchiver = getService('esArchiver');
const config = getService('config');
const spacesService = getService('spaces');
const PageObjects = getPageObjects([
'common',
Expand Down Expand Up @@ -59,7 +60,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
await PageObjects.common.navigateToApp('discover', {
basePath: '/s/custom_space',
});
await testSubjects.existOrFail('discoverSaveButton', { timeout: 10000 });
await testSubjects.existOrFail('discoverSaveButton', {
timeout: config.get('timeouts.waitFor'),
});
});

it('shows "visualize" field button', async () => {
Expand Down Expand Up @@ -156,7 +159,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
basePath: '/s/custom_space',
ensureCurrentUrl: false,
});
await testSubjects.existOrFail('homeApp', { timeout: 10000 });
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
});
});
});
Expand Down
3 changes: 2 additions & 1 deletion x-pack/test/functional/apps/index_patterns/feature_controls/index_patterns_security.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
const esArchiver = getService('esArchiver');
const kibanaServer = getService('kibanaServer');
const security = getService('security');
const config = getService('config');
const PageObjects = getPageObjects(['common', 'settings', 'security']);
const appsMenu = getService('appsMenu');
const testSubjects = getService('testSubjects');
Expand Down Expand Up @@ -190,7 +191,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
ensureCurrentUrl: false,
shouldLoginIfPrompted: false,
});
await testSubjects.existOrFail('homeApp', { timeout: 10000 });
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
});
});
});
Expand Down
6 changes: 3 additions & 3 deletions x-pack/test/functional/apps/index_patterns/feature_controls/index_patterns_spaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { FtrProviderContext } from '../../../ftr_provider_context';

export default function({ getPageObjects, getService }: FtrProviderContext) {
const esArchiver = getService('esArchiver');
const config = getService('config');
const spacesService = getService('spaces');
const PageObjects = getPageObjects(['common', 'settings', 'security']);
const testSubjects = getService('testSubjects');
Expand Down Expand Up @@ -52,8 +53,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
});
});

// https://github.com/elastic/kibana/issues/57601
describe.skip('space with Index Patterns disabled', () => {
describe('space with Index Patterns disabled', () => {
before(async () => {
// we need to load the following in every situation as deleting
// a space deletes all of the associated saved objects
Expand All @@ -76,7 +76,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
ensureCurrentUrl: false,
shouldLoginIfPrompted: false,
});
await testSubjects.existOrFail('homeApp', { timeout: 10000 });
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
});
});
});
Expand Down
Loading