Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip][Drilldowns] Drilldown Wizard Components #59139

Closed

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Mar 3, 2020

Summary

Part of #55291

  • Implements drilldown wizard components
  • Still uses fake mock interfaces and fake action factories

Screenshot 2020-03-06 at 11 35 24
Screenshot 2020-03-06 at 11 35 15
Screenshot 2020-03-06 at 11 35 09
Screenshot 2020-03-06 at 11 35 05

To test:

  • Create Drilldown can be opened from dashboard there is "Create Drilldown" button in context menu for panel
  • or yarn storybook drilldowns

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@botelastic botelastic bot added the Feature:Drilldowns Embeddable panel Drilldowns label Mar 3, 2020
@Dosant
Copy link
Contributor Author

Dosant commented Mar 3, 2020

@elasticmachine merge upstream

elasticmachine and others added 19 commits March 3, 2020 11:37
…ant/kibana into dev/drilldowns/create-drilldown-form

# Conflicts:
#	src/plugins/ui_actions/public/components/action_wizard/action_wizard.tsx
…ant/kibana into dev/drilldowns/action-factory-picker
…ant/kibana into dev/drilldowns/create-drilldown-form

# Conflicts:
#	src/plugins/home/public/application/index.ts
…ant/kibana into dev/drilldowns/create-drilldown-form
…ant/kibana into dev/drilldowns/create-drilldown-form
Dosant and others added 8 commits March 5, 2020 12:49
…ant/kibana into dev/drilldowns/create-drilldown-form

# Conflicts:
#	x-pack/plugins/advanced_ui_actions/public/components/action_wizard/action_wizard.test.tsx
#	x-pack/plugins/advanced_ui_actions/public/components/action_wizard/action_wizard.tsx
#	x-pack/plugins/advanced_ui_actions/public/components/action_wizard/test_data.tsx
…ant/kibana into dev/drilldowns/create-drilldown-form
@Dosant Dosant mentioned this pull request Mar 5, 2020
2 tasks
@streamich streamich mentioned this pull request Mar 5, 2020
7 tasks
@Dosant Dosant changed the title [wip][Drilldowns] <FormCreateDrilldown/> Component [wip][Drilldowns] Drilldown Wizard Components Mar 5, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant
Copy link
Contributor Author

Dosant commented Mar 10, 2020

Closing this in favour of: #59632

@Dosant Dosant closed this Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Drilldowns Embeddable panel Drilldowns
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants