From 133be2fa81fbd96c54e2bf6d755c8c02fbe256db Mon Sep 17 00:00:00 2001 From: streamich Date: Wed, 11 Mar 2020 19:17:41 +0100 Subject: [PATCH] =?UTF-8?q?fix:=20=F0=9F=90=9B=20don't=20overwrite=20expli?= =?UTF-8?q?citInput=20with=20combined=20input?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../embeddable_action_storage.test.ts | 17 +++++++++++++++++ .../embeddables/embeddable_action_storage.ts | 3 --- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/src/plugins/embeddable/public/lib/embeddables/embeddable_action_storage.test.ts b/src/plugins/embeddable/public/lib/embeddables/embeddable_action_storage.test.ts index f67a41596868f..eada20721d3e0 100644 --- a/src/plugins/embeddable/public/lib/embeddables/embeddable_action_storage.test.ts +++ b/src/plugins/embeddable/public/lib/embeddables/embeddable_action_storage.test.ts @@ -58,6 +58,23 @@ describe('EmbeddableActionStorage', () => { expect(events2).toEqual([event]); }); + test('does not merge .getInput() into .updateInput()', async () => { + const embeddable = new TestEmbeddable(); + const storage = new EmbeddableActionStorage(embeddable); + const event: UiActionsSerializedEvent = { + eventId: 'EVENT_ID', + triggerId: 'TRIGGER-ID', + action: {} as any, + }; + + const spy = jest.spyOn(embeddable, 'updateInput'); + + await storage.create(event); + + expect(spy.mock.calls[0][0].id).toBe(undefined); + expect(spy.mock.calls[0][0].viewMode).toBe(undefined); + }); + test('can create multiple events', async () => { const embeddable = new TestEmbeddable(); const storage = new EmbeddableActionStorage(embeddable); diff --git a/src/plugins/embeddable/public/lib/embeddables/embeddable_action_storage.ts b/src/plugins/embeddable/public/lib/embeddables/embeddable_action_storage.ts index b9a642fafeace..dc8466607a984 100644 --- a/src/plugins/embeddable/public/lib/embeddables/embeddable_action_storage.ts +++ b/src/plugins/embeddable/public/lib/embeddables/embeddable_action_storage.ts @@ -36,7 +36,6 @@ export class EmbeddableActionStorage implements UiActionsActionStorage { } this.embbeddable.updateInput({ - ...input, events: [...events, event], }); } @@ -55,7 +54,6 @@ export class EmbeddableActionStorage implements UiActionsActionStorage { } this.embbeddable.updateInput({ - ...input, events: [...events.slice(0, index), event, ...events.slice(index + 1)], }); } @@ -74,7 +72,6 @@ export class EmbeddableActionStorage implements UiActionsActionStorage { } this.embbeddable.updateInput({ - ...input, events: [...events.slice(0, index), ...events.slice(index + 1)], }); }